nushell/crates/nu-cli/src
Himadri Bhattacharjee 1c52b112c8
Return external file completions if not empty (#10898)
<!--
if this PR closes one or more issues, you can automatically link the PR
with
them by using one of the [*linking
keywords*](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword),
e.g.
- this PR should close #xxxx
- fixes #xxxx

you can also mention related issues, PRs or discussions!
-->

# Description
<!--
Thank you for improving Nushell. Please, check our [contributing
guide](../CONTRIBUTING.md) and talk to the core team before making major
changes.

Description of your pull request goes here. **Provide examples and/or
screenshots** if your changes affect the user experience.
-->
If an external completer is used and it returns no completions for a
filepath, we fall back to the builtin path completer.

# User-Facing Changes
<!-- List of all changes that impact the user experience here. This
helps us keep track of breaking changes. -->

Path completions will remain consistent with the use of an external
completer.

# Tests + Formatting
<!--
Don't forget to add tests that cover your changes.

Make sure you've run and fixed any issues with these commands:

- `cargo fmt --all -- --check` to check standard code formatting (`cargo
fmt --all` applies these changes)
- `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used` to
check that you're using the standard code style
- `cargo test --workspace` to check that all tests pass (on Windows make
sure to [enable developer
mode](https://learn.microsoft.com/en-us/windows/apps/get-started/developer-mode-features-and-debugging))
- `cargo run -- -c "use std testing; testing run-tests --path
crates/nu-std"` to run the tests for the standard library

> **Note**
> from `nushell` you can also use the `toolkit` as follows
> ```bash
> use toolkit.nu # or use an `env_change` hook to activate it
automatically
> toolkit check pr
> ```
-->

# After Submitting
<!-- If your PR had any user-facing changes, update [the
documentation](https://github.com/nushell/nushell.github.io) after the
PR is merged, if necessary. This will help us keep the docs up to date.
-->
2023-10-31 11:32:21 -05:00
..
commands Add long options for platform and random (#10776) 2023-10-19 22:04:33 +02:00
completions Return external file completions if not empty (#10898) 2023-10-31 11:32:21 -05:00
menus Add themes to help command when available #10318 (#10623) 2023-10-10 07:40:05 -05:00
config_files.rs Fix config creation during printing (#9353) 2023-06-04 22:04:28 +03:00
eval_cmds.rs Move CLI related commands to nu-cli (#8832) 2023-04-10 10:56:47 +12:00
eval_file.rs allow early return outside of main (#10514) 2023-09-28 18:49:42 +02:00
lib.rs cratification: move the bytes command to nu-cmd-extra (#9509) 2023-06-23 12:23:08 -07:00
nu_highlight.rs Move Value to helpers, separate span call (#10121) 2023-09-03 07:27:29 -07:00
print.rs allow print to take data as input again (#9823) 2023-07-27 21:40:25 +02:00
prompt_update.rs Reuse Closure type in Value::Closure (#10894) 2023-10-30 23:34:23 +01:00
prompt.rs Fix default prompt indicators (#9914) 2023-08-05 04:47:46 +12:00
reedline_config.rs Reuse Closure type in Value::Closure (#10894) 2023-10-30 23:34:23 +01:00
repl.rs Make hints aware of the current directory (#10780) 2023-10-20 11:21:58 +02:00
syntax_highlight.rs Use slices directly instead of &Vec (#10328) 2023-09-12 11:38:20 +08:00
util.rs Move Value to helpers, separate span call (#10121) 2023-09-03 07:27:29 -07:00
validation.rs Remove old alias implementation (#8797) 2023-04-07 21:09:38 +03:00