forked from extern/nushell
Also enforce this by #[non_exhaustive] span such that going forward we cannot, in debug builds (1), construct invalid spans. The motivation for this stems from #6431 where I've seen crashes due to invalid slice indexing. My hope is this will mitigate such senarios 1. https://github.com/nushell/nushell/pull/6431#issuecomment-1278147241 # Description (description of your pull request here) # Tests Make sure you've done the following: - [ ] Add tests that cover your changes, either in the command examples, the crate/tests folder, or in the /tests folder. - [ ] Try to think about corner cases and various ways how your changes could break. Cover them with tests. - [ ] If adding tests is not possible, please document in the PR body a minimal example with steps on how to reproduce so one can verify your change works. Make sure you've run and fixed any issues with these commands: - [x] `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - [ ] `cargo clippy --workspace --features=extra -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect` to check that you're using the standard code style - [ ] `cargo test --workspace --features=extra` to check that all the tests pass # Documentation - [ ] If your PR touches a user-facing nushell feature then make sure that there is an entry in the documentation (https://github.com/nushell/nushell.github.io) for the feature, and update it if necessary.
423 lines
14 KiB
Rust
423 lines
14 KiB
Rust
use std::collections::HashMap;
|
|
#[cfg(all(
|
|
feature = "trash-support",
|
|
not(target_os = "android"),
|
|
not(target_os = "ios")
|
|
))]
|
|
use std::io::ErrorKind;
|
|
#[cfg(unix)]
|
|
use std::os::unix::prelude::FileTypeExt;
|
|
use std::path::PathBuf;
|
|
|
|
use super::util::try_interaction;
|
|
|
|
use nu_engine::env::current_dir;
|
|
use nu_engine::CallExt;
|
|
use nu_protocol::ast::Call;
|
|
use nu_protocol::engine::{Command, EngineState, Stack};
|
|
use nu_protocol::{
|
|
Category, Example, IntoInterruptiblePipelineData, PipelineData, ShellError, Signature, Span,
|
|
Spanned, SyntaxShape, Type, Value,
|
|
};
|
|
|
|
const GLOB_PARAMS: nu_glob::MatchOptions = nu_glob::MatchOptions {
|
|
case_sensitive: true,
|
|
require_literal_separator: false,
|
|
require_literal_leading_dot: false,
|
|
recursive_match_hidden_dir: true,
|
|
};
|
|
|
|
#[derive(Clone)]
|
|
pub struct Rm;
|
|
|
|
impl Command for Rm {
|
|
fn name(&self) -> &str {
|
|
"rm"
|
|
}
|
|
|
|
fn usage(&self) -> &str {
|
|
"Remove files and directories."
|
|
}
|
|
|
|
fn search_terms(&self) -> Vec<&str> {
|
|
vec!["delete", "remove"]
|
|
}
|
|
|
|
fn signature(&self) -> Signature {
|
|
let sig = Signature::build("rm");
|
|
#[cfg(all(
|
|
feature = "trash-support",
|
|
not(target_os = "android"),
|
|
not(target_os = "ios")
|
|
))]
|
|
let sig = sig
|
|
.switch(
|
|
"trash",
|
|
"move to the platform's trash instead of permanently deleting",
|
|
Some('t'),
|
|
)
|
|
.switch(
|
|
"permanent",
|
|
"delete permanently, ignoring the 'always_trash' config option",
|
|
Some('p'),
|
|
);
|
|
sig.switch("recursive", "delete subdirectories recursively", Some('r'))
|
|
.switch("force", "suppress error when no file", Some('f'))
|
|
.switch("verbose", "print names of deleted files", Some('v'))
|
|
.switch("interactive", "ask user to confirm action", Some('i'))
|
|
.rest(
|
|
"rest",
|
|
SyntaxShape::GlobPattern,
|
|
"the file path(s) to remove",
|
|
)
|
|
.category(Category::FileSystem)
|
|
}
|
|
|
|
fn run(
|
|
&self,
|
|
engine_state: &EngineState,
|
|
stack: &mut Stack,
|
|
call: &Call,
|
|
_input: PipelineData,
|
|
) -> Result<PipelineData, ShellError> {
|
|
rm(engine_state, stack, call)
|
|
}
|
|
|
|
fn examples(&self) -> Vec<Example> {
|
|
let mut examples = vec![Example {
|
|
description:
|
|
"Delete, or move a file to the trash (based on the 'always_trash' config option)",
|
|
example: "rm file.txt",
|
|
result: None,
|
|
}];
|
|
#[cfg(all(
|
|
feature = "trash-support",
|
|
not(target_os = "android"),
|
|
not(target_os = "ios")
|
|
))]
|
|
examples.append(&mut vec![
|
|
Example {
|
|
description: "Move a file to the trash",
|
|
example: "rm --trash file.txt",
|
|
result: None,
|
|
},
|
|
Example {
|
|
description:
|
|
"Delete a file permanently, even if the 'always_trash' config option is true",
|
|
example: "rm --permanent file.txt",
|
|
result: None,
|
|
},
|
|
]);
|
|
examples.push(Example {
|
|
description: "Delete a file, ignoring 'file not found' errors",
|
|
example: "rm --force file.txt",
|
|
result: None,
|
|
});
|
|
examples.push(Example {
|
|
description: "Delete all 0KB files in the current directory",
|
|
example: "ls | where size == 0KB && type == file | each { rm $in.name } | null",
|
|
result: None,
|
|
});
|
|
examples
|
|
}
|
|
}
|
|
|
|
fn rm(
|
|
engine_state: &EngineState,
|
|
stack: &mut Stack,
|
|
call: &Call,
|
|
) -> Result<PipelineData, ShellError> {
|
|
let trash = call.has_flag("trash");
|
|
#[cfg(all(
|
|
feature = "trash-support",
|
|
not(target_os = "android"),
|
|
not(target_os = "ios")
|
|
))]
|
|
let permanent = call.has_flag("permanent");
|
|
let recursive = call.has_flag("recursive");
|
|
let force = call.has_flag("force");
|
|
let verbose = call.has_flag("verbose");
|
|
let interactive = call.has_flag("interactive");
|
|
|
|
let ctrlc = engine_state.ctrlc.clone();
|
|
|
|
let mut targets: Vec<Spanned<String>> = call.rest(engine_state, stack, 0)?;
|
|
|
|
for (idx, path) in targets.clone().into_iter().enumerate() {
|
|
let corrected_path = Spanned {
|
|
item: nu_utils::strip_ansi_string_unlikely(path.item),
|
|
span: path.span,
|
|
};
|
|
let _ = std::mem::replace(&mut targets[idx], corrected_path);
|
|
}
|
|
|
|
let span = call.head;
|
|
|
|
let config = engine_state.get_config();
|
|
|
|
let rm_always_trash = config.rm_always_trash;
|
|
|
|
#[cfg(any(
|
|
not(feature = "trash-support"),
|
|
target_os = "android",
|
|
target_os = "ios"
|
|
))]
|
|
{
|
|
if rm_always_trash {
|
|
return Err(ShellError::GenericError(
|
|
"Cannot execute `rm`; the current configuration specifies \
|
|
`always_trash = true`, but the current nu executable was not \
|
|
built with feature `trash_support` or trash is not supported on \
|
|
your platform."
|
|
.into(),
|
|
"trash required to be true but not supported".into(),
|
|
Some(span),
|
|
None,
|
|
Vec::new(),
|
|
));
|
|
} else if trash {
|
|
return Err(ShellError::GenericError(
|
|
"Cannot execute `rm` with option `--trash`; feature `trash-support` not \
|
|
enabled or trash is not supported on your platform"
|
|
.into(),
|
|
"this option is only available if nu is built with the `trash-support` feature"
|
|
.into(),
|
|
Some(span),
|
|
None,
|
|
Vec::new(),
|
|
));
|
|
}
|
|
}
|
|
|
|
if targets.is_empty() {
|
|
return Err(ShellError::GenericError(
|
|
"rm requires target paths".into(),
|
|
"needs parameter".into(),
|
|
Some(span),
|
|
None,
|
|
Vec::new(),
|
|
));
|
|
}
|
|
|
|
let targets_span = Span::new(
|
|
targets
|
|
.iter()
|
|
.map(|x| x.span.start)
|
|
.min()
|
|
.expect("targets were empty"),
|
|
targets
|
|
.iter()
|
|
.map(|x| x.span.end)
|
|
.max()
|
|
.expect("targets were empty"),
|
|
);
|
|
|
|
let path = current_dir(engine_state, stack)?;
|
|
|
|
let (mut target_exists, mut empty_span) = (false, call.head);
|
|
let mut all_targets: HashMap<PathBuf, Span> = HashMap::new();
|
|
|
|
for target in targets {
|
|
if path.to_string_lossy() == target.item
|
|
|| path.as_os_str().to_string_lossy().starts_with(&format!(
|
|
"{}{}",
|
|
target.item,
|
|
std::path::MAIN_SEPARATOR
|
|
))
|
|
{
|
|
return Err(ShellError::GenericError(
|
|
"Cannot remove any parent directory".into(),
|
|
"cannot remove any parent directory".into(),
|
|
Some(target.span),
|
|
None,
|
|
Vec::new(),
|
|
));
|
|
}
|
|
|
|
let path = path.join(&target.item);
|
|
match nu_glob::glob_with(
|
|
&path.to_string_lossy(),
|
|
nu_glob::MatchOptions {
|
|
require_literal_leading_dot: true,
|
|
..GLOB_PARAMS
|
|
},
|
|
) {
|
|
Ok(files) => {
|
|
for file in files {
|
|
match file {
|
|
Ok(ref f) => {
|
|
if !target_exists {
|
|
target_exists = true;
|
|
}
|
|
|
|
// It is not appropriate to try and remove the
|
|
// current directory or its parent when using
|
|
// glob patterns.
|
|
let name = f.display().to_string();
|
|
if name.ends_with("/.") || name.ends_with("/..") {
|
|
continue;
|
|
}
|
|
|
|
all_targets.entry(f.clone()).or_insert_with(|| target.span);
|
|
}
|
|
Err(e) => {
|
|
return Err(ShellError::GenericError(
|
|
format!("Could not remove {:}", path.to_string_lossy()),
|
|
e.to_string(),
|
|
Some(target.span),
|
|
None,
|
|
Vec::new(),
|
|
));
|
|
}
|
|
}
|
|
}
|
|
|
|
// Target doesn't exists
|
|
if !target_exists && empty_span.eq(&call.head) {
|
|
empty_span = target.span;
|
|
}
|
|
}
|
|
Err(e) => {
|
|
return Err(ShellError::GenericError(
|
|
e.to_string(),
|
|
e.to_string(),
|
|
Some(target.span),
|
|
None,
|
|
Vec::new(),
|
|
))
|
|
}
|
|
};
|
|
}
|
|
|
|
if all_targets.is_empty() && !force {
|
|
return Err(ShellError::GenericError(
|
|
"File(s) not found".into(),
|
|
"File(s) not found".into(),
|
|
Some(targets_span),
|
|
None,
|
|
Vec::new(),
|
|
));
|
|
}
|
|
|
|
Ok(all_targets
|
|
.into_keys()
|
|
.map(move |f| {
|
|
let is_empty = || match f.read_dir() {
|
|
Ok(mut p) => p.next().is_none(),
|
|
Err(_) => false,
|
|
};
|
|
|
|
if let Ok(metadata) = f.symlink_metadata() {
|
|
#[cfg(unix)]
|
|
let is_socket = metadata.file_type().is_socket();
|
|
#[cfg(unix)]
|
|
let is_fifo = metadata.file_type().is_fifo();
|
|
|
|
#[cfg(not(unix))]
|
|
let is_socket = false;
|
|
#[cfg(not(unix))]
|
|
let is_fifo = false;
|
|
|
|
if metadata.is_file()
|
|
|| metadata.file_type().is_symlink()
|
|
|| recursive
|
|
|| is_socket
|
|
|| is_fifo
|
|
|| is_empty()
|
|
{
|
|
let (interaction, confirmed) =
|
|
try_interaction(interactive, "rm: remove", &f.to_string_lossy());
|
|
|
|
let result;
|
|
#[cfg(all(
|
|
feature = "trash-support",
|
|
not(target_os = "android"),
|
|
not(target_os = "ios")
|
|
))]
|
|
{
|
|
use std::io::Error;
|
|
result = if let Err(e) = interaction {
|
|
let e = Error::new(ErrorKind::Other, &*e.to_string());
|
|
Err(e)
|
|
} else if interactive && !confirmed {
|
|
Ok(())
|
|
} else if trash || (rm_always_trash && !permanent) {
|
|
trash::delete(&f).map_err(|e: trash::Error| {
|
|
Error::new(ErrorKind::Other, format!("{:?}\nTry '--trash' flag", e))
|
|
})
|
|
} else if metadata.is_file() || is_socket || is_fifo {
|
|
std::fs::remove_file(&f)
|
|
} else {
|
|
std::fs::remove_dir_all(&f)
|
|
};
|
|
}
|
|
#[cfg(any(
|
|
not(feature = "trash-support"),
|
|
target_os = "android",
|
|
target_os = "ios"
|
|
))]
|
|
{
|
|
use std::io::{Error, ErrorKind};
|
|
result = if let Err(e) = interaction {
|
|
let e = Error::new(ErrorKind::Other, &*e.to_string());
|
|
Err(e)
|
|
} else if interactive && !confirmed {
|
|
Ok(())
|
|
} else if metadata.is_file() || is_socket || is_fifo {
|
|
std::fs::remove_file(&f)
|
|
} else {
|
|
std::fs::remove_dir_all(&f)
|
|
};
|
|
}
|
|
|
|
if let Err(e) = result {
|
|
let msg = format!("Could not delete because: {:}", e);
|
|
Value::Error {
|
|
error: ShellError::GenericError(
|
|
msg,
|
|
e.to_string(),
|
|
Some(span),
|
|
None,
|
|
Vec::new(),
|
|
),
|
|
}
|
|
} else if verbose {
|
|
let msg = if interactive && !confirmed {
|
|
"not deleted"
|
|
} else {
|
|
"deleted"
|
|
};
|
|
let val = format!("{} {:}", msg, f.to_string_lossy());
|
|
Value::String { val, span }
|
|
} else {
|
|
Value::Nothing { span }
|
|
}
|
|
} else {
|
|
let msg = format!("Cannot remove {:}. try --recursive", f.to_string_lossy());
|
|
Value::Error {
|
|
error: ShellError::GenericError(
|
|
msg,
|
|
"cannot remove non-empty directory".into(),
|
|
Some(span),
|
|
None,
|
|
Vec::new(),
|
|
),
|
|
}
|
|
}
|
|
} else {
|
|
let msg = format!("no such file or directory: {:}", f.to_string_lossy());
|
|
Value::Error {
|
|
error: ShellError::GenericError(
|
|
msg,
|
|
"no such file or directory".into(),
|
|
Some(span),
|
|
None,
|
|
Vec::new(),
|
|
),
|
|
}
|
|
}
|
|
})
|
|
.filter(|x| !matches!(x.get_type(), Type::Nothing))
|
|
.into_pipeline_data(ctrlc))
|
|
}
|