holm/nushell
1
1
Fork 0
forked from extern/nushell
Code Issues Pull Requests Packages Projects Releases Wiki Activity
2bacc29d30
nushell/crates/nu-command/tests/commands
History
Jakub Žádník 2bacc29d30
Replace row conditions with closures in commands (#7428) 
# Description

This PR changes some commands that previously accepted row conditions
(like `$it > 5`) as parameter to accept closures instead. The reasons
are:
a) The commands would need to move into parser keywords in the future
while they feel more like commands to be implemented in Nushell code as
a part of standard library.
b) In scripts, it is useful to store the predicate condition in a
variable which you can't do with row conditions.
c) These commands are not used that often to benefit enough from the
shorter row condition syntax

# User-Facing Changes

The following commands now accept **closure** instead of a **row
condition**:
- `take until`
- `take while`
- `skip until`
- `skip while`
- `any`
- `all`

This is a part of an effort to move away from shape-directed parsing.
Related PR: https://github.com/nushell/nushell/pull/7365

# Tests + Formatting

Don't forget to add tests that cover your changes.

Make sure you've run and fixed any issues with these commands:

- `cargo fmt --all -- --check` to check standard code formatting (`cargo
fmt --all` applies these changes)
- `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A
clippy::needless_collect` to check that you're using the standard code
style
- `cargo test --workspace` to check that all tests pass

# After Submitting

If your PR had any user-facing changes, update [the
documentation](https://github.com/nushell/nushell.github.io) after the
PR is merged, if necessary. This will help us keep the docs up to date.
2022-12-10 19:24:06 +02:00
..
assignment ++= appendAssign operator (#7346) (#7354) 2022-12-09 11:20:58 -05:00
date Require input for date format (#7043) 2022-11-10 11:16:14 +13:00
hash_ Deprecate hash base64, extend decode and add encode commands (#5863) 2022-06-26 00:35:23 +03:00
math Better errors when bash-like operators are used (#7241) 2022-12-08 12:02:11 +13:00
move_ Fix mv error message issues (arrows, Windows paths) (#7197) 2022-11-23 16:55:13 +13:00
network Clippy fix for Rust 1.63 (#6299) 2022-08-11 11:54:54 -05:00
path add -n for path expand, so it doesn't follow symlink (#6255) 2022-08-10 08:43:56 -05:00
platform Return error when kill didn't terminate successfully (#6354) 2022-08-18 11:58:51 -05:00
query Feature cleanup (#7182) 2022-11-22 16:58:11 -08:00
random Another batch of command tests (#4496) 2022-02-16 07:38:02 -05:00
skip Replace row conditions with closures in commands (#7428) 2022-12-10 19:24:06 +02:00
str_ Eval external command result immediately when using do command with -c (#6645) 2022-09-30 07:14:02 -05:00
take Replace row conditions with closures in commands (#7428) 2022-12-10 19:24:06 +02:00
url new command url parse (#6854) and url subcommands tests (#7124) 2022-11-19 10:14:29 -08:00
alias.rs let alias list aliases (#6717) 2022-10-14 21:51:44 +02:00
all.rs Replace row conditions with closures in commands (#7428) 2022-12-10 19:24:06 +02:00
any.rs Replace row conditions with closures in commands (#7428) 2022-12-10 19:24:06 +02:00
append.rs Strip trailing whitespace in files (#4575) 2022-02-21 08:38:15 -05:00
break_.rs New commands: break, continue, return, and loop (#7230) 2022-11-25 09:39:16 +13:00
cal.rs Remove old nushell/merge engine-q 2022-02-07 14:54:06 -05:00
cd.rs fix: fixcd (#6799) 2022-11-05 07:38:39 +13:00
compact.rs Remove old nushell/merge engine-q 2022-02-07 14:54:06 -05:00
continue_.rs New commands: break, continue, return, and loop (#7230) 2022-11-25 09:39:16 +13:00
cp.rs Add decimals to int when using into string --decimals (#6085) 2022-08-12 21:13:50 -05:00
def.rs Move from source to source-env (#6277) 2022-09-01 08:32:56 +12:00
default.rs Remove old nushell/merge engine-q 2022-02-07 14:54:06 -05:00
do_.rs A set of fixes for stderr redirect (#7219) 2022-11-24 16:58:15 +13:00
drop.rs Rename all?, any? and empty? (#6464) 2022-09-05 16:41:06 +02:00
each.rs Remove erroneous test (#7179) 2022-11-21 17:04:36 +01:00
echo.rs Require block params (#4505) 2022-02-17 06:40:24 -05:00
empty.rs Fix $in in blocks given to any and all (#6951) 2022-11-01 11:36:54 -07:00
enter.rs Remove old nushell/merge engine-q 2022-02-07 14:54:06 -05:00
error_make.rs add unspanned flag to error make, add tests (#6017) 2022-07-12 06:03:50 -05:00
every.rs Another batch of command tests (#4496) 2022-02-16 07:38:02 -05:00
export_def.rs allow -h flags for export subcommands (#6189) 2022-08-02 10:26:16 -05:00
find.rs Use 'table' on scripts and -c commands (#4377) 2022-02-09 05:58:54 -05:00
first.rs Error on negative argument of first (#7186) 2022-11-23 17:04:28 +13:00
flatten.rs str collect => str join (#6531) 2022-09-11 11:48:27 +03:00
format.rs Refactor: introduce general operate commands to reduce duplicate code (#6879) 2022-10-29 16:29:46 -05:00
g.rs Make g - switch to the last used shell (#6249) 2022-08-06 10:11:03 -05:00
get.rs Friendly error message for access beyond end (#6944) 2022-10-29 19:47:50 +02:00
glob.rs Filter out empty glob patterns to "glob" command (#6707) 2022-10-15 18:00:38 +02:00
group_by.rs more test fixes (#4499) 2022-02-16 12:24:45 -06:00
headers.rs Type validation for headers command (#6918) (#7047) 2022-11-09 16:43:24 -08:00
help.rs add signature information when get help on one command (#7079) 2022-11-20 07:22:42 -06:00
histogram.rs add quantile column (#5583) 2022-05-18 20:47:26 -05:00
insert.rs Allow iteration blocks to have an optional extra index parameter (alternative to -n flags) (#6994) 2022-11-21 14:35:11 +01:00
into_cellpath.rs into cellpath command (#7417) 2022-12-10 15:26:42 +02:00
into_filesize.rs fix overflow on negative bytes (#7070) 2022-11-10 22:33:15 +01:00
into_int.rs Binary into int (#5941) 2022-07-04 06:31:50 +12:00
last.rs Error on negative argument to last (#7184) 2022-11-23 17:04:04 +13:00
length.rs Remove old nushell/merge engine-q 2022-02-07 14:54:06 -05:00
let_.rs Limited mutable variables (#7089) 2022-11-11 19:51:08 +13:00
lines.rs Replace row conditions with closures in commands (#7428) 2022-12-10 19:24:06 +02:00
ls.rs Run a round of clippy --fix to fix a ton of lints (#7006) 2022-11-04 15:11:17 -05:00
merge.rs remove block input support in merge (#7177) 2022-11-23 17:01:27 +13:00
mkdir.rs Remove old nushell/merge engine-q 2022-02-07 14:54:06 -05:00
mod.rs into cellpath command (#7417) 2022-12-10 15:26:42 +02:00
mut_.rs Allow $env and mutable records to be mutated by = (closes #7110) (#7318) 2022-12-06 19:51:55 +02:00
n.rs Refactor shell switching related code (#6258) 2022-08-07 13:30:40 -05:00
nu_check.rs A set of fixes for stderr redirect (#7219) 2022-11-24 16:58:15 +13:00
open.rs Feature cleanup (#7182) 2022-11-22 16:58:11 -08:00
p.rs Refactor shell switching related code (#6258) 2022-08-07 13:30:40 -05:00
parse.rs replace the regex crate with the fancy-regex crate (#6227) 2022-08-04 14:51:02 -05:00
prepend.rs Use 'table' on scripts and -c commands (#4377) 2022-02-09 05:58:54 -05:00
print.rs add -e flag to print, to print the value to stderr (#5935) 2022-07-02 09:54:49 -05:00
range.rs Use 'table' on scripts and -c commands (#4377) 2022-02-09 05:58:54 -05:00
redirection.rs A set of fixes for stderr redirect (#7219) 2022-11-24 16:58:15 +13:00
reduce.rs Allow iteration blocks to have an optional extra index parameter (alternative to -n flags) (#6994) 2022-11-21 14:35:11 +01:00
reject.rs add signature information when get help on one command (#7079) 2022-11-20 07:22:42 -06:00
rename.rs add rename (#5534) 2022-05-13 06:47:11 -05:00
return_.rs New commands: break, continue, return, and loop (#7230) 2022-11-25 09:39:16 +13:00
reverse.rs make first behave same way as last: always return list when with number argument (#6616) 2022-09-28 17:08:17 -05:00
rm.rs make cd, cp, ls, mv, open and rm automatically strip ansi codes (#6220) 2022-08-04 06:59:20 -05:00
roll.rs str collect => str join (#6531) 2022-09-11 11:48:27 +03:00
rotate.rs str collect => str join (#6531) 2022-09-11 11:48:27 +03:00
run_external.rs add some float operations with filesize (#6618) 2022-09-28 17:07:50 -05:00
save.rs add -f, --force for save command (#7262) 2022-12-01 06:26:17 -06:00
select.rs Fix ignore-errors for select (#6896) 2022-11-10 10:57:44 +13:00
semicolon.rs Remove old nushell/merge engine-q 2022-02-07 14:54:06 -05:00
seq_char.rs Simplify seq char (#7054) 2022-11-09 17:06:47 -08:00
seq.rs Make seq return a ListStream where possible (#7367) 2022-12-06 18:48:03 -08:00
shells.rs Refactor shell listing related code (#6262) 2022-08-08 06:31:24 -05:00
sort_by.rs Require column name(s) in sort-by (#7041) 2022-11-10 11:16:51 +13:00
sort.rs Add -n flag to sort (formerly only available on sort-by) (#7293) 2022-12-01 07:11:30 -06:00
source_env.rs Make env-related tests more resilient (#7423) 2022-12-10 19:23:34 +02:00
split_by.rs Remove old nushell/merge engine-q 2022-02-07 14:54:06 -05:00
split_column.rs refactor: change column names from 'Column*' to 'column*' (#4556) 2022-02-19 19:26:47 -05:00
split_row.rs Remove old nushell/merge engine-q 2022-02-07 14:54:06 -05:00
table.rs Try to fix #7338 (#7343) 2022-12-04 17:47:46 -06:00
touch.rs chore: chrono_update (#7132) 2022-11-27 07:19:02 +13:00
transpose.rs Prevents duplicate fields in transpose -r (#5840) 2022-06-22 19:19:06 -05:00
try_.rs fix try for external command runs to failed (#7300) 2022-12-02 05:58:32 +13:00
uniq_by.rs uniq-by command (#7295) 2022-12-02 11:36:01 +01:00
uniq.rs uniq -i does not convert to lowercase (#7192) (#7209) 2022-11-23 15:46:20 -08:00
update.rs Improve empty pipelines (#7383) 2022-12-08 07:31:57 +13:00
upsert.rs Improve empty pipelines (#7383) 2022-12-08 07:31:57 +13:00
use_.rs Make env-related tests more resilient (#7423) 2022-12-10 19:23:34 +02:00
where_.rs Move 'where' to parser keywords; Add 'filter' command (#7365) 2022-12-10 19:23:24 +02:00
which.rs Don't assume external ls (#4925) 2022-03-24 16:42:41 +13:00
while_.rs Add support for while loops (#7101) 2022-11-12 07:21:45 +13:00
with_env.rs fixed some more tests (#4607) 2022-02-22 11:32:29 -05:00
wrap.rs Use 'table' on scripts and -c commands (#4377) 2022-02-09 05:58:54 -05:00
zip.rs Better errors when bash-like operators are used (#7241) 2022-12-08 12:02:11 +13:00