forked from extern/nushell
0567407f85
Should close one of the tasks in #8450. # Description > **Note** > in order of appearance in the global diff -1b7497c419adds the `std-tests` job to the CI which 1. installs `nushell` in the runner 2. run the `tests.nu` module > see `open .github/workflows/ci.yml | get jobs.std-tests | to yaml` - [`ec85b6fd`..`9c122115`](ec85b6fd3fc004cd94e3fada5c8e5fe2714fd629..9c12211564ca8ee90ed65ae45776dccb8f8e4ef1) is where all the magic happens => see below - 🧪799c7eb7fdintroduces some bugs and failing test to see how the CI behaves => see how the [tests failed](https://github.com/nushell/nushell/actions/runs/4460098237/jobs/7833018256) as expected ❌ - 🧪 andc3de1fafb5reverts the failing tests, i.e. the previous commit, leaving a standard library whose tests all pass 🎉 => see the [tests passing](https://github.com/nushell/nushell/actions/runs/4460153434/jobs/7833110719?pr=8525#step:5:1) now ✔️ ## the changes to the runner > see [`ec85b6fd`..`9c122115`](ec85b6fd3fc004cd94e3fada5c8e5fe2714fd629..9c12211564ca8ee90ed65ae45776dccb8f8e4ef1) the issue with the previous runner was the following: the clever trick of using `nu -c "use ...; test"` did print the errors when occuring but they did not capture the true "failure", i.e. in all cases the `$env.LAST_EXIT_CODE` was set to `0`, never stopping the CI when a test failed 🤔 i first tried to `try` / `catch` the error inec85b6fd3fwhich kinda worked but only throw a single error, the first one i thought it was not the best and started thinking about a solution to have a complete report of all failing tests, at once, to avoid running the CI multiple times! the easiest solution i found was the one i implemented in9c12211564> **Warning** > this changes the structure of the runner quite a bit, but the `for` loops where annoying to manipulate structured data and allow the runner to draw a complete report... now the runner does the following - compute the list of all available tests in a table with the `file`, `module` and `name` columns (first part of the pipe until `flatten` and `rename`) - run the tests one by one computing the new `pass` column - with a `log info` - captures the failing ones => puts `true` in `pass` if the test passes, `false` otherwise - if at least one test has failed, throw a single error with the list of failing tests ### hope you'll like it 😌 # User-Facing Changes ``` $nothing ``` # Tests + Formatting the standard tests now return a true error that will stop the CI # After Submitting ``` $nothing ```
209 lines
6.3 KiB
YAML
209 lines
6.3 KiB
YAML
on:
|
|
pull_request:
|
|
push: # Run CI on the main branch after every merge. This is important to fill the GitHub Actions cache in a way that pull requests can see it
|
|
branches:
|
|
- main
|
|
|
|
name: continuous-integration
|
|
|
|
jobs:
|
|
nu-fmt-clippy:
|
|
strategy:
|
|
fail-fast: true
|
|
matrix:
|
|
# Pinning to Ubuntu 20.04 because building on newer Ubuntu versions causes linux-gnu
|
|
# builds to link against a too-new-for-many-Linux-installs glibc version. Consider
|
|
# revisiting this when 20.04 is closer to EOL (April 2025)
|
|
platform: [windows-latest, macos-latest, ubuntu-20.04]
|
|
style: [default, dataframe]
|
|
rust:
|
|
- stable
|
|
include:
|
|
- style: default
|
|
flags: ""
|
|
- style: dataframe
|
|
flags: "--features=dataframe "
|
|
exclude:
|
|
# only test dataframes on Ubuntu (the fastest platform)
|
|
- platform: windows-latest
|
|
style: dataframe
|
|
- platform: macos-latest
|
|
style: dataframe
|
|
|
|
|
|
|
|
runs-on: ${{ matrix.platform }}
|
|
env:
|
|
NUSHELL_CARGO_TARGET: ci
|
|
|
|
steps:
|
|
- uses: actions/checkout@v3
|
|
|
|
- name: Setup Rust toolchain and cache
|
|
uses: actions-rust-lang/setup-rust-toolchain@v1.4.4
|
|
|
|
- name: cargo fmt
|
|
run: cargo fmt --all -- --check
|
|
|
|
- name: Clippy
|
|
run: cargo clippy --workspace ${{ matrix.flags }}--exclude nu_plugin_* -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect
|
|
|
|
nu-tests:
|
|
env:
|
|
NUSHELL_CARGO_TARGET: ci
|
|
|
|
strategy:
|
|
fail-fast: true
|
|
matrix:
|
|
platform: [windows-latest, macos-latest, ubuntu-20.04]
|
|
style: [default, dataframe]
|
|
rust:
|
|
- stable
|
|
include:
|
|
- style: default
|
|
flags: ""
|
|
- style: dataframe
|
|
flags: "--features=dataframe"
|
|
exclude:
|
|
# only test dataframes on Ubuntu (the fastest platform)
|
|
- platform: windows-latest
|
|
style: dataframe
|
|
- platform: macos-latest
|
|
style: dataframe
|
|
|
|
runs-on: ${{ matrix.platform }}
|
|
|
|
steps:
|
|
- uses: actions/checkout@v3
|
|
|
|
- name: Setup Rust toolchain and cache
|
|
uses: actions-rust-lang/setup-rust-toolchain@v1.4.4
|
|
|
|
- name: Tests
|
|
run: cargo test --workspace --profile ci --exclude nu_plugin_* ${{ matrix.flags }}
|
|
|
|
std-lib-and-python-virtualenv:
|
|
env:
|
|
NU_LOG_LEVEL: DEBUG
|
|
|
|
strategy:
|
|
fail-fast: true
|
|
matrix:
|
|
platform: [ubuntu-20.04, macos-latest, windows-latest]
|
|
rust:
|
|
- stable
|
|
py:
|
|
- py
|
|
|
|
runs-on: ${{ matrix.platform }}
|
|
|
|
steps:
|
|
- uses: actions/checkout@v3
|
|
|
|
- name: Setup Rust toolchain and cache
|
|
uses: actions-rust-lang/setup-rust-toolchain@v1.4.4
|
|
|
|
- name: Install Nushell
|
|
# prior to [*standard library: bring the tests into the main CI*](#8525)
|
|
# there was a `--profile ci` here in the `cargo install`, as well as
|
|
# `NUSHELL_CARGO_TARGET: ci` in the prelude above.
|
|
#
|
|
# this caused a "stackoverflow" error in the CI on windows,
|
|
# see [this failing job](https://github.com/nushell/nushell/actions/runs/4512034615/jobs/7944945590)
|
|
#
|
|
# the CI profile has been removed in 00b820de9021227d1910a9ea388297ee7aee308e
|
|
# as part of #8525.
|
|
run: cargo install --path . --locked --no-default-features
|
|
|
|
- name: Standard library tests
|
|
run: nu crates/nu-utils/standard_library/tests.nu
|
|
|
|
- name: Setup Python
|
|
uses: actions/setup-python@v4
|
|
with:
|
|
python-version: "3.10"
|
|
|
|
- run: python -m pip install tox
|
|
|
|
# Get only the latest tagged version for stability reasons
|
|
- name: Install virtualenv
|
|
run: git clone https://github.com/pypa/virtualenv.git
|
|
shell: bash
|
|
|
|
- name: Test Nushell in virtualenv
|
|
run: |
|
|
cd virtualenv
|
|
# if we encounter problems with bleeding edge tests pin to the latest tag
|
|
# git checkout $(git describe --tags | cut -d - -f 1)
|
|
# We need to disable failing on coverage levels.
|
|
nu -c "open pyproject.toml | upsert tool.coverage.report.fail_under 1 | save patchproject.toml"
|
|
mv patchproject.toml pyproject.toml
|
|
tox -e ${{ matrix.py }} -- -k nushell
|
|
shell: bash
|
|
|
|
# Build+test plugins on their own, without the rest of Nu. This helps with CI parallelization and
|
|
# also helps test that the plugins build without any feature unification shenanigans
|
|
plugins:
|
|
env:
|
|
NUSHELL_CARGO_TARGET: ci
|
|
|
|
strategy:
|
|
fail-fast: true
|
|
matrix:
|
|
platform: [windows-latest, macos-latest, ubuntu-20.04]
|
|
rust:
|
|
- stable
|
|
|
|
runs-on: ${{ matrix.platform }}
|
|
|
|
steps:
|
|
- uses: actions/checkout@v3
|
|
|
|
- name: Setup Rust toolchain and cache
|
|
uses: actions-rust-lang/setup-rust-toolchain@v1.4.4
|
|
|
|
- name: Clippy
|
|
run: cargo clippy --package nu_plugin_* ${{ matrix.flags }} -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect
|
|
|
|
- name: Tests
|
|
run: cargo test --profile ci --package nu_plugin_*
|
|
|
|
|
|
nu-coverage:
|
|
needs: nu-tests
|
|
env:
|
|
NUSHELL_CARGO_TARGET: ci
|
|
|
|
strategy:
|
|
fail-fast: true
|
|
matrix:
|
|
# disabled mac due to problems with merging coverage and similarity to linux
|
|
# disabled windows due to running out of disk space when having too many crates or tests
|
|
platform: [ubuntu-20.04] # windows-latest
|
|
rust:
|
|
- stable
|
|
|
|
runs-on: ${{ matrix.platform }}
|
|
|
|
steps:
|
|
- uses: actions/checkout@v3
|
|
|
|
- name: Setup Rust toolchain and cache
|
|
uses: actions-rust-lang/setup-rust-toolchain@v1.4.4
|
|
- name: Install cargo-llvm-cov
|
|
uses: taiki-e/install-action@cargo-llvm-cov
|
|
|
|
- name: Tests
|
|
shell: bash
|
|
run: |
|
|
source <(cargo llvm-cov show-env --export-prefix) # Set the environment variables needed to get coverage.
|
|
cargo llvm-cov clean --workspace # Remove artifacts that may affect the coverage results.
|
|
cargo build --workspace --profile ci
|
|
cargo test --workspace --profile ci
|
|
cargo llvm-cov report --profile ci --lcov --output-path lcov.info
|
|
|
|
- name: Upload coverage reports to Codecov with GitHub Action
|
|
uses: codecov/codecov-action@v3
|
|
with:
|
|
files: lcov.info
|