forked from extern/nushell
208ffdc1da
# Description From nushell 0.8 philosophy: https://github.com/nushell/nushell.github.io/blob/main/contributor-book/philosophy_0_80.md#core-categories > The following categories should be moved to plugins: Uncommon format support So this pr is trying to move following commands to plugin: - [X] from eml - [x] from ics - [x] from ini - [x] from vcf And we can have a new plugin handles for these formatting, currently it's implemented here: https://github.com/WindSoilder/nu_plugin_format The command usage should be the same to original command. If it's ok, the plugin can support more formats like [parquet](https://github.com/fdncred/nu_plugin_from_parquet), or [EDN format](https://github.com/nushell/nushell/issues/6415), or something else. Just create a draft pr to show what's the blueprint looks like, and is it a good direction to move forward? # User-Facing Changes _(List of all changes that impact the user experience here. This helps us keep track of breaking changes.)_ # Tests + Formatting Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass # After Submitting If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date.
84 lines
2.5 KiB
Rust
84 lines
2.5 KiB
Rust
use nu_test_support::fs::Stub::FileWithContentToBeTrimmed;
|
|
use nu_test_support::nu_with_plugins;
|
|
use nu_test_support::playground::Playground;
|
|
|
|
#[test]
|
|
fn infers_types() {
|
|
Playground::setup("filter_from_vcf_test_1", |dirs, sandbox| {
|
|
sandbox.with_files(vec![FileWithContentToBeTrimmed(
|
|
"contacts.vcf",
|
|
r#"
|
|
BEGIN:VCARD
|
|
VERSION:3.0
|
|
FN:John Doe
|
|
N:Doe;John;;;
|
|
EMAIL;TYPE=INTERNET:john.doe99@gmail.com
|
|
item1.ORG:'Alpine Ski Resort'
|
|
item1.X-ABLabel:Other
|
|
item2.TITLE:'Ski Instructor'
|
|
item2.X-ABLabel:Other
|
|
BDAY:19001106
|
|
NOTE:Facebook: john.doe.3\nWebsite: \nHometown: Cleveland\, Ohio
|
|
CATEGORIES:myContacts
|
|
END:VCARD
|
|
BEGIN:VCARD
|
|
VERSION:3.0
|
|
FN:Alex Smith
|
|
N:Smith;Alex;;;
|
|
TEL;TYPE=CELL:(890) 123-4567
|
|
CATEGORIES:Band,myContacts
|
|
END:VCARD
|
|
"#,
|
|
)]);
|
|
|
|
let cwd = dirs.test();
|
|
let actual = nu_with_plugins!(
|
|
cwd: cwd,
|
|
plugin: ("nu_plugin_formats"),
|
|
"open contacts.vcf | length"
|
|
);
|
|
|
|
assert_eq!(actual.out, "2");
|
|
})
|
|
}
|
|
|
|
#[test]
|
|
fn from_vcf_text_to_table() {
|
|
Playground::setup("filter_from_vcf_test_2", |dirs, sandbox| {
|
|
sandbox.with_files(vec![FileWithContentToBeTrimmed(
|
|
"contacts.txt",
|
|
r#"
|
|
BEGIN:VCARD
|
|
VERSION:3.0
|
|
FN:John Doe
|
|
N:Doe;John;;;
|
|
EMAIL;TYPE=INTERNET:john.doe99@gmail.com
|
|
item1.ORG:'Alpine Ski Resort'
|
|
item1.X-ABLabel:Other
|
|
item2.TITLE:'Ski Instructor'
|
|
item2.X-ABLabel:Other
|
|
BDAY:19001106
|
|
NOTE:Facebook: john.doe.3\nWebsite: \nHometown: Cleveland\, Ohio
|
|
CATEGORIES:myContacts
|
|
END:VCARD
|
|
"#,
|
|
)]);
|
|
|
|
let cwd = dirs.test();
|
|
let actual = nu_with_plugins!(
|
|
cwd: cwd,
|
|
plugin: ("nu_plugin_formats"),
|
|
r#"
|
|
open contacts.txt
|
|
| from vcf
|
|
| get properties.0
|
|
| where name == "EMAIL"
|
|
| first
|
|
| get value
|
|
"#
|
|
);
|
|
|
|
assert_eq!(actual.out, "john.doe99@gmail.com");
|
|
})
|
|
}
|