forked from extern/nushell
75180d07de
<!-- if this PR closes one or more issues, you can automatically link the PR with them by using one of the [*linking keywords*](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword), e.g. - this PR should close #xxxx - fixes #xxxx you can also mention related issues, PRs or discussions! --> # Description <!-- Thank you for improving Nushell. Please, check our [contributing guide](../CONTRIBUTING.md) and talk to the core team before making major changes. Description of your pull request goes here. **Provide examples and/or screenshots** if your changes affect the user experience. --> This PR is related to **Tests: clean up unnecessary use of cwd, pipeline(), etc. [#8670](https://github.com/nushell/nushell/issues/8670)** - Removed the `r#"..."#` raw string literal syntax, which is unnecessary when there are no special characters that need quoting from the tests that use the `nu!` macro. - `cwd:` and `pipeline()` has not changed # User-Facing Changes <!-- List of all changes that impact the user experience here. This helps us keep track of breaking changes. --> # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect -A clippy::result_large_err` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass - `cargo run -- -c "use std testing; testing run-tests --path crates/nu-std"` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. -->
131 lines
3.0 KiB
Rust
131 lines
3.0 KiB
Rust
use nu_test_support::{nu, pipeline};
|
|
|
|
#[test]
|
|
fn by_column() {
|
|
let actual = nu!(
|
|
cwd: "tests/fixtures/formats", pipeline(
|
|
r#"
|
|
open cargo_sample.toml --raw
|
|
| lines
|
|
| skip 1
|
|
| first 4
|
|
| split column "="
|
|
| sort-by column1
|
|
| skip 1
|
|
| first
|
|
| get column1
|
|
| str trim
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "description");
|
|
}
|
|
|
|
#[test]
|
|
fn by_invalid_column() {
|
|
let actual = nu!(
|
|
cwd: "tests/fixtures/formats", pipeline(
|
|
r#"
|
|
open cargo_sample.toml --raw
|
|
| lines
|
|
| skip 1
|
|
| first 4
|
|
| split column "="
|
|
| sort-by ColumnThatDoesNotExist
|
|
| skip 1
|
|
| first
|
|
| get column1
|
|
| str trim
|
|
"#
|
|
));
|
|
|
|
assert!(actual.err.contains("Cannot find column"));
|
|
assert!(actual.err.contains("value originates here"));
|
|
}
|
|
|
|
#[test]
|
|
fn sort_by_empty() {
|
|
let actual = nu!("[] | sort-by foo | to nuon");
|
|
|
|
assert_eq!(actual.out, "[]");
|
|
}
|
|
|
|
#[test]
|
|
fn ls_sort_by_name_sensitive() {
|
|
let actual = nu!(
|
|
cwd: "tests/fixtures/formats", pipeline(
|
|
"
|
|
open sample-ls-output.json
|
|
| sort-by name
|
|
| select name
|
|
| to json --raw
|
|
"
|
|
));
|
|
|
|
let json_output = r#"[{"name": "B.txt"},{"name": "C"},{"name": "a.txt"}]"#;
|
|
|
|
assert_eq!(actual.out, json_output);
|
|
}
|
|
|
|
#[test]
|
|
fn ls_sort_by_name_insensitive() {
|
|
let actual = nu!(
|
|
cwd: "tests/fixtures/formats", pipeline(
|
|
"
|
|
open sample-ls-output.json
|
|
| sort-by -i name
|
|
| select name
|
|
| to json --raw
|
|
"
|
|
));
|
|
|
|
let json_output = r#"[{"name": "a.txt"},{"name": "B.txt"},{"name": "C"}]"#;
|
|
assert_eq!(actual.out, json_output);
|
|
}
|
|
|
|
#[test]
|
|
fn ls_sort_by_type_name_sensitive() {
|
|
let actual = nu!(
|
|
cwd: "tests/fixtures/formats", pipeline(
|
|
"
|
|
open sample-ls-output.json
|
|
| sort-by type name
|
|
| select name type
|
|
| to json --raw
|
|
"
|
|
));
|
|
|
|
let json_output = r#"[{"name": "C","type": "Dir"},{"name": "B.txt","type": "File"},{"name": "a.txt","type": "File"}]"#;
|
|
assert_eq!(actual.out, json_output);
|
|
}
|
|
|
|
#[test]
|
|
fn ls_sort_by_type_name_insensitive() {
|
|
let actual = nu!(
|
|
cwd: "tests/fixtures/formats", pipeline(
|
|
"
|
|
open sample-ls-output.json
|
|
| sort-by -i type name
|
|
| select name type
|
|
| to json --raw
|
|
"
|
|
));
|
|
|
|
let json_output = r#"[{"name": "C","type": "Dir"},{"name": "a.txt","type": "File"},{"name": "B.txt","type": "File"}]"#;
|
|
assert_eq!(actual.out, json_output);
|
|
}
|
|
|
|
#[test]
|
|
fn no_column_specified_fails() {
|
|
let actual = nu!("[2 0 1] | sort-by");
|
|
|
|
assert!(actual.err.contains("missing parameter"));
|
|
}
|
|
|
|
#[test]
|
|
fn fail_on_non_iterator() {
|
|
let actual = nu!("1 | sort-by");
|
|
|
|
assert!(actual.err.contains("command doesn't support"));
|
|
}
|