forked from extern/nushell
# Description * I was dismayed to discover recently that UnsupportedInput and TypeMismatch are used *extremely* inconsistently across the codebase. UnsupportedInput is sometimes used for input type-checks (as per the name!!), but *also* used for argument type-checks. TypeMismatch is also used for both. I thus devised the following standard: input type-checking *only* uses UnsupportedInput, and argument type-checking *only* uses TypeMismatch. Moreover, to differentiate them, UnsupportedInput now has *two* error arrows (spans), one pointing at the command and the other at the input origin, while TypeMismatch only has the one (because the command should always be nearby) * In order to apply that standard, a very large number of UnsupportedInput uses were changed so that the input's span could be retrieved and delivered to it. * Additionally, I noticed many places where **errors are not propagated correctly**: there are lots of `match` sites which take a Value::Error, then throw it away and replace it with a new Value::Error with less/misleading information (such as reporting the error as an "incorrect type"). I believe that the earliest errors are the most important, and should always be propagated where possible. * Also, to standardise one broad subset of UnsupportedInput error messages, who all used slightly different wordings of "expected `<type>`, got `<type>`", I created OnlySupportsThisInputType as a variant of it. * Finally, a bunch of error sites that had "repeated spans" - i.e. where an error expected two spans, but `call.head` was given for both - were fixed to use different spans. # Example BEFORE ``` 〉20b | str starts-with 'a' Error: nu:🐚:unsupported_input (link) × Unsupported input ╭─[entry #31:1:1] 1 │ 20b | str starts-with 'a' · ┬ · ╰── Input's type is filesize. This command only works with strings. ╰──── 〉'a' | math cos Error: nu:🐚:unsupported_input (link) × Unsupported input ╭─[entry #33:1:1] 1 │ 'a' | math cos · ─┬─ · ╰── Only numerical values are supported, input type: String ╰──── 〉0x[12] | encode utf8 Error: nu:🐚:unsupported_input (link) × Unsupported input ╭─[entry #38:1:1] 1 │ 0x[12] | encode utf8 · ───┬── · ╰── non-string input ╰──── ``` AFTER ``` 〉20b | str starts-with 'a' Error: nu:🐚:pipeline_mismatch (link) × Pipeline mismatch. ╭─[entry #1:1:1] 1 │ 20b | str starts-with 'a' · ┬ ───────┬─────── · │ ╰── only string input data is supported · ╰── input type: filesize ╰──── 〉'a' | math cos Error: nu:🐚:pipeline_mismatch (link) × Pipeline mismatch. ╭─[entry #2:1:1] 1 │ 'a' | math cos · ─┬─ ────┬─── · │ ╰── only numeric input data is supported · ╰── input type: string ╰──── 〉0x[12] | encode utf8 Error: nu:🐚:pipeline_mismatch (link) × Pipeline mismatch. ╭─[entry #3:1:1] 1 │ 0x[12] | encode utf8 · ───┬── ───┬── · │ ╰── only string input data is supported · ╰── input type: binary ╰──── ``` # User-Facing Changes Various error messages suddenly make more sense (i.e. have two arrows instead of one). # Tests + Formatting Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass # After Submitting If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date.
234 lines
8.8 KiB
Rust
234 lines
8.8 KiB
Rust
use std::fs::OpenOptions;
|
|
use std::path::Path;
|
|
|
|
use chrono::{DateTime, Local};
|
|
use filetime::FileTime;
|
|
|
|
use nu_engine::CallExt;
|
|
use nu_protocol::ast::Call;
|
|
use nu_protocol::engine::{Command, EngineState, Stack};
|
|
use nu_protocol::{
|
|
Category, Example, PipelineData, ShellError, Signature, Spanned, SyntaxShape, Type,
|
|
};
|
|
|
|
#[derive(Clone)]
|
|
pub struct Touch;
|
|
|
|
impl Command for Touch {
|
|
fn name(&self) -> &str {
|
|
"touch"
|
|
}
|
|
|
|
fn search_terms(&self) -> Vec<&str> {
|
|
vec!["create", "file"]
|
|
}
|
|
|
|
fn signature(&self) -> Signature {
|
|
Signature::build("touch")
|
|
.input_output_types(vec![ (Type::Nothing, Type::Nothing) ])
|
|
.required(
|
|
"filename",
|
|
SyntaxShape::Filepath,
|
|
"the path of the file you want to create",
|
|
)
|
|
.named(
|
|
"reference",
|
|
SyntaxShape::String,
|
|
"change the file or directory time to the time of the reference file/directory",
|
|
Some('r'),
|
|
)
|
|
.switch(
|
|
"modified",
|
|
"change the modification time of the file or directory. If no timestamp, date or reference file/directory is given, the current time is used",
|
|
Some('m'),
|
|
)
|
|
.switch(
|
|
"access",
|
|
"change the access time of the file or directory. If no timestamp, date or reference file/directory is given, the current time is used",
|
|
Some('a'),
|
|
)
|
|
.switch(
|
|
"no-create",
|
|
"do not create the file if it does not exist",
|
|
Some('c'),
|
|
)
|
|
.rest("rest", SyntaxShape::Filepath, "additional files to create")
|
|
.category(Category::FileSystem)
|
|
}
|
|
|
|
fn usage(&self) -> &str {
|
|
"Creates one or more files."
|
|
}
|
|
|
|
fn run(
|
|
&self,
|
|
engine_state: &EngineState,
|
|
stack: &mut Stack,
|
|
call: &Call,
|
|
_input: PipelineData,
|
|
) -> Result<PipelineData, ShellError> {
|
|
let mut change_mtime: bool = call.has_flag("modified");
|
|
let mut change_atime: bool = call.has_flag("access");
|
|
let use_reference: bool = call.has_flag("reference");
|
|
let no_create: bool = call.has_flag("no-create");
|
|
let target: String = call.req(engine_state, stack, 0)?;
|
|
let rest: Vec<String> = call.rest(engine_state, stack, 1)?;
|
|
|
|
let mut date: Option<DateTime<Local>> = None;
|
|
let mut ref_date_atime: Option<DateTime<Local>> = None;
|
|
|
|
// Change both times if none is specified
|
|
if !change_mtime && !change_atime {
|
|
change_mtime = true;
|
|
change_atime = true;
|
|
}
|
|
|
|
if change_mtime || change_atime {
|
|
date = Some(Local::now());
|
|
}
|
|
|
|
if use_reference {
|
|
let reference: Option<Spanned<String>> =
|
|
call.get_flag(engine_state, stack, "reference")?;
|
|
match reference {
|
|
Some(reference) => {
|
|
let reference_path = Path::new(&reference.item);
|
|
if !reference_path.exists() {
|
|
return Err(ShellError::TypeMismatch(
|
|
"path provided is invalid".to_string(),
|
|
reference.span,
|
|
));
|
|
}
|
|
|
|
date = Some(
|
|
reference_path
|
|
.metadata()
|
|
.expect("should be a valid path") // Should never fail as the path exists
|
|
.modified()
|
|
.expect("should have metadata") // This should always be valid as it is available on all nushell's supported platforms (Linux, Windows, MacOS)
|
|
.into(),
|
|
);
|
|
|
|
ref_date_atime = Some(
|
|
reference_path
|
|
.metadata()
|
|
.expect("should be a valid path") // Should never fail as the path exists
|
|
.accessed()
|
|
.expect("should have metadata") // This should always be valid as it is available on all nushell's supported platforms (Linux, Windows, MacOS)
|
|
.into(),
|
|
);
|
|
}
|
|
None => {
|
|
return Err(ShellError::MissingParameter(
|
|
"reference".to_string(),
|
|
call.head,
|
|
));
|
|
}
|
|
}
|
|
}
|
|
|
|
for (index, item) in vec![target].into_iter().chain(rest).enumerate() {
|
|
if no_create {
|
|
let path = Path::new(&item);
|
|
if !path.exists() {
|
|
continue;
|
|
}
|
|
}
|
|
|
|
if let Err(err) = OpenOptions::new().write(true).create(true).open(&item) {
|
|
return Err(ShellError::CreateNotPossible(
|
|
format!("Failed to create file: {}", err),
|
|
call.positional_nth(index)
|
|
.expect("already checked positional")
|
|
.span,
|
|
));
|
|
};
|
|
|
|
if change_mtime {
|
|
// Should not panic as we return an error above if we can't parse the date
|
|
if let Err(err) = filetime::set_file_mtime(
|
|
&item,
|
|
FileTime::from_system_time(date.expect("should be a valid date").into()),
|
|
) {
|
|
return Err(ShellError::ChangeModifiedTimeNotPossible(
|
|
format!("Failed to change the modified time: {}", err),
|
|
call.positional_nth(index)
|
|
.expect("already checked positional")
|
|
.span,
|
|
));
|
|
};
|
|
}
|
|
|
|
if change_atime {
|
|
// Reference file/directory may have different access and modified times
|
|
if use_reference {
|
|
// Should not panic as we return an error above if we can't parse the date
|
|
if let Err(err) = filetime::set_file_atime(
|
|
&item,
|
|
FileTime::from_system_time(
|
|
ref_date_atime.expect("should be a valid date").into(),
|
|
),
|
|
) {
|
|
return Err(ShellError::ChangeAccessTimeNotPossible(
|
|
format!("Failed to change the access time: {}", err),
|
|
call.positional_nth(index)
|
|
.expect("already checked positional")
|
|
.span,
|
|
));
|
|
};
|
|
} else {
|
|
// Should not panic as we return an error above if we can't parse the date
|
|
if let Err(err) = filetime::set_file_atime(
|
|
&item,
|
|
FileTime::from_system_time(date.expect("should be a valid date").into()),
|
|
) {
|
|
return Err(ShellError::ChangeAccessTimeNotPossible(
|
|
format!("Failed to change the access time: {}", err),
|
|
call.positional_nth(index)
|
|
.expect("already checked positional")
|
|
.span,
|
|
));
|
|
};
|
|
}
|
|
}
|
|
}
|
|
|
|
Ok(PipelineData::empty())
|
|
}
|
|
|
|
fn examples(&self) -> Vec<Example> {
|
|
vec![
|
|
Example {
|
|
description: "Creates \"fixture.json\"",
|
|
example: "touch fixture.json",
|
|
result: None,
|
|
},
|
|
Example {
|
|
description: "Creates files a, b and c",
|
|
example: "touch a b c",
|
|
result: None,
|
|
},
|
|
Example {
|
|
description: r#"Changes the last modified time of "fixture.json" to today's date"#,
|
|
example: "touch -m fixture.json",
|
|
result: None,
|
|
},
|
|
Example {
|
|
description: "Changes the last modified time of files a, b and c to a date",
|
|
example: r#"touch -m -d "yesterday" a b c"#,
|
|
result: None,
|
|
},
|
|
Example {
|
|
description: r#"Changes the last modified time of file d and e to "fixture.json"'s last modified time"#,
|
|
example: r#"touch -m -r fixture.json d e"#,
|
|
result: None,
|
|
},
|
|
Example {
|
|
description: r#"Changes the last accessed time of "fixture.json" to a date"#,
|
|
example: r#"touch -a -d "August 24, 2019; 12:30:30" fixture.json"#,
|
|
result: None,
|
|
},
|
|
]
|
|
}
|
|
}
|