forked from extern/nushell
7926e4ab6d
# Description Prevent `rustflags` build configuration from being ignored in github actions ci workflows. [actions-rust-lang/setup-rust-toolchain](https://github.com/actions-rust-lang/setup-rust-toolchain/) used in ci workflows sets `RUSTFLAGS="-D warnings"` env variable by default. It has priority over some other sources of `rustflags` as described in [the cargo reference](https://doc.rust-lang.org/cargo/reference/config.html#buildrustflags). Nushell is using `target.x86_64-pc-windows-msvc.rustflags` to statically link MSVC runtime in windows platform, but this config is being ignored in ci workflows. By unsetting `RUSTFLAGS` env variable, `rustflags` build configurations will be properly used in ci workflows. I assume that this was the cause of the installer verification failures on the recent winget submission PRs. For more details, refer discussions in https://github.com/microsoft/winget-pkgs/pull/106977 and https://github.com/nushell/nushell/pull/9322#issuecomment-1602932971. # User-Facing Changes Pre-built releases for windows that are created by the release ci workflow will now contain statically linked MSVC runtime. # Tests + Formatting Confirmed successful installation in a windows sandbox instance, which was failing before. It also contains changes made in #9514. Release ci workflow: https://github.com/wolimst/nushell/actions/runs/5357440849 Installer: https://github.com/wolimst/nushell/releases/tag/0.81.0-test # After Submitting Need to check the installer verification result in a winget submission PR for the next release, if this PR gets merged.
231 lines
7.5 KiB
YAML
231 lines
7.5 KiB
YAML
#
|
|
# REF:
|
|
# 1. https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstrategymatrixinclude
|
|
# 2. https://github.com/JasonEtco/create-an-issue
|
|
# 3. https://docs.github.com/en/actions/learn-github-actions/variables
|
|
# 4. https://github.com/actions/github-script
|
|
#
|
|
name: Nightly Build
|
|
|
|
on:
|
|
push:
|
|
branches:
|
|
- nightly # Just for test purpose only with the nightly repo
|
|
# This schedule will run only from the default branch
|
|
schedule:
|
|
- cron: '15 1 * * *' # run at 01:15 AM UTC
|
|
|
|
defaults:
|
|
run:
|
|
shell: bash
|
|
|
|
jobs:
|
|
prepare:
|
|
name: Prepare
|
|
runs-on: ubuntu-latest
|
|
# This job is required by the release job, so we should make it run both from Nushell repo and nightly repo
|
|
# if: github.repository == 'nushell/nightly'
|
|
steps:
|
|
- name: Checkout
|
|
uses: actions/checkout@v3
|
|
if: github.repository == 'nushell/nightly'
|
|
with:
|
|
ref: main
|
|
fetch-depth: 0
|
|
# Configure PAT here: https://github.com/settings/tokens for the push operation in the following steps
|
|
token: ${{ secrets.WORKFLOW_TOKEN }}
|
|
|
|
- name: Setup Nushell
|
|
uses: hustcer/setup-nu@v3
|
|
if: github.repository == 'nushell/nightly'
|
|
with:
|
|
version: 0.81.0
|
|
env:
|
|
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
|
|
|
|
# Synchronize the main branch of nightly repo with the main branch of Nushell official repo
|
|
- name: Prepare for Nightly Release
|
|
shell: nu {0}
|
|
if: github.repository == 'nushell/nightly'
|
|
run: |
|
|
cd $env.GITHUB_WORKSPACE
|
|
git checkout main
|
|
# We can't push if no user name and email are configured
|
|
git config user.name 'hustcer'
|
|
git config user.email 'hustcer@outlook.com'
|
|
git fetch origin main
|
|
git remote add src https://github.com/nushell/nushell.git
|
|
git fetch src main
|
|
# git pull --rebase src main
|
|
# All the changes will be overwritten by the upstream main branch
|
|
git reset --hard src/main
|
|
git push origin main -f
|
|
let sha_short = (git rev-parse --short src/main | str trim | str substring 0..7)
|
|
let tag_name = $'nightly-($sha_short)'
|
|
if (git ls-remote --tags origin $tag_name | is-empty) {
|
|
git tag -a $tag_name -m $'Nightly build from ($sha_short)'
|
|
git push origin --tags
|
|
}
|
|
|
|
release:
|
|
name: Release
|
|
needs: prepare
|
|
strategy:
|
|
fail-fast: false
|
|
matrix:
|
|
target:
|
|
- aarch64-apple-darwin
|
|
- x86_64-apple-darwin
|
|
- x86_64-pc-windows-msvc
|
|
- aarch64-pc-windows-msvc
|
|
- x86_64-unknown-linux-gnu
|
|
- x86_64-unknown-linux-musl
|
|
- aarch64-unknown-linux-gnu
|
|
- armv7-unknown-linux-gnueabihf
|
|
- riscv64gc-unknown-linux-gnu
|
|
extra: ['bin']
|
|
include:
|
|
- target: aarch64-apple-darwin
|
|
os: macos-latest
|
|
target_rustflags: ''
|
|
- target: x86_64-apple-darwin
|
|
os: macos-latest
|
|
target_rustflags: ''
|
|
- target: x86_64-pc-windows-msvc
|
|
extra: 'bin'
|
|
os: windows-latest
|
|
target_rustflags: ''
|
|
- target: x86_64-pc-windows-msvc
|
|
extra: msi
|
|
os: windows-latest
|
|
target_rustflags: ''
|
|
- target: aarch64-pc-windows-msvc
|
|
extra: 'bin'
|
|
os: windows-latest
|
|
target_rustflags: ''
|
|
- target: aarch64-pc-windows-msvc
|
|
extra: msi
|
|
os: windows-latest
|
|
target_rustflags: ''
|
|
- target: x86_64-unknown-linux-gnu
|
|
os: ubuntu-20.04
|
|
target_rustflags: ''
|
|
- target: x86_64-unknown-linux-musl
|
|
os: ubuntu-20.04
|
|
target_rustflags: ''
|
|
- target: aarch64-unknown-linux-gnu
|
|
os: ubuntu-20.04
|
|
target_rustflags: ''
|
|
- target: armv7-unknown-linux-gnueabihf
|
|
os: ubuntu-20.04
|
|
target_rustflags: ''
|
|
- target: riscv64gc-unknown-linux-gnu
|
|
os: ubuntu-20.04
|
|
target_rustflags: ''
|
|
|
|
runs-on: ${{matrix.os}}
|
|
|
|
steps:
|
|
- uses: actions/checkout@v3
|
|
with:
|
|
ref: main
|
|
|
|
- name: Update Rust Toolchain Target
|
|
run: |
|
|
echo "targets = ['${{matrix.target}}']" >> rust-toolchain.toml
|
|
|
|
- name: Setup Rust toolchain and cache
|
|
uses: actions-rust-lang/setup-rust-toolchain@v1.5.0
|
|
with:
|
|
rustflags: ''
|
|
|
|
- name: Setup Nushell
|
|
uses: hustcer/setup-nu@v3
|
|
with:
|
|
version: 0.81.0
|
|
env:
|
|
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
|
|
|
|
- name: Release Nu Binary
|
|
id: nu
|
|
run: nu .github/workflows/release-pkg.nu
|
|
env:
|
|
OS: ${{ matrix.os }}
|
|
REF: ${{ github.ref }}
|
|
TARGET: ${{ matrix.target }}
|
|
_EXTRA_: ${{ matrix.extra }}
|
|
TARGET_RUSTFLAGS: ${{ matrix.target_rustflags }}
|
|
|
|
- name: Create an Issue for Release Failure
|
|
if: ${{ failure() }}
|
|
uses: JasonEtco/create-an-issue@v2.9.1
|
|
env:
|
|
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
|
|
with:
|
|
update_existing: true
|
|
search_existing: open
|
|
filename: .github/AUTO_ISSUE_TEMPLATE/nightly-build-fail.md
|
|
|
|
- name: Set Outputs of Short SHA
|
|
id: vars
|
|
run: |
|
|
echo "date=$(date -u +'%Y-%m-%d')" >> $GITHUB_OUTPUT
|
|
sha_short=$(git rev-parse --short HEAD)
|
|
echo "sha_short=${sha_short:0:7}" >> $GITHUB_OUTPUT
|
|
|
|
# REF: https://github.com/marketplace/actions/gh-release
|
|
# Create a release only in nushell/nightly repo
|
|
- name: Publish Archive
|
|
uses: softprops/action-gh-release@v0.1.13
|
|
if: ${{ startsWith(github.repository, 'nushell/nightly') }}
|
|
with:
|
|
draft: false
|
|
prerelease: true
|
|
name: Nu-nightly-${{ steps.vars.outputs.date }}-${{ steps.vars.outputs.sha_short }}
|
|
tag_name: nightly-${{ steps.vars.outputs.sha_short }}
|
|
body: |
|
|
This is a NIGHTLY build of Nushell.
|
|
It is NOT recommended for production use.
|
|
files: ${{ steps.nu.outputs.archive }}
|
|
env:
|
|
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
|
|
|
|
cleanup:
|
|
name: Cleanup
|
|
# Should only run in nushell/nightly repo
|
|
if: github.repository == 'nushell/nightly'
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
# Sleep for 30 minutes, waiting for the release to be published
|
|
- name: Waiting for Release
|
|
run: sleep 1800
|
|
|
|
- uses: actions/checkout@v3
|
|
with:
|
|
ref: main
|
|
|
|
- name: Setup Nushell
|
|
uses: hustcer/setup-nu@v3
|
|
with:
|
|
version: 0.81.0
|
|
env:
|
|
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
|
|
|
|
# Keep the last a few releases
|
|
- name: Delete Older Releases
|
|
shell: nu {0}
|
|
run: |
|
|
let KEEP_COUNT = 10
|
|
let deprecated = (http get https://api.github.com/repos/nushell/nightly/releases | sort-by -r created_at | select tag_name id | range $KEEP_COUNT..)
|
|
for release in $deprecated {
|
|
print $'Deleting tag ($release.tag_name)'
|
|
git push origin --delete $release.tag_name
|
|
print $'Deleting release ($release.tag_name)'
|
|
let delete_url = $'https://api.github.com/repos/nushell/nightly/releases/($release.id)'
|
|
let version = "X-GitHub-Api-Version: 2022-11-28"
|
|
let accept = "Accept: application/vnd.github+json"
|
|
let auth = "Authorization: Bearer ${{ secrets.GITHUB_TOKEN }}"
|
|
# http delete $delete_url -H $version -H $auth -H $accept
|
|
curl -L -X DELETE -H $accept -H $auth -H $version $delete_url
|
|
}
|