nushell/crates
Erich Gubler 83b1ec83c9
feat(rm)!: use arg. spans for I/O errors (#8964)
# Description

Currently, error spans for I/O errors in an `rm` invocation always point
to the `rm` argument. This isn't ideal, because the user loses context
as to which “target” actually had a problem:


![image](https://user-images.githubusercontent.com/658538/235723366-50db727e-9ba2-4d16-afc6-6a2406c584e0.png)

Shadow the existing `span` variable in outer scope in `rm`'s
implementation for the errors that may be detected while handling I/O
results. This is desired, because all failures from this point are
target-specific, and pointing at the argument that generated the target
instead is better. The end user should now see this:


![image](https://user-images.githubusercontent.com/658538/235724345-1d2e98e0-6b20-4bf5-b8a2-8b4368cdfb05.png)

# User-Facing Changes
* When `rm` encounters I/O errors, their spans now point to the “target”
argument associated with the error, rather than the `rm` token.

# Tests + Formatting


No tests currently cover this. I'm open to adding tests, but adding as
follow-up sounds better ATM, since this wasn't covered before.

# After Submitting

Nothing needs to be done here, AFAIK. No I/O errors are currently
demonstrated in official docs, though maybe they should be?
2023-05-03 23:12:16 +02:00
..
nu_plugin_custom_values Bump to 0.79.1 dev version (#8998) 2023-04-26 01:05:23 +02:00
nu_plugin_example Bump to 0.79.1 dev version (#8998) 2023-04-26 01:05:23 +02:00
nu_plugin_formats Bump to 0.79.1 dev version (#8998) 2023-04-26 01:05:23 +02:00
nu_plugin_gstat Bump to 0.79.1 dev version (#8998) 2023-04-26 01:05:23 +02:00
nu_plugin_inc Bump to 0.79.1 dev version (#8998) 2023-04-26 01:05:23 +02:00
nu_plugin_python update nu_plugin_python due to signature changes (#8107) 2023-02-18 13:27:24 +00:00
nu_plugin_query Bump to 0.79.1 dev version (#8998) 2023-04-26 01:05:23 +02:00
nu-cli support bracketed paste (#8907) 2023-05-03 23:08:47 +02:00
nu-cmd-lang Add extern def which allows raw arguments (#8956) 2023-04-28 09:06:43 +02:00
nu-color-config Bump tabled dependency to 0.11 (#8922) 2023-04-26 13:56:10 -05:00
nu-command feat(rm)!: use arg. spans for I/O errors (#8964) 2023-05-03 23:12:16 +02:00
nu-engine Change type of flag defaults to Option<Value> (#9085) 2023-05-03 23:09:36 +02:00
nu-explore Bump tabled dependency to 0.11 (#8922) 2023-04-26 13:56:10 -05:00
nu-glob Bump to 0.79.1 dev version (#8998) 2023-04-26 01:05:23 +02:00
nu-json Bump to 0.79.1 dev version (#8998) 2023-04-26 01:05:23 +02:00
nu-parser Change type of flag defaults to Option<Value> (#9085) 2023-05-03 23:09:36 +02:00
nu-path Bump to 0.79.1 dev version (#8998) 2023-04-26 01:05:23 +02:00
nu-plugin Bump to 0.79.1 dev version (#8998) 2023-04-26 01:05:23 +02:00
nu-pretty-hex Bump to 0.79.1 dev version (#8998) 2023-04-26 01:05:23 +02:00
nu-protocol Change type of flag defaults to Option<Value> (#9085) 2023-05-03 23:09:36 +02:00
nu-std pass std bench into table -e in the example (#9075) 2023-05-01 08:18:51 -05:00
nu-system Bump to 0.79.1 dev version (#8998) 2023-04-26 01:05:23 +02:00
nu-table Fix #9038 (#9042) 2023-04-28 12:50:42 -05:00
nu-term-grid Bump to 0.79.1 dev version (#8998) 2023-04-26 01:05:23 +02:00
nu-test-support Bump to 0.79.1 dev version (#8998) 2023-04-26 01:05:23 +02:00
nu-utils support bracketed paste (#8907) 2023-05-03 23:08:47 +02:00
README.md Remove old nushell/merge engine-q 2022-02-07 14:54:06 -05:00

Nushell core libraries and plugins

These sub-crates form both the foundation for Nu and a set of plugins which extend Nu with additional functionality.

Foundational libraries are split into two kinds of crates:

  • Core crates - those crates that work together to build the Nushell language engine
  • Support crates - a set of crates that support the engine with additional features like JSON support, ANSI support, and more.

Plugins are likewise also split into two types:

  • Core plugins - plugins that provide part of the default experience of Nu, including access to the system properties, processes, and web-connectivity features.
  • Extra plugins - these plugins run a wide range of different capabilities like working with different file types, charting, viewing binary data, and more.