nushell/crates/nu-command/src/env
Daniel Buch Hansen 850ecf648a
Protocol: debug_assert!() Span to reflect a valid slice (#6806)
Also enforce this by #[non_exhaustive] span such that going forward we
cannot, in debug builds (1), construct invalid spans.

The motivation for this stems from #6431 where I've seen crashes due to
invalid slice indexing.

My hope is this will mitigate such senarios

1. https://github.com/nushell/nushell/pull/6431#issuecomment-1278147241

# Description

(description of your pull request here)

# Tests

Make sure you've done the following:

- [ ] Add tests that cover your changes, either in the command examples,
the crate/tests folder, or in the /tests folder.
- [ ] Try to think about corner cases and various ways how your changes
could break. Cover them with tests.
- [ ] If adding tests is not possible, please document in the PR body a
minimal example with steps on how to reproduce so one can verify your
change works.

Make sure you've run and fixed any issues with these commands:

- [x] `cargo fmt --all -- --check` to check standard code formatting
(`cargo fmt --all` applies these changes)
- [ ] `cargo clippy --workspace --features=extra -- -D warnings -D
clippy::unwrap_used -A clippy::needless_collect` to check that you're
using the standard code style
- [ ] `cargo test --workspace --features=extra` to check that all the
tests pass

# Documentation

- [ ] If your PR touches a user-facing nushell feature then make sure
that there is an entry in the documentation
(https://github.com/nushell/nushell.github.io) for the feature, and
update it if necessary.
2022-12-03 11:44:12 +02:00
..
config Protocol: debug_assert!() Span to reflect a valid slice (#6806) 2022-12-03 11:44:12 +02:00
env_command.rs Rename all?, any? and empty? (#6464) 2022-09-05 16:41:06 +02:00
export_env.rs Split blocks and closures (#7075) 2022-11-10 21:21:49 +13:00
let_env.rs fix(#7097): let-env should not be able to set PWD (#7100) 2022-11-12 05:45:51 +13:00
load_env.rs Move from source to source-env (#6277) 2022-09-01 08:32:56 +12:00
mod.rs Move from source to source-env (#6277) 2022-09-01 08:32:56 +12:00
source_env.rs Require static path for source-env (#6526) 2022-09-08 23:41:49 +03:00
with_env.rs Split blocks and closures (#7075) 2022-11-10 21:21:49 +13:00