forked from extern/nushell
332f1192a6
the first part of this PR comes from a request from @presidento in #8525. the second one is an improvement of the error support. # Description this PR - computes `module_search_pattern` to only `ls` the selected modules => the goal is to save search time in the future with more tests - gives better errors when - the `--path` is invalid - the `--module` does not exist - the search is too strict ### examples ```bash >_ nu crates/nu-utils/standard_library/tests.nu --path does-not-exist Error: × directory_not_found ╭─[<commandline>:1:1] 1 │ main --path does-not-exist · ───────┬────── · ╰── no such directory ╰──── ``` ```bash >_ nu crates/nu-utils/standard_library/tests.nu --module does-not-exist Error: × module_not_found ╭─[<commandline>:1:1] 1 │ main --module does-not-exist · ───────┬────── · ╰── no such module in /home/amtoine/.local/share/git/store/github.com/amtoine/nushell/crates/nu-utils/standard_library/ ╰──── ``` ```bash >_ nu crates/nu-utils/standard_library/tests.nu --command does_not_exist Error: × no test to run ``` instead of the previous ```bash >_ nu crates/nu-utils/standard_library/tests.nu --path does-not-exist Error: × No matches found for /home/amtoine/.local/share/git/store/github.com/amtoine/nushell/does-not-exist/test_*.nu ╭─[/home/amtoine/.local/share/git/store/github.com/amtoine/nushell/crates/nu-utils/standard_library/tests.nu:32:1] 32 │ let tests = ( 33 │ ls ($path | default $env.FILE_PWD | path join "test_*.nu") · ───────────────────────────┬─────────────────────────── · ╰── Pattern, file or folder not found 34 │ | each {|row| {file: $row.name name: ($row.name | path parse | get stem)}} ╰──── help: no matches found ``` ```bash >_ nu crates/nu-utils/standard_library/tests.nu --module does-not-exist Error: × expected table from pipeline ╭─[/home/amtoine/.local/share/git/store/github.com/amtoine/nushell/crates/nu-utils/standard_library/tests.nu:59:1] 59 │ $tests_to_run 60 │ | group-by module · ────┬─── · ╰── requires a table input 61 │ | transpose name tests ╰──── ``` ```bash >_ nu crates/nu-utils/standard_library/tests.nu --command does-not-exist Error: × expected table from pipeline ╭─[/home/amtoine/.local/share/git/store/github.com/amtoine/nushell/crates/nu-utils/standard_library/tests.nu:59:1] 59 │ $tests_to_run 60 │ | group-by module · ────┬─── · ╰── requires a table input 61 │ | transpose name tests ╰──── ``` # User-Facing Changes ``` $nothing ``` # Tests + Formatting ``` $nothing ``` # After Submitting ``` $nothing ```
130 lines
3.7 KiB
Plaintext
130 lines
3.7 KiB
Plaintext
use std.nu *
|
|
|
|
# show a test record in a pretty way
|
|
#
|
|
# `$in` must be a `record<file: string, module: string, name: string, pass: bool>`.
|
|
#
|
|
# the output would be like
|
|
# - "<indentation> x <module> <test>" all in red if failed
|
|
# - "<indentation> <module> <test>" all in green if passed
|
|
def show-pretty-test [indent: int = 4] {
|
|
let test = $in
|
|
|
|
[
|
|
(" " * $indent)
|
|
(if $test.pass { ansi green } else { ansi red})
|
|
(if $test.pass { " " } else { char failed})
|
|
" "
|
|
$"($test.module) ($test.name)"
|
|
(ansi reset)
|
|
] | str join
|
|
}
|
|
|
|
def throw-error [error: record] {
|
|
error make {
|
|
msg: $"(ansi red)($error.msg)(ansi reset)"
|
|
label: {
|
|
text: ($error.label)
|
|
start: $error.span.start
|
|
end: $error.span.end
|
|
}
|
|
}
|
|
}
|
|
|
|
# Test executor
|
|
#
|
|
# It executes exported "test_*" commands in "test_*" modules
|
|
def main [
|
|
--path: path, # Path to look for tests. Default: directory of this file.
|
|
--module: string, # Module to run tests. Default: all test modules found.
|
|
--command: string, # Test command to run. Default: all test command found in the files.
|
|
--list, # list the selected tests without running them.
|
|
] {
|
|
let module_search_pattern = ({
|
|
stem: ($module | default "test_*")
|
|
extension: nu
|
|
} | path join)
|
|
|
|
if not ($path | is-empty) {
|
|
if not ($path | path exists) {
|
|
throw-error {
|
|
msg: "directory_not_found"
|
|
label: "no such directory"
|
|
span: (metadata $path | get span)
|
|
}
|
|
}
|
|
}
|
|
|
|
let path = ($path | default $env.FILE_PWD)
|
|
|
|
if not ($module | is-empty) {
|
|
if not ($path | path join $module_search_pattern | path exists) {
|
|
throw-error {
|
|
msg: "module_not_found"
|
|
label: $"no such module in ($path)"
|
|
span: (metadata $module | get span)
|
|
}
|
|
}
|
|
}
|
|
|
|
let tests = (
|
|
ls ($path | path join $module_search_pattern)
|
|
| each {|row| {file: $row.name name: ($row.name | path parse | get stem)}}
|
|
| upsert test {|module|
|
|
nu -c $'use ($module.file) *; $nu.scope.commands | select name module_name | to nuon'
|
|
| from nuon
|
|
| where module_name == $module.name
|
|
| where ($it.name | str starts-with "test_")
|
|
| get name
|
|
}
|
|
| flatten
|
|
| rename file module name
|
|
)
|
|
|
|
let tests_to_run = (if not ($command | is-empty) {
|
|
$tests | where name == $command
|
|
} else if not ($module | is-empty) {
|
|
$tests | where module == $module
|
|
} else {
|
|
$tests
|
|
})
|
|
|
|
if $list {
|
|
return ($tests_to_run | select module name file)
|
|
}
|
|
|
|
if ($tests_to_run | is-empty) {
|
|
error make --unspanned {msg: "no test to run"}
|
|
}
|
|
|
|
let tests = (
|
|
$tests_to_run
|
|
| group-by module
|
|
| transpose name tests
|
|
| each {|module|
|
|
log info $"Running tests in ($module.name)"
|
|
$module.tests | each {|test|
|
|
log debug $"Running test ($test.name)"
|
|
let did_pass = (try {
|
|
nu -c $'use ($test.file) ($test.name); ($test.name)'
|
|
true
|
|
} catch { false })
|
|
|
|
$test | merge ({pass: $did_pass})
|
|
}
|
|
}
|
|
| flatten
|
|
)
|
|
|
|
if not ($tests | where not pass | is-empty) {
|
|
let text = ([
|
|
$"(ansi purple)some tests did not pass (char lparen)see complete errors above(char rparen):(ansi reset)"
|
|
""
|
|
($tests | each {|test| ($test | show-pretty-test 4)} | str join "\n")
|
|
""
|
|
] | str join "\n")
|
|
|
|
error make --unspanned { msg: $text }
|
|
}
|
|
}
|