nushell/crates/nu-protocol/src
Leon 5b616770df
Make config.filesize_format/config.filesize_metric conflict resolution consistent (#7410)
# Description

Currently, `filesize_format`/`filesize_metric` conflicts are resolved as
follows: if the `filesize_format` ends in "ib", then that overrides
`filesize_metric`, otherwise, `filesize_metric` overrides
`filesize_format`. This removes this difficult-to-predict asymmetric
behaviour, and makes it so that `filesize_metric` always overrides
`filesize_format`.

This also adds tests for `$env.config.filesize.format` and
`$env.config.filesize.metric` values.

REMINDER: `filesize_metric` means "increments of 1000", and refers to
KB-MB-GB-TB etc.

# User-Facing Changes

See above.

# Tests + Formatting

Don't forget to add tests that cover your changes.

Make sure you've run and fixed any issues with these commands:

- `cargo fmt --all -- --check` to check standard code formatting (`cargo
fmt --all` applies these changes)
- `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A
clippy::needless_collect` to check that you're using the standard code
style
- `cargo test --workspace` to check that all tests pass

# After Submitting

If your PR had any user-facing changes, update [the
documentation](https://github.com/nushell/nushell.github.io) after the
PR is merged, if necessary. This will help us keep the docs up to date.

Co-authored-by: Darren Schroeder <343840+fdncred@users.noreply.github.com>
2022-12-22 08:46:55 -06:00
..
ast Remove shape-directed import pattern parsing (#7570) 2022-12-22 16:36:13 +02:00
engine Initial support for parse-time constants (#7436) 2022-12-22 00:21:03 +02:00
value Make config.filesize_format/config.filesize_metric conflict resolution consistent (#7410) 2022-12-22 08:46:55 -06:00
cli_error.rs Clippy fix for Rust 1.63 (#6299) 2022-08-11 11:54:54 -05:00
config.rs color_config now accepts closures as color values (#7141) 2022-12-17 07:07:56 -06:00
example.rs Start support for commandline args to nu itself (#851) 2022-01-27 01:42:39 +11:00
exportable.rs Removes export env command (#6468) 2022-09-25 19:52:43 +03:00
id.rs Overlays (#5375) 2022-05-08 07:39:22 +12:00
lev_distance.rs Improve "Did you mean?" suggestions (#6579) 2022-09-20 19:46:01 -05:00
lib.rs Improve "Did you mean?" suggestions (#6579) 2022-09-20 19:46:01 -05:00
module.rs Removes export env command (#6468) 2022-09-25 19:52:43 +03:00
pipeline_data.rs refactor: introduce is_external_failed to PipelineData, and simplify try logic (#7476) 2022-12-14 10:25:32 -08:00
shell_error.rs Add FILE_PWD environment variable when running 'nu script.nu' (#7424) 2022-12-10 19:23:44 +02:00
signature.rs Add "fall-through" signatures (#7527) 2022-12-22 00:33:26 +02:00
span.rs Protocol: debug_assert!() Span to reflect a valid slice (#6806) 2022-12-03 11:44:12 +02:00
syntax_shape.rs sort enums add missing items to parse_shape_name (#7450) 2022-12-13 10:46:22 -06:00
ty.rs sort enums add missing items to parse_shape_name (#7450) 2022-12-13 10:46:22 -06:00
variable.rs Limited mutable variables (#7089) 2022-11-11 19:51:08 +13:00