forked from extern/nushell
ad11e25fc5
# Description This extends the syntax fix for `let` (#9589) to `mut` as well. Example: `mut x = "hello world" | str length; print $x` closes #9634 # User-Facing Changes `mut` now joins `let` in being able to be assigned from a pipeline # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect -A clippy::result_large_err` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass - `cargo run -- crates/nu-std/tests/run.nu` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. -->
89 lines
1.7 KiB
Rust
89 lines
1.7 KiB
Rust
use nu_test_support::{nu, pipeline};
|
|
|
|
#[test]
|
|
fn let_name_builtin_var() {
|
|
let actual = nu!(
|
|
cwd: ".", pipeline(
|
|
r#"
|
|
let in = 3
|
|
"#
|
|
));
|
|
|
|
assert!(actual
|
|
.err
|
|
.contains("'in' is the name of a builtin Nushell variable"));
|
|
}
|
|
|
|
#[test]
|
|
fn let_doesnt_mutate() {
|
|
let actual = nu!(
|
|
cwd: ".", pipeline(
|
|
r#"
|
|
let i = 3; $i = 4
|
|
"#
|
|
));
|
|
|
|
assert!(actual.err.contains("immutable"));
|
|
}
|
|
|
|
#[test]
|
|
fn let_takes_pipeline() {
|
|
let actual = nu!(
|
|
cwd: ".", pipeline(
|
|
r#"
|
|
let x = "hello world" | str length; print $x
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "11");
|
|
}
|
|
|
|
#[test]
|
|
fn let_pipeline_allows_in() {
|
|
let actual = nu!(
|
|
cwd: ".", pipeline(
|
|
r#"
|
|
def foo [] { let x = $in | str length; print ($x + 10) }; "hello world" | foo
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "21");
|
|
}
|
|
|
|
#[test]
|
|
fn mut_takes_pipeline() {
|
|
let actual = nu!(
|
|
cwd: ".", pipeline(
|
|
r#"
|
|
mut x = "hello world" | str length; print $x
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "11");
|
|
}
|
|
|
|
#[test]
|
|
fn mut_pipeline_allows_in() {
|
|
let actual = nu!(
|
|
cwd: ".", pipeline(
|
|
r#"
|
|
def foo [] { mut x = $in | str length; print ($x + 10) }; "hello world" | foo
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "21");
|
|
}
|
|
|
|
#[ignore]
|
|
#[test]
|
|
fn let_with_external_failed() {
|
|
// FIXME: this test hasn't run successfully for a long time. We should
|
|
// bring it back to life at some point.
|
|
let actual = nu!(
|
|
cwd: ".",
|
|
pipeline(r#"let x = nu --testbin outcome_err "aa"; echo fail"#)
|
|
);
|
|
|
|
assert!(!actual.out.contains("fail"));
|
|
}
|