holm/nushell
1
1
Fork 0
forked from extern/nushell
Code Issues Pull Requests Packages Projects Releases Wiki Activity
c9aa6ba0f3
nushell/crates/nu-command/tests
History
nibon7 b227eea668
Add checks for ports (#11214) 
# Description
This PR adds checks for ports. This fixes unexpected output similar to
the one in the comment
https://github.com/nushell/nushell/pull/11210#issuecomment-1837152357.

* before

```console
/data/source/nushell> port 65536 99999                                                                                        
41233
```

* after

```console
/data/source/nushell> port 65536 99999                                                                                             
Error: nu:🐚:cant_convert

  × Can't convert to u16.
   ╭─[entry #1:1:1]
 1 │ port 65536 99999
   ·      ──┬──
   ·        ╰── can't convert usize to u16
   ╰────
  help: out of range integral type conversion attempted (min: 0, max: 65535)
```

# User-Facing Changes
N/A

# Tests + Formatting
* [x] add `port_out_of_range` test

# After Submitting
N/A
2023-12-03 08:07:15 -06:00
..
commands Add checks for ports (#11214) 2023-12-03 08:07:15 -06:00
format_conversions bump rust-toolchain to 1.72.1 (#11079) 2023-11-16 15:14:45 -06:00
main.rs Rename misused "deprecation" to removal (#10000) 2023-08-15 07:17:31 +12:00