forked from extern/nushell
208ffdc1da
# Description From nushell 0.8 philosophy: https://github.com/nushell/nushell.github.io/blob/main/contributor-book/philosophy_0_80.md#core-categories > The following categories should be moved to plugins: Uncommon format support So this pr is trying to move following commands to plugin: - [X] from eml - [x] from ics - [x] from ini - [x] from vcf And we can have a new plugin handles for these formatting, currently it's implemented here: https://github.com/WindSoilder/nu_plugin_format The command usage should be the same to original command. If it's ok, the plugin can support more formats like [parquet](https://github.com/fdncred/nu_plugin_from_parquet), or [EDN format](https://github.com/nushell/nushell/issues/6415), or something else. Just create a draft pr to show what's the blueprint looks like, and is it a good direction to move forward? # User-Facing Changes _(List of all changes that impact the user experience here. This helps us keep track of breaking changes.)_ # Tests + Formatting Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass # After Submitting If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date.
56 lines
1.5 KiB
Rust
56 lines
1.5 KiB
Rust
use nu_test_support::fs::Stub::FileWithContentToBeTrimmed;
|
|
use nu_test_support::nu_with_plugins;
|
|
use nu_test_support::playground::Playground;
|
|
|
|
const TEST_CWD: &str = "tests/fixtures/formats";
|
|
|
|
#[test]
|
|
fn parses_ini() {
|
|
let actual = nu_with_plugins!(
|
|
cwd: TEST_CWD,
|
|
plugin: ("nu_plugin_formats"),
|
|
"open sample.ini | get SectionOne.integer"
|
|
);
|
|
|
|
assert_eq!(actual.out, "1234")
|
|
}
|
|
|
|
#[test]
|
|
fn parses_utf16_ini() {
|
|
let actual = nu_with_plugins!(
|
|
cwd: TEST_CWD,
|
|
plugin: ("nu_plugin_formats"),
|
|
"open ./utf16.ini --raw | decode utf-16 | from ini | rename info | get info | get IconIndex"
|
|
);
|
|
|
|
assert_eq!(actual.out, "-236")
|
|
}
|
|
|
|
#[test]
|
|
fn read_ini_with_missing_session() {
|
|
Playground::setup("from ini with missiong session", |dirs, sandbox| {
|
|
sandbox.with_files(vec![FileWithContentToBeTrimmed(
|
|
"some_missing.ini",
|
|
r#"
|
|
min-width=450
|
|
max-width=820
|
|
[normal]
|
|
sound-file=/usr/share/sounds/freedesktop/stereo/dialog-information.oga
|
|
[critical]
|
|
border-color=FAB387ff
|
|
default-timeout=20
|
|
sound-file=/usr/share/sounds/freedesktop/stereo/dialog-warning.oga
|
|
"#,
|
|
)]);
|
|
|
|
let cwd = dirs.test();
|
|
let actual = nu_with_plugins!(
|
|
cwd: cwd,
|
|
plugin: ("nu_plugin_formats"),
|
|
r#"open some_missing.ini | get "".min-width "#
|
|
);
|
|
|
|
assert_eq!(actual.out, "450");
|
|
})
|
|
}
|