forked from extern/nushell
df15fc24fe
# Description
I have (hopefully) simplified the `log.nu` internal structure and added
customizable log format for all `log` commands
# User-Facing Changes
- [x] Replaced constants with env records for:
- ansi (newly added)
- log level
- prefix
- short prefix
- [x] Added `format` argument to all log commands
- [x] Assertions for (not) equality (equal, not equal, greater,
lesser...) now put left and right values inside `'` quotes, so the
assertions for strings are more meaningful
- [x] Documented the %-formatting of log messages
# Tests + Formatting
<!--
Don't forget to add tests that cover your changes.
Make sure you've run and fixed any issues with these commands:
- `cargo fmt --all -- --check` to check standard code formatting (`cargo
fmt --all` applies these changes)
- `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A
clippy::needless_collect -A clippy::result_large_err` to check that
you're using the standard code style
- `cargo test --workspace` to check that all tests pass
- `cargo run -- crates/nu-std/tests/run.nu` to run the tests for the
standard library
> **Note**
> from `nushell` you can also use the `toolkit` as follows
> ```bash
> use toolkit.nu # or use an `env_change` hook to activate it
automatically
> toolkit check pr
> ```
-->
# After Submitting
<!-- If your PR had any user-facing changes, update [the
documentation](https://github.com/nushell/nushell.github.io) after the
PR is merged, if necessary. This will help us keep the docs up to date.
-->
---------
Co-authored-by: amtoine <stevan.antoine@gmail.com>
88 lines
2.0 KiB
Plaintext
88 lines
2.0 KiB
Plaintext
use std *
|
|
|
|
def run [
|
|
system_level,
|
|
message_level
|
|
--short
|
|
] {
|
|
do {
|
|
if $short {
|
|
^$nu.current-exe --commands $'use std; NU_LOG_LEVEL=($system_level) std log ($message_level) --short "test message"'
|
|
} else {
|
|
^$nu.current-exe --commands $'use std; NU_LOG_LEVEL=($system_level) std log ($message_level) "test message"'
|
|
}
|
|
} | complete | get --ignore-errors stderr
|
|
}
|
|
|
|
def "assert no message" [
|
|
system_level,
|
|
message_level
|
|
] {
|
|
let output = (run $system_level $message_level)
|
|
assert equal "" $output
|
|
}
|
|
|
|
def "assert message" [
|
|
system_level,
|
|
message_level,
|
|
message_level_str
|
|
] {
|
|
let output = (run $system_level $message_level)
|
|
assert str contains $output $message_level_str
|
|
assert str contains $output "test message"
|
|
}
|
|
|
|
def "assert message short" [
|
|
system_level,
|
|
message_level,
|
|
message_level_str
|
|
] {
|
|
let output = (run --short $system_level $message_level)
|
|
assert str contains $output $message_level_str
|
|
assert str contains $output "test message"
|
|
}
|
|
|
|
export def test_critical [] {
|
|
assert no message 99 critical
|
|
assert message CRITICAL critical CRT
|
|
}
|
|
|
|
export def test_critical_short [] {
|
|
assert message short CRITICAL critical C
|
|
}
|
|
|
|
export def test_error [] {
|
|
assert no message CRITICAL error
|
|
assert message ERROR error ERR
|
|
}
|
|
|
|
export def test_error_short [] {
|
|
assert message short ERROR error E
|
|
}
|
|
|
|
export def test_warning [] {
|
|
assert no message ERROR warning
|
|
assert message WARNING warning WRN
|
|
}
|
|
|
|
export def test_warning_short [] {
|
|
assert message short WARNING warning W
|
|
}
|
|
|
|
export def test_info [] {
|
|
assert no message WARNING info
|
|
assert message INFO info "INF" # INF has to be quoted, otherwise it is the `inf` float
|
|
}
|
|
|
|
export def test_info_short [] {
|
|
assert message short INFO info I
|
|
}
|
|
|
|
export def test_debug [] {
|
|
assert no message INFO debug
|
|
assert message DEBUG debug DBG
|
|
}
|
|
|
|
export def test_debug_short [] {
|
|
assert message short DEBUG debug D
|
|
} |