forked from extern/nushell
# Description Allow `decode` command to guess the encoding of input if no encoding name is given. # User-Facing Changes * `decode` now has an optional parameter instead of required one. User can just run `decode` to let the command automatically detect encoding and convert it to utf-8. <img width="575" alt="Example" src="https://github.com/nushell/nushell/assets/1991933/03a0ba11-910e-4db9-89aa-79cfec06893f"> * Based on the detect result, user may have to give a encoding name <img width="572" alt="Error Sample1" src="https://github.com/nushell/nushell/assets/1991933/f21fda85-1f04-4cb3-9feb-cb9fb7dcee07"> or get informed that the input is not supported by `decode` <img width="568" alt="Error Sample2" src="https://github.com/nushell/nushell/assets/1991933/dd3cc4c0-f119-493e-8609-d07594fc055a"> # Tests + Formatting * `cargo fmt --all -- --check` : OK * `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect -A clippy::result_large_err`: OK * `cargo test --workspace` : OK * `cargo run -- -c "use std testing; testing run-tests --path crates/nu-std"`: OK # After Submitting [Command document](https://www.nushell.sh/commands/docs/decode.html) is auto-generated and requires no action. --------- Co-authored-by: Horasal <horsal@horsal.dev>
124 lines
4.3 KiB
Rust
124 lines
4.3 KiB
Rust
use nu_engine::CallExt;
|
|
use nu_protocol::ast::Call;
|
|
use nu_protocol::engine::{Command, EngineState, Stack};
|
|
use nu_protocol::{
|
|
Category, Example, IntoPipelineData, PipelineData, ShellError, Signature, Span, Spanned,
|
|
SyntaxShape, Type, Value,
|
|
};
|
|
|
|
#[derive(Clone)]
|
|
pub struct Decode;
|
|
|
|
impl Command for Decode {
|
|
fn name(&self) -> &str {
|
|
"decode"
|
|
}
|
|
|
|
fn usage(&self) -> &str {
|
|
"Decode bytes into a string."
|
|
}
|
|
|
|
fn search_terms(&self) -> Vec<&str> {
|
|
vec!["text", "encoding", "decoding"]
|
|
}
|
|
|
|
fn signature(&self) -> nu_protocol::Signature {
|
|
Signature::build("decode")
|
|
.input_output_types(vec![(Type::Binary, Type::String)])
|
|
.optional("encoding", SyntaxShape::String, "the text encoding to use")
|
|
.category(Category::Strings)
|
|
}
|
|
|
|
fn extra_usage(&self) -> &str {
|
|
r#"Multiple encodings are supported; here are a few:
|
|
big5, euc-jp, euc-kr, gbk, iso-8859-1, utf-16, cp1252, latin5
|
|
|
|
For a more complete list of encodings please refer to the encoding_rs
|
|
documentation link at https://docs.rs/encoding_rs/latest/encoding_rs/#statics"#
|
|
}
|
|
|
|
fn examples(&self) -> Vec<Example> {
|
|
vec![
|
|
Example {
|
|
description: "Decode the output of an external command",
|
|
example: "^cat myfile.q | decode utf-8",
|
|
result: None,
|
|
},
|
|
Example {
|
|
description: "Decode an UTF-16 string into nushell UTF-8 string",
|
|
example: r#"0x[00 53 00 6F 00 6D 00 65 00 20 00 44 00 61 00 74 00 61] | decode utf-16be"#,
|
|
result: Some(Value::String {
|
|
val: "Some Data".to_owned(),
|
|
span: Span::test_data(),
|
|
}),
|
|
},
|
|
]
|
|
}
|
|
|
|
fn run(
|
|
&self,
|
|
engine_state: &EngineState,
|
|
stack: &mut Stack,
|
|
call: &Call,
|
|
input: PipelineData,
|
|
) -> Result<PipelineData, ShellError> {
|
|
let head = call.head;
|
|
let encoding: Option<Spanned<String>> = call.opt(engine_state, stack, 0)?;
|
|
|
|
match input {
|
|
PipelineData::ExternalStream { stdout: None, .. } => Ok(PipelineData::empty()),
|
|
PipelineData::ExternalStream {
|
|
stdout: Some(stream),
|
|
span: input_span,
|
|
..
|
|
} => {
|
|
let bytes: Vec<u8> = stream.into_bytes()?.item;
|
|
match encoding {
|
|
Some(encoding_name) => super::encoding::decode(head, encoding_name, &bytes),
|
|
None => super::encoding::detect_encoding_name(head, input_span, &bytes)
|
|
.map(|encoding| encoding.decode(&bytes).0.into_owned())
|
|
.map(|s| Value::String { val: s, span: head }),
|
|
}
|
|
.map(|val| val.into_pipeline_data())
|
|
}
|
|
PipelineData::Value(v, ..) => match v {
|
|
Value::Binary {
|
|
val: bytes,
|
|
span: input_span,
|
|
} => match encoding {
|
|
Some(encoding_name) => super::encoding::decode(head, encoding_name, &bytes),
|
|
None => super::encoding::detect_encoding_name(head, input_span, &bytes)
|
|
.map(|encoding| encoding.decode(&bytes).0.into_owned())
|
|
.map(|s| Value::String { val: s, span: head }),
|
|
}
|
|
.map(|val| val.into_pipeline_data()),
|
|
Value::Error { error, .. } => Err(*error),
|
|
_ => Err(ShellError::OnlySupportsThisInputType {
|
|
exp_input_type: "binary".into(),
|
|
wrong_type: v.get_type().to_string(),
|
|
dst_span: head,
|
|
src_span: v.span(),
|
|
}),
|
|
},
|
|
// This should be more precise, but due to difficulties in getting spans
|
|
// from PipelineData::ListData, this is as it is.
|
|
_ => Err(ShellError::UnsupportedInput(
|
|
"non-binary input".into(),
|
|
"value originates from here".into(),
|
|
head,
|
|
input.span().unwrap_or(head),
|
|
)),
|
|
}
|
|
}
|
|
}
|
|
|
|
#[cfg(test)]
|
|
mod test {
|
|
use super::*;
|
|
|
|
#[test]
|
|
fn test_examples() {
|
|
crate::test_examples(Decode)
|
|
}
|
|
}
|