forked from extern/nushell
65d0b5b9d9
# Description This closes #7498, as well as fixes an issue reported in https://github.com/nushell/nushell/pull/7002#issuecomment-1368340773 BEFORE: ``` 〉[{foo: 'bar'} {}] | get foo Error: nu:🐚:column_not_found (link) × Cannot find column ╭─[entry #5:1:1] 1 │ [{foo: 'bar'} {}] | get foo · ────────┬──────── ─┬─ · │ ╰── value originates here · ╰── cannot find column 'Empty cell' ╰──── 〉[{foo: 'bar'} {}].foo ╭───┬─────╮ │ 0 │ bar │ │ 1 │ │ ╰───┴─────╯ ``` AFTER: ``` 〉[{foo: 'bar'} {}] | get foo Error: nu:🐚:column_not_found (link) × Cannot find column ╭─[entry #1:1:1] 1 │ [{foo: 'bar'} {}] | get foo · ─┬ ─┬─ · │ ╰── cannot find column 'foo' · ╰── value originates here ╰──── 〉[{foo: 'bar'} {}].foo Error: nu:🐚:column_not_found (link) × Cannot find column ╭─[entry #3:1:1] 1 │ [{foo: 'bar'} {}].foo · ─┬ ─┬─ · │ ╰── cannot find column 'foo' · ╰── value originates here ╰──── ``` EDIT: This also changes the semantics of `get`/`select` `-i` somewhat. I've decided to leave it like this because it works more intuitively with `default` and `compact`. BEFORE: ``` 〉[{a:1} {b:2} {a:3}] | select -i foo | to nuon null ``` AFTER: ``` 〉[{a:1} {b:2} {a:3}] | select -i foo | to nuon [[foo]; [null], [null], [null]] ``` # User-Facing Changes See above. EDIT: the issue with holes in cases like ` [{foo: 'bar'} {}].foo.0` versus ` [{foo: 'bar'} {}].0.foo` has been resolved. # Tests + Formatting Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass # After Submitting If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date.
275 lines
6.5 KiB
Rust
275 lines
6.5 KiB
Rust
use nu_test_support::fs::Stub::{EmptyFile, FileWithContentToBeTrimmed};
|
|
use nu_test_support::playground::Playground;
|
|
use nu_test_support::{nu, pipeline};
|
|
|
|
#[test]
|
|
fn regular_columns() {
|
|
let actual = nu!(cwd: ".", pipeline(
|
|
r#"
|
|
echo [
|
|
[first_name, last_name, rusty_at, type];
|
|
|
|
[Andrés Robalino 10/11/2013 A]
|
|
[Jonathan Turner 10/12/2013 B]
|
|
[Yehuda Katz 10/11/2013 A]
|
|
]
|
|
| select rusty_at last_name
|
|
| get 0
|
|
| get last_name
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "Robalino");
|
|
}
|
|
|
|
#[test]
|
|
fn complex_nested_columns() {
|
|
Playground::setup("select_test_2", |dirs, sandbox| {
|
|
sandbox.with_files(vec![FileWithContentToBeTrimmed(
|
|
"los_tres_caballeros.json",
|
|
r#"
|
|
{
|
|
"nu": {
|
|
"committers": [
|
|
{"name": "Andrés N. Robalino"},
|
|
{"name": "Jonathan Turner"},
|
|
{"name": "Yehuda Katz"}
|
|
],
|
|
"releases": [
|
|
{"version": "0.2"}
|
|
{"version": "0.8"},
|
|
{"version": "0.9999999"}
|
|
],
|
|
"0xATYKARNU": [
|
|
["Th", "e", " "],
|
|
["BIG", " ", "UnO"],
|
|
["punto", "cero"]
|
|
]
|
|
}
|
|
}
|
|
"#,
|
|
)]);
|
|
|
|
let actual = nu!(
|
|
cwd: dirs.test(), pipeline(
|
|
r#"
|
|
open los_tres_caballeros.json
|
|
| select nu."0xATYKARNU" nu.committers.name nu.releases.version
|
|
| get nu_releases_version
|
|
| where $it > "0.8"
|
|
| get 0
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "0.9999999");
|
|
})
|
|
}
|
|
|
|
#[test]
|
|
fn fails_if_given_unknown_column_name() {
|
|
let actual = nu!(cwd: ".", pipeline(
|
|
r#"
|
|
echo [
|
|
[first_name, last_name, rusty_at, type];
|
|
|
|
[Andrés Robalino 10/11/2013 A]
|
|
[Jonathan Turner 10/12/2013 B]
|
|
[Yehuda Katz 10/11/2013 A]
|
|
]
|
|
| select rrusty_at first_name
|
|
| length
|
|
"#
|
|
));
|
|
|
|
assert!(actual.err.contains("nu::shell::name_not_found"));
|
|
}
|
|
|
|
#[test]
|
|
fn column_names_with_spaces() {
|
|
let actual = nu!(cwd: ".", pipeline(
|
|
r#"
|
|
echo [
|
|
["first name", "last name"];
|
|
|
|
[Andrés Robalino]
|
|
[Andrés Jnth]
|
|
]
|
|
| select "last name"
|
|
| get "last name"
|
|
| str join " "
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "Robalino Jnth");
|
|
}
|
|
|
|
#[test]
|
|
fn ignores_duplicate_columns_selected() {
|
|
let actual = nu!(cwd: ".", pipeline(
|
|
r#"
|
|
echo [
|
|
["first name", "last name"];
|
|
|
|
[Andrés Robalino]
|
|
[Andrés Jnth]
|
|
]
|
|
| select "first name" "last name" "first name"
|
|
| columns
|
|
| str join " "
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "first name last name");
|
|
}
|
|
|
|
#[test]
|
|
fn selects_a_row() {
|
|
Playground::setup("select_test_1", |dirs, sandbox| {
|
|
sandbox.with_files(vec![EmptyFile("notes.txt"), EmptyFile("arepas.txt")]);
|
|
|
|
let actual = nu!(
|
|
cwd: dirs.test(), pipeline(
|
|
r#"
|
|
ls
|
|
| sort-by name
|
|
| select 0
|
|
| get name.0
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "arepas.txt");
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn selects_many_rows() {
|
|
Playground::setup("select_test_2", |dirs, sandbox| {
|
|
sandbox.with_files(vec![EmptyFile("notes.txt"), EmptyFile("arepas.txt")]);
|
|
|
|
let actual = nu!(
|
|
cwd: dirs.test(), pipeline(
|
|
r#"
|
|
ls
|
|
| get name
|
|
| select 1 0
|
|
| length
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "2");
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn select_ignores_errors_successfully1() {
|
|
let actual = nu!(
|
|
cwd: ".", pipeline(
|
|
r#"
|
|
[{a: 1, b: 2} {a: 3, b: 5} {a: 3}] | select -i b | length
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "3".to_string());
|
|
assert!(actual.err.is_empty());
|
|
}
|
|
|
|
#[test]
|
|
fn select_ignores_errors_successfully2() {
|
|
let actual = nu!(
|
|
cwd: ".", pipeline(
|
|
r#"
|
|
[{a: 1} {a: 2} {a: 3}] | select -i b | to nuon
|
|
"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "[[b]; [null], [null], [null]]".to_string());
|
|
assert!(actual.err.is_empty());
|
|
}
|
|
|
|
#[test]
|
|
fn select_ignores_errors_successfully3() {
|
|
let actual = nu!(
|
|
cwd: ".", pipeline(
|
|
r#"sys | select -i invalid_key | to nuon"#
|
|
));
|
|
|
|
assert_eq!(actual.out, "{invalid_key: null}".to_string());
|
|
assert!(actual.err.is_empty());
|
|
}
|
|
|
|
#[test]
|
|
fn select_ignores_errors_successfully4() {
|
|
let actual = nu!(
|
|
cwd: ".", pipeline(
|
|
r#"[a b c] | select -i invalid_key | to nuon"#
|
|
));
|
|
|
|
assert_eq!(
|
|
actual.out,
|
|
"[[invalid_key]; [null], [null], [null]]".to_string()
|
|
);
|
|
assert!(actual.err.is_empty());
|
|
}
|
|
|
|
#[test]
|
|
fn select_ignores_errors_successfully5() {
|
|
let actual = nu!(
|
|
cwd: ".", pipeline(
|
|
r#"[a b c] | select -i 0.0"#
|
|
));
|
|
|
|
assert!(actual.out.is_empty());
|
|
assert!(actual.err.is_empty());
|
|
}
|
|
|
|
#[test]
|
|
fn select_ignores_errors_successfully6() {
|
|
let actual = nu!(
|
|
cwd: ".", pipeline(
|
|
r#""key val\na 1\nb 2\n" | lines | split column -c " " | select -i "100" | to nuon"#
|
|
));
|
|
|
|
assert_eq!(
|
|
actual.out,
|
|
r#"[["100"]; [null], [null], [null]]"#.to_string()
|
|
);
|
|
assert!(actual.err.is_empty());
|
|
}
|
|
|
|
#[test]
|
|
fn select_failed1() {
|
|
let actual = nu!(
|
|
cwd: ".", pipeline(
|
|
r#"
|
|
[{a: 1, b: 2} {a: 3, b: 5} {a: 3}] | select b
|
|
"#
|
|
));
|
|
|
|
assert!(actual.out.is_empty());
|
|
assert!(actual.err.contains("cannot find column"));
|
|
}
|
|
|
|
#[test]
|
|
fn select_failed2() {
|
|
let actual = nu!(
|
|
cwd: ".", pipeline(
|
|
r#"
|
|
[{a: 1} {a: 2} {a: 3}] | select b
|
|
"#
|
|
));
|
|
|
|
assert!(actual.out.is_empty());
|
|
assert!(actual.err.contains("cannot find column"));
|
|
}
|
|
|
|
#[test]
|
|
fn select_failed3() {
|
|
let actual = nu!(
|
|
cwd: ".", pipeline(
|
|
r#""key val\na 1\nb 2\n" | lines | split column -c " " | select "100""#
|
|
));
|
|
|
|
assert!(actual.out.is_empty());
|
|
assert!(actual.err.contains("cannot find column"));
|
|
}
|