nushell/crates/nu-command/src/path/basename.rs
Jérémy Audiger 99076af18b
Use imported names in Command::run signatures (#7967)
# Description

_(Thank you for improving Nushell. Please, check our [contributing
guide](../CONTRIBUTING.md) and talk to the core team before making major
changes.)_

I opened this PR to unify the run command method. It's mainly to improve
consistency across the tree.

# User-Facing Changes

None.

# Tests + Formatting

Don't forget to add tests that cover your changes.

Make sure you've run and fixed any issues with these commands:

- `cargo fmt --all -- --check` to check standard code formatting (`cargo
fmt --all` applies these changes)
- `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A
clippy::needless_collect` to check that you're using the standard code
style
- `cargo test --workspace` to check that all tests pass

# After Submitting

If your PR had any user-facing changes, update [the
documentation](https://github.com/nushell/nushell.github.io) after the
PR is merged, if necessary. This will help us keep the docs up to date.
2023-02-05 22:17:46 +01:00

166 lines
5.0 KiB
Rust

use std::path::Path;
use nu_engine::CallExt;
use nu_protocol::ast::Call;
use nu_protocol::engine::{EngineState, Stack};
use nu_protocol::{
engine::Command, Example, PipelineData, ShellError, Signature, Span, Spanned, SyntaxShape,
Type, Value,
};
use super::PathSubcommandArguments;
struct Arguments {
columns: Option<Vec<String>>,
replace: Option<Spanned<String>>,
}
impl PathSubcommandArguments for Arguments {
fn get_columns(&self) -> Option<Vec<String>> {
self.columns.clone()
}
}
#[derive(Clone)]
pub struct SubCommand;
impl Command for SubCommand {
fn name(&self) -> &str {
"path basename"
}
fn signature(&self) -> Signature {
Signature::build("path basename")
.input_output_types(vec![
(Type::String, Type::String),
// TODO: Why do these commands not use CellPaths in a standard way?
(Type::Table(vec![]), Type::Table(vec![])),
])
.named(
"columns",
SyntaxShape::Table,
"For a record or table input, convert strings in the given columns to their basename",
Some('c'),
)
.named(
"replace",
SyntaxShape::String,
"Return original path with basename replaced by this string",
Some('r'),
)
}
fn usage(&self) -> &str {
"Get the final component of a path"
}
fn run(
&self,
engine_state: &EngineState,
stack: &mut Stack,
call: &Call,
input: PipelineData,
) -> Result<PipelineData, ShellError> {
let head = call.head;
let args = Arguments {
columns: call.get_flag(engine_state, stack, "columns")?,
replace: call.get_flag(engine_state, stack, "replace")?,
};
// This doesn't match explicit nulls
if matches!(input, PipelineData::Empty) {
return Err(ShellError::PipelineEmpty(head));
}
input.map(
move |value| super::operate(&get_basename, &args, value, head),
engine_state.ctrlc.clone(),
)
}
#[cfg(windows)]
fn examples(&self) -> Vec<Example> {
vec![
Example {
description: "Get basename of a path",
example: "'C:\\Users\\joe\\test.txt' | path basename",
result: Some(Value::test_string("test.txt")),
},
Example {
description: "Get basename of a path in a column",
example: "ls .. | path basename -c [ name ]",
result: None,
},
Example {
description: "Get basename of a path in a column",
example: "[[name];[C:\\Users\\Joe]] | path basename -c [ name ]",
result: Some(Value::List {
vals: vec![Value::Record {
cols: vec!["name".to_string()],
vals: vec![Value::test_string("Joe")],
span: Span::test_data(),
}],
span: Span::test_data(),
}),
},
Example {
description: "Replace basename of a path",
example: "'C:\\Users\\joe\\test.txt' | path basename -r 'spam.png'",
result: Some(Value::test_string("C:\\Users\\joe\\spam.png")),
},
]
}
#[cfg(not(windows))]
fn examples(&self) -> Vec<Example> {
vec![
Example {
description: "Get basename of a path",
example: "'/home/joe/test.txt' | path basename",
result: Some(Value::test_string("test.txt")),
},
Example {
description: "Get basename of a path by column",
example: "[[name];[/home/joe]] | path basename -c [ name ]",
result: Some(Value::List {
vals: vec![Value::Record {
cols: vec!["name".to_string()],
vals: vec![Value::test_string("joe")],
span: Span::test_data(),
}],
span: Span::test_data(),
}),
},
Example {
description: "Replace basename of a path",
example: "'/home/joe/test.txt' | path basename -r 'spam.png'",
result: Some(Value::test_string("/home/joe/spam.png")),
},
]
}
}
fn get_basename(path: &Path, span: Span, args: &Arguments) -> Value {
match &args.replace {
Some(r) => Value::string(path.with_file_name(r.item.clone()).to_string_lossy(), span),
None => Value::string(
match path.file_name() {
Some(n) => n.to_string_lossy(),
None => "".into(),
},
span,
),
}
}
#[cfg(test)]
mod tests {
use super::*;
#[test]
fn test_examples() {
use crate::test_examples;
test_examples(SubCommand {})
}
}