nushell/crates/nu-command/src/strings
Christopher Durham 0f600bc3f5
Improve case insensitivity consistency (#10884)
# Description

Add an extension trait `IgnoreCaseExt` to nu_utils which adds some case
insensitivity helpers, and use them throughout nu to improve the
handling of case insensitivity. Proper case folding is done via unicase,
which is already a dependency via mime_guess from nu-command.

In actuality a lot of code still does `to_lowercase`, because unicase
only provides immediate comparison and doesn't expose a `to_folded_case`
yet. And since we do a lot of `contains`/`starts_with`/`ends_with`, it's
not sufficient to just have `eq_ignore_case`. But if we get access in
the future, this makes us ready to use it with a change in one place.

Plus, it's clearer what the purpose is at the call site to call
`to_folded_case` instead of `to_lowercase` if it's exclusively for the
purpose of case insensitive comparison, even if it just does
`to_lowercase` still.

# User-Facing Changes

- Some commands that were supposed to be case insensitive remained only
insensitive to ASCII case (a-z), and now are case insensitive w.r.t.
non-ASCII characters as well.

# Tests + Formatting

- 🟢 `toolkit fmt`
- 🟢 `toolkit clippy`
- 🟢 `toolkit test`
- 🟢 `toolkit test stdlib`

---------

Co-authored-by: Stefan Holderbach <sholderbach@users.noreply.github.com>
2023-11-08 23:58:54 +01:00
..
encode_decode Improve case insensitivity consistency (#10884) 2023-11-08 23:58:54 +01:00
format Convert ShellError::DatetimeParseError to named fields (#10991) 2023-11-08 13:04:02 +01:00
split Convert more examples and tests to record! macro (#10840) 2023-10-28 14:52:31 +02:00
str_ Improve case insensitivity consistency (#10884) 2023-11-08 23:58:54 +01:00
char_.rs Use long options for string (#10777) 2023-10-19 22:08:09 +02:00
detect_columns.rs Convert more examples and tests to record! macro (#10840) 2023-10-28 14:52:31 +02:00
mod.rs Move format duration/filesize back into core (#9978) 2023-08-11 06:01:47 +12:00
parse.rs Convert more examples and tests to record! macro (#10840) 2023-10-28 14:52:31 +02:00
size.rs Convert more examples and tests to record! macro (#10840) 2023-10-28 14:52:31 +02:00