nushell/crates/nu-plugin
Reilly Wood f9b5d8bc5e
Add comment explaining background thread usage for plugin calls (#7878)
~~I happened to be reviewing our uses of `thread::spawn()` and came to
the conclusion that we're spawning a thread unnecessarily for plugin
calls. We were basically doing this:~~

~~1. Spawn a background thread to send data to the plugin over stdin~~
~~2. Immediately do a blocking wait for the plugin's response~~

~~As far as I can tell, there's no point in spawning a thread for 1 (and
it may harm error handling) given that we're blocking right away for the
response.~~

**Update:** the logic is correct, as confirmed by @WindSoilder
[here](https://discord.com/channels/601130461678272522/855947301380947968/1072743414795350037).
I've added a comment explaining the thread usage.
2023-02-08 08:53:44 -08:00
..
src Add comment explaining background thread usage for plugin calls (#7878) 2023-02-08 08:53:44 -08:00
Cargo.toml Bump to 0.75.1 development version (#7930) 2023-01-31 23:55:29 +01:00
LICENSE Include license text in all crates (#5094) 2022-04-08 10:47:13 +02:00