From e2eb883709749aea734610220bae2d4a2dbdd553 Mon Sep 17 00:00:00 2001 From: bg Date: Mon, 15 Jul 2024 15:13:37 +0200 Subject: [PATCH 1/2] Add `--network=none` if `network_mode: none` is set; fixes #1001. Signed-off-by: bg --- podman_compose.py | 1 + tests/unit/test_get_net_args.py | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/podman_compose.py b/podman_compose.py index dce4c7f5..21ee58e1 100755 --- a/podman_compose.py +++ b/podman_compose.py @@ -876,6 +876,7 @@ def get_net_args(compose, cnt): if net: if net == "none": is_bridge = False + net_args.append("--network=none") elif net == "host": net_args.append(f"--network={net}") elif net.startswith("slirp4netns"): # Note: podman-specific network mode diff --git a/tests/unit/test_get_net_args.py b/tests/unit/test_get_net_args.py index 21c89c6f..586067f0 100644 --- a/tests/unit/test_get_net_args.py +++ b/tests/unit/test_get_net_args.py @@ -257,7 +257,7 @@ class TestGetNetArgs(unittest.TestCase): @parameterized.expand([ ("bridge", ["--network=bridge", f"--network-alias={SERVICE_NAME}"]), ("host", ["--network=host"]), - ("none", []), + ("none", ["--network=none"]), ("slirp4netns", ["--network=slirp4netns"]), ("slirp4netns:cidr=10.42.0.0/24", ["--network=slirp4netns:cidr=10.42.0.0/24"]), ("private", ["--network=private"]), From d95b4d026bfa768ef7d0079549f51a97ebe6050c Mon Sep 17 00:00:00 2001 From: Povilas Kanapickas Date: Wed, 17 Jul 2024 01:43:24 +0300 Subject: [PATCH 2/2] Add newsfragment Signed-off-by: Povilas Kanapickas --- newsfragments/network-mode-none.bugfix | 1 + 1 file changed, 1 insertion(+) create mode 100644 newsfragments/network-mode-none.bugfix diff --git a/newsfragments/network-mode-none.bugfix b/newsfragments/network-mode-none.bugfix new file mode 100644 index 00000000..e1a7266d --- /dev/null +++ b/newsfragments/network-mode-none.bugfix @@ -0,0 +1 @@ +Fix support for `network_mode: none`.