holm/shorewall_code
1
0
Fork 0
forked from extern/shorewall_code
Code Pull Requests Activity

Clarify requirement for RT parameters

Browse Source
This commit is contained in:
Tom Eastep 2009-05-24 16:58:41 -07:00
parent 132f812913
commit 0bd3b0c0af
4 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Shorewall/Perl/Shorewall/Tc.pm
View File

@ -1104,7 +1104,6 @@ sub setup_traffic_shaping() {
my $umax = $tcref->{umax} ? "$tcref->{umax}b" : "\${${dev}_mtu}b";
emit ( "run_tc class add dev $device parent $devref->{number}:$parent classid $classid hfsc sc umax $umax dmax ${dmax}ms rate $rate ul rate $tcref->{ceiling}kbit" );
} else {
warning_message "Leaf HFSC class $classid does not specify UMAX or DMAX" if $tcref->{leaf};
emit ( "run_tc class add dev $device parent $devref->{number}:$parent classid $classid hfsc sc rate $rate ul rate $tcref->{ceiling}kbit" );
}
}

4
docs/traffic_shaping.xml
View File

@ -479,8 +479,8 @@ ppp0 6000kbit 500kbit</programlisting>
<para>When using HFSC, this column may contain 1, 2 or 3 pieces of
information separated by colons (":"). In addition to the minimum
bandwidth, leaf classes must specify DMAX (maximum delay in
milliseconds) and may optionally specify UMAX (the largest packet
bandwidth, leaf classes may specify realtime criteria: DMAX (maximum
delay in milliseconds) and optionally UMAX (the largest packet
expected in the class).</para>
</listitem>

5
manpages/shorewall-tcclasses.xml
View File

@ -180,7 +180,7 @@
class exceed the CEIL of the parent class, things don't work
well.</para>
<para>When using the HFSC queuing discipline, leaf classes should
<para>When using the HFSC queuing discipline, leaf classes may
specify <replaceable>dmax</replaceable>, the maximum delay in
milliseconds that the first queued packet for this class should
experience. May be expressed as an integer, optionally followed by
@ -191,7 +191,8 @@
class. May be expressed as an integer. The unit of measure is
<emphasis>bytes</emphasis> and the integer may be optionally
followed by 'b' with no intervening white space (e.g., 800b).
</para>
<replaceable>umax</replaceable> may only be given if
<replaceable>dmax</replaceable> is also given.</para>
</listitem>
</varlistentry>

8
manpages6/shorewall6-tcclasses.xml
View File

@ -176,7 +176,7 @@
class exceed the CEIL of the parent class, things don't work
well.</para>
<para>When using the HFSC queuing discipline, leaf classes should
<para>When using the HFSC queuing discipline, leaf classes may
specify <replaceable>dmax</replaceable>, the maximum delay in
milliseconds that the first queued packet for this class should
experience. May be expressed as an integer, optionally followed by
@ -186,7 +186,9 @@
<replaceable>umax</replaceable>, the largest packet expected in this
class. May be expressed as an integer. The unit of measure is
<emphasis>bytes</emphasis> and the integer may be optionally
followed by 'b' with no intervening white space (e.g., 800b).</para>
followed by 'b' with no intervening white space (e.g., 800b).
<replaceable>umax</replaceable> may only be given if
<replaceable>dmax</replaceable> is also given.</para>
</listitem>
</varlistentry>
@ -241,8 +243,6 @@
<para>This is the default class for that interface where all
traffic should go, that is not classified otherwise.</para>
<para></para>
<note>
<para>You must define <emphasis
role="bold">default</emphasis> for exactly one class per