From 0cc60ea021da5bab24a7c4c401254bdb8383a0de Mon Sep 17 00:00:00 2001 From: teastep Date: Fri, 17 Apr 2009 22:57:59 +0000 Subject: [PATCH] Avoid 'Invalid BROADCAST address' errors Signed-off-by: Tom Eastep git-svn-id: https://shorewall.svn.sourceforge.net/svnroot/shorewall/trunk@9919 fbd18981-670d-0410-9b5c-8dc0c1a9a2bb --- Shorewall/Perl/Shorewall/Zones.pm | 2 +- Shorewall/changelog.txt | 2 ++ Shorewall/releasenotes.txt | 4 ++++ 3 files changed, 7 insertions(+), 1 deletion(-) diff --git a/Shorewall/Perl/Shorewall/Zones.pm b/Shorewall/Perl/Shorewall/Zones.pm index 3cef05310..4efaf2b24 100644 --- a/Shorewall/Perl/Shorewall/Zones.pm +++ b/Shorewall/Perl/Shorewall/Zones.pm @@ -735,7 +735,7 @@ sub validate_interfaces_file( $ ) my $broadcasts; unless ( $networks eq '' || $networks eq 'detect' ) { - my @broadcasts = split $networks, 'address'; + my @broadcasts = split_list $networks, 'address'; for my $address ( @broadcasts ) { fatal_error 'Invalid BROADCAST address' unless $address =~ /^(\d+)\.(\d+)\.(\d+)\.(\d+)$/; diff --git a/Shorewall/changelog.txt b/Shorewall/changelog.txt index a65b5fcdd..3484d7669 100644 --- a/Shorewall/changelog.txt +++ b/Shorewall/changelog.txt @@ -6,6 +6,8 @@ Changes in Shorewall 4.3.9 3) Allow Shorewall6 with kernel 2.6.24 +4) Avoid 'Invalid BROADCAST address' errors. + Changes in Shorewall 4.3.8 1) Apply Tuomo Soini's patch for USE_DEFAULT_RT. diff --git a/Shorewall/releasenotes.txt b/Shorewall/releasenotes.txt index b8d9b3231..c09f6aa86 100644 --- a/Shorewall/releasenotes.txt +++ b/Shorewall/releasenotes.txt @@ -64,6 +64,10 @@ released late in 2009. /etc/shorewall/tcfilters, an incorrect netmask was being generated in the resulting 'tc' rule. +3) Placing an IP address in the BROADCAST column of + /etc/shorewall/interfaces caused Shorewall-perl to generate an + erroneous 'Invalid BROADCAST address' error. + ---------------------------------------------------------------------------- K N O W N P R O B L E M S R E M A I N I N G ----------------------------------------------------------------------------