From 14673e4ab5f7a5be51fef9586e6f8f5a002feac1 Mon Sep 17 00:00:00 2001
From: teastep <teastep@fbd18981-670d-0410-9b5c-8dc0c1a9a2bb>
Date: Thu, 5 Mar 2009 04:03:05 +0000
Subject: [PATCH] Detect bogus DNAT- rule

git-svn-id: https://shorewall.svn.sourceforge.net/svnroot/shorewall/trunk@9600 fbd18981-670d-0410-9b5c-8dc0c1a9a2bb
---
 Shorewall/Perl/Shorewall/Rules.pm | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/Shorewall/Perl/Shorewall/Rules.pm b/Shorewall/Perl/Shorewall/Rules.pm
index 768ddd46c..9fa870192 100644
--- a/Shorewall/Perl/Shorewall/Rules.pm
+++ b/Shorewall/Perl/Shorewall/Rules.pm
@@ -1164,7 +1164,10 @@ sub process_rule1 ( $$$$$$$$$$$$$ ) {
     fatal_error "Unknown source zone ($sourcezone)" unless $sourceref = defined_zone( $sourcezone );
 
     if ( $actiontype & NATONLY ) {
-	warning_message "Destination zone ($destzone) ignored" unless $destzone eq '-' || $destzone eq '';
+	unless ( $destzone eq '-' || $destzone eq '' ) {
+	    fatal_error "Unknown destination zone ($destzone)" unless $destref = defined_zone( $destzone );
+	    warning_message "Destination zone ($destzone) ignored";
+	}
     } else {
 	fatal_error "Missing destination zone" if $destzone eq '-' || $destzone eq '';
 	fatal_error "Unknown destination zone ($destzone)" unless $destref = defined_zone( $destzone );