holm/shorewall_code
1
0
Fork 0
forked from extern/shorewall_code
Code Pull Requests Activity

Correct messages issued when a provider is not added

Browse Source
This commit is contained in:
Tom Eastep 2009-10-24 08:50:15 -07:00
parent 86df82a29a
commit 3e2cf982a3
3 changed files with 18 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Shorewall/Perl/Shorewall/Providers.pm
View File

@ -501,9 +501,9 @@ sub add_a_provider( ) {
if ( $optional ) { if ( $optional ) {
if ( $shared ) { if ( $shared ) {
emit ( " error_message \"WARNING: Interface $interface is not usable -- Provider $table ($number) not Added\"" );
} else {
emit ( " error_message \"WARNING: Gateway $gateway is not reachable -- Provider $table ($number) not Added\"" ); emit ( " error_message \"WARNING: Gateway $gateway is not reachable -- Provider $table ($number) not Added\"" );
} else {
emit ( " error_message \"WARNING: Interface $interface is not usable -- Provider $table ($number) not Added\"" );
} }
} else { } else {
if ( $shared ) { if ( $shared ) {
@ -788,7 +788,7 @@ sub lookup_provider( $ ) {
} }
# #
# This function is called by the compiler when it is generating the initialize() function. # This function is called by the compiler when it is generating the detect_configuration() function.
# The function emits code to set the ..._IS_USABLE interface variables appropriately for the # The function emits code to set the ..._IS_USABLE interface variables appropriately for the
# optional interfaces # optional interfaces
# #

4
Shorewall/changelog.txt
View File

@ -22,6 +22,10 @@ Changes in Shorewall 4.4.3
11) Fix IPv6 address parsing bug. 11) Fix IPv6 address parsing bug.
12) Add hack to work around iproute IPv6 bug in route handling
13) Correct messages issued when an optional provider is not usable.
Changes in Shorewall 4.4.2 Changes in Shorewall 4.4.2
1) BUGFIX: Correct detection of Persistent SNAT support 1) BUGFIX: Correct detection of Persistent SNAT support

12
Shorewall/releasenotes.txt
View File

@ -192,11 +192,21 @@ Shorewall 4.4.3
4) Nested zones where the parent zone was defined by a wilecard 4) Nested zones where the parent zone was defined by a wilecard
interface (name ends with +) in /etc/shorewall/interfaces did interface (name ends with +) in /etc/shorewall/interfaces did
not work correctly in all cases. not work correctly in some cases.
5) IPv4 addresses embedded in IPv6 (e.g., ::192.168.1.5) were 5) IPv4 addresses embedded in IPv6 (e.g., ::192.168.1.5) were
incorrectly reported as invalid. incorrectly reported as invalid.
6) The messages issued when an optional provider was not usable were
confusing; the message intended to be issued when the provider
shared an interface (WARNING: Gateway <gateway> is not reachable --
Provider <name> (<number>) not Added) was being issued when the
provider did not share an interface. Similarly, the message
intended to be issued when the provider did not share an interface
(WARNING: Interface <interface> is not usable -- Provider <name>
(<number>) not Added) was being issued when the provider did share
an interface.
---------------------------------------------------------------------------- ----------------------------------------------------------------------------
K N O W N P R O B L E M S R E M A I N I N G K N O W N P R O B L E M S R E M A I N I N G
---------------------------------------------------------------------------- ----------------------------------------------------------------------------