From 4fdec73808289a38183bdfcdeee434b7a93d60dc Mon Sep 17 00:00:00 2001 From: Tom Eastep Date: Sun, 26 Dec 2010 07:58:20 -0800 Subject: [PATCH] Fix target of --- Shorewall/Perl/Shorewall/Rules.pm | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/Shorewall/Perl/Shorewall/Rules.pm b/Shorewall/Perl/Shorewall/Rules.pm index fc7015f5a..37bf884d6 100644 --- a/Shorewall/Perl/Shorewall/Rules.pm +++ b/Shorewall/Perl/Shorewall/Rules.pm @@ -835,15 +835,13 @@ sub process_rule_common ( $$$$$$$$$$$$$$$$ ) { # $normalized_target = normalize_action( $basictarget, $loglevel, $param ); - if ( $inaction3 ) { - if ( my $ref = use_action( $normalized_target ) ) { - new_nat_chain $ref->{name} if ( $actiontype = $targets{$basictarget} ) & NATRULE; - } - } else { + unless ( $inaction3 ) { fatal_error "An action may not invoke itself" if $basictarget eq $inaction1; process_action2( $normalized_target ) if use_action( $normalized_target ) && ! ( $actiontype & BUILTIN ); $actiontype = $targets{$basictarget}; } + + $action = $basictarget; # Remove params, if any, from $action. } if ( $inaction1 ) {