diff --git a/Shorewall/Perl/Shorewall/Config.pm b/Shorewall/Perl/Shorewall/Config.pm index 4dfbc95ee..d9fa1fd08 100644 --- a/Shorewall/Perl/Shorewall/Config.pm +++ b/Shorewall/Perl/Shorewall/Config.pm @@ -227,6 +227,10 @@ our %globals; # our %config; # +# Entries in shorewall.conf that have been renamed +# +my %renamed = ( AUTO_COMMENT => 'AUTOCOMMENT' ); +# # Config options and global settings that are to be copied to output script # my @propagateconfig = qw/ DISABLE_IPV6 MODULESDIR MODULE_SUFFIX LOAD_HELPERS_ONLY SUBSYSLOCK LOG_VERBOSITY/; @@ -630,7 +634,7 @@ sub initialize( $;$ ) { DELETE_THEN_ADD => undef, MULTICAST => undef, DONT_LOAD => '', - AUTO_COMMENT => undef , + AUTOCOMMENT => undef , MANGLE_ENABLED => undef , RFC1918_STRICT => undef , NULL_ROUTE_RFC1918 => undef , @@ -1694,6 +1698,7 @@ sub evaluate_expression( $$$ ) { $val = ( exists $ENV{$var} ? $ENV{$var} : exists $params{$var} ? $params{$var} : exists $config{$var} ? $config{$var} : + exists $renamed{$var} ? $config{$renamed{$var}} : exists $capdesc{$var} ? have_capability( $var ) : 0 ); $val = 0 unless defined $val; $val = "'$val'" unless $val =~ /^-?\d+$/; @@ -3686,7 +3691,14 @@ sub process_shorewall_conf( $$ ) { if ( $currentline =~ /^\s*([a-zA-Z]\w*)=(.*?)\s*$/ ) { my ($var, $val) = ($1, $2); - warning_message "Unknown configuration option ($var) ignored", next unless exists $config{$var}; + unless ( exists $config{$var} ) { + if ( exists $renamed{$var} ) { + $var = $renamed{$var}; + } else { + warning_message "Unknown configuration option ($var) ignored"; + next ; + } + } $config{$var} = ( $val =~ /\"([^\"]*)\"$/ ? $1 : $val ); diff --git a/Shorewall/Samples/Universal/shorewall.conf b/Shorewall/Samples/Universal/shorewall.conf index ef9d32565..9815595e2 100644 --- a/Shorewall/Samples/Universal/shorewall.conf +++ b/Shorewall/Samples/Universal/shorewall.conf @@ -114,7 +114,9 @@ ADD_SNAT_ALIASES=No ADMINISABSENTMINDED=Yes -AUTO_COMMENT=Yes +AUTOCOMMENT=Yes + +AUTOHELPERS=Yes AUTOMAKE=No diff --git a/Shorewall/Samples/one-interface/shorewall.conf b/Shorewall/Samples/one-interface/shorewall.conf index 85f0453a6..738978279 100644 --- a/Shorewall/Samples/one-interface/shorewall.conf +++ b/Shorewall/Samples/one-interface/shorewall.conf @@ -125,7 +125,8 @@ ADD_SNAT_ALIASES=No ADMINISABSENTMINDED=Yes -AUTO_COMMENT=Yes +AUTOCOMMENT=Yes + AUTOMAKE=No diff --git a/Shorewall/Samples/three-interfaces/shorewall.conf b/Shorewall/Samples/three-interfaces/shorewall.conf index af96276c8..cf300c7ef 100644 --- a/Shorewall/Samples/three-interfaces/shorewall.conf +++ b/Shorewall/Samples/three-interfaces/shorewall.conf @@ -123,7 +123,8 @@ ADD_SNAT_ALIASES=No ADMINISABSENTMINDED=Yes -AUTO_COMMENT=Yes +AUTOCOMMENT=Yes + AUTOMAKE=No diff --git a/Shorewall/Samples/two-interfaces/shorewall.conf b/Shorewall/Samples/two-interfaces/shorewall.conf index 2a328debe..4f10feb01 100644 --- a/Shorewall/Samples/two-interfaces/shorewall.conf +++ b/Shorewall/Samples/two-interfaces/shorewall.conf @@ -126,7 +126,8 @@ ADD_SNAT_ALIASES=No ADMINISABSENTMINDED=Yes -AUTO_COMMENT=Yes +AUTOCOMMENT=Yes + AUTOMAKE=No diff --git a/Shorewall/configfiles/shorewall.conf b/Shorewall/configfiles/shorewall.conf index a03556c36..e0656356f 100644 --- a/Shorewall/configfiles/shorewall.conf +++ b/Shorewall/configfiles/shorewall.conf @@ -114,7 +114,8 @@ ADD_SNAT_ALIASES=No ADMINISABSENTMINDED=Yes -AUTO_COMMENT=Yes +AUTOCOMMENT=Yes + AUTOMAKE=No diff --git a/Shorewall/manpages/shorewall.conf.xml b/Shorewall/manpages/shorewall.conf.xml index 423be404f..1a0af7d9b 100644 --- a/Shorewall/manpages/shorewall.conf.xml +++ b/Shorewall/manpages/shorewall.conf.xml @@ -283,14 +283,14 @@ - AUTO_COMMENT=[AUTOCOMMENT=[Yes|No] - If set, if there is not a current comment when a macro is - invoked, the behavior is as if the first line of the macro file was - "COMMENT <macro name>". The AUTO_COMMENT option has a default - value of 'Yes'. + Formerly named AUTO_COMMENT. If set, if there is not a current + comment when a macro is invoked, the behavior is as if the first + line of the macro file was "COMMENT <macro name>". The + AUTO_COMMENT option has a default value of 'Yes'. The setting of the AUTOMAKE option is ignored if the start or restart command diff --git a/Shorewall6/Samples6/Universal/shorewall6.conf b/Shorewall6/Samples6/Universal/shorewall6.conf index 27971e4ec..38b38e12d 100644 --- a/Shorewall6/Samples6/Universal/shorewall6.conf +++ b/Shorewall6/Samples6/Universal/shorewall6.conf @@ -109,7 +109,8 @@ ACCOUNTING_TABLE=filter ADMINISABSENTMINDED=Yes -AUTO_COMMENT=Yes +AUTOCOMMENT=Yes + AUTOMAKE=No diff --git a/Shorewall6/Samples6/one-interface/shorewall6.conf b/Shorewall6/Samples6/one-interface/shorewall6.conf index 1c154e6fe..a32586eae 100644 --- a/Shorewall6/Samples6/one-interface/shorewall6.conf +++ b/Shorewall6/Samples6/one-interface/shorewall6.conf @@ -109,7 +109,8 @@ ACCOUNTING_TABLE=filter ADMINISABSENTMINDED=Yes -AUTO_COMMENT=Yes +AUTOCOMMENT=Yes + AUTOMAKE=No diff --git a/Shorewall6/Samples6/three-interfaces/shorewall6.conf b/Shorewall6/Samples6/three-interfaces/shorewall6.conf index 931975362..f818c3298 100644 --- a/Shorewall6/Samples6/three-interfaces/shorewall6.conf +++ b/Shorewall6/Samples6/three-interfaces/shorewall6.conf @@ -109,7 +109,8 @@ ACCOUNTING_TABLE=filter ADMINISABSENTMINDED=Yes -AUTO_COMMENT=Yes +AUTOCOMMENT=Yes + AUTOMAKE=No diff --git a/Shorewall6/Samples6/two-interfaces/shorewall6.conf b/Shorewall6/Samples6/two-interfaces/shorewall6.conf index 3ea7fb22e..f0e2e18be 100644 --- a/Shorewall6/Samples6/two-interfaces/shorewall6.conf +++ b/Shorewall6/Samples6/two-interfaces/shorewall6.conf @@ -109,7 +109,8 @@ ACCOUNTING_TABLE=filter ADMINISABSENTMINDED=Yes -AUTO_COMMENT=Yes +AUTOCOMMENT=Yes + AUTOMAKE=No diff --git a/Shorewall6/manpages/shorewall6.conf.xml b/Shorewall6/manpages/shorewall6.conf.xml index 58ea51084..164eded19 100644 --- a/Shorewall6/manpages/shorewall6.conf.xml +++ b/Shorewall6/manpages/shorewall6.conf.xml @@ -217,14 +217,17 @@ - AUTO_COMMENT=[AUTOCOMMENT=[Yes|No] - If set, if there is not a current comment when a macro is - invoked, the behavior is as if the first line of the macro file was - "COMMENT <macro name>". The AUTO_COMMENT option has a default - value of 'Yes'. + Formerly named AUTO_COMMENT. If set, if there is not a current + comment when a macro is invoked, the behavior is as if the first + line of the macro file was "COMMENT <macro name>". The + AUTO_COMMENT option has a default value of 'Yes'. + + +