holm/shorewall_code
1
0
Fork 0
forked from extern/shorewall_code
Code Pull Requests Activity

Improve USER/GROUP validation.

Browse Source 
Signed-off-by: Tom Eastep <teastep@shorewall.net>
This commit is contained in:
Tom Eastep 2012-06-30 14:46:50 -07:00
parent 5c176c64b7
commit 6ddaa0190e
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Shorewall/Perl/Shorewall/Chains.pm
View File

@ -4189,7 +4189,7 @@ sub resolve_id( $$ ) {
require_capability 'OWNER_NAME_MATCH', "Specifying a $type name", 's';
} else {
my $num = $type eq 'user' ? getpwnam( $id ) : getgrnam( $id );
fatal_error "Unknown $type ($id)" unless supplied $num;
fatal_error "Unknown $type ($id)" unless supplied $num && $num >= 0;
$id = $num;
}
@ -4214,7 +4214,7 @@ sub do_user( $ ) {
if ( supplied $2 ) {
$user = $2;
if ( $user =~ /(\d+)(-(\d+))?$/ ) {
if ( $user =~ /^(\d+)(-(\d+))?$/ ) {
if ( supplied $2 ) {
fatal_error "Invalid User Range ($user)" unless $3 >= $1;
}