From 77bbd88ab4086fde2d0774f3d5e4448cb32e403c Mon Sep 17 00:00:00 2001 From: teastep Date: Fri, 3 Apr 2009 14:36:16 +0000 Subject: [PATCH] Cosmetic improvement in generated code for arp and route filtering. Signed-off-by: Tom Eastep git-svn-id: https://shorewall.svn.sourceforge.net/svnroot/shorewall/trunk@9787 fbd18981-670d-0410-9b5c-8dc0c1a9a2bb --- Shorewall/Perl/Shorewall/Proc.pm | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/Shorewall/Perl/Shorewall/Proc.pm b/Shorewall/Perl/Shorewall/Proc.pm index edc0581f6..06941015f 100644 --- a/Shorewall/Perl/Shorewall/Proc.pm +++ b/Shorewall/Perl/Shorewall/Proc.pm @@ -47,14 +47,14 @@ our $VERSION = '4.3_7'; # ARP Filtering # sub setup_arp_filtering() { - save_progress_message "Setting up ARP filtering..."; - my $interfaces = find_interfaces_by_option 'arp_filter'; my $interfaces1 = find_interfaces_by_option 'arp_ignore'; if ( @$interfaces || @$interfaces1 ) { progress_message2 "$doing ARP Filtering..."; + save_progress_message "Setting up ARP filtering..."; + for my $interface ( @$interfaces ) { my $file = "/proc/sys/net/ipv4/conf/$interface/arp_filter"; my $value = get_interface_option $interface, 'arp_filter'; @@ -101,7 +101,8 @@ sub setup_route_filtering() { emit ( 'for file in /proc/sys/net/ipv4/conf/*; do', " [ -f \$file/rp_filter ] && echo $val > \$file/rp_filter", - 'done' ); + 'done', + '' ); } for my $interface ( @$interfaces ) {