From 7f6430a38378950e00fa4a813f064a0bf8861ea5 Mon Sep 17 00:00:00 2001 From: Tom Eastep Date: Sat, 5 Jan 2013 08:20:51 -0800 Subject: [PATCH] Correct address inversion in match_arp_net() Signed-off-by: Tom Eastep --- Shorewall/Perl/Shorewall/ARP.pm | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/Shorewall/Perl/Shorewall/ARP.pm b/Shorewall/Perl/Shorewall/ARP.pm index a5eb7eb70..a2cf2749a 100644 --- a/Shorewall/Perl/Shorewall/ARP.pm +++ b/Shorewall/Perl/Shorewall/ARP.pm @@ -56,12 +56,9 @@ sub match_arp_net( $$$ ) { my $return = ''; if ( supplied $net ) { - my ( $addr , $mask ) = split( $net , '/', 2 ); - - my $invert = ( $addr =~ s/^!// ) ? '! ' : ''; - + my $invert = ( $net =~ s/^!// ) ? '! ' : ''; validate_net $net, 0; - $return = $source ? "-s $net " : "-d $net "; + $return = $source ? "-s ${invert}$net " : "-d ${invert}$net "; } if ( supplied $mac ) {