Ignore bogus 'env' output with a warning

This commit is contained in:
Tom Eastep 2010-12-01 08:24:02 -08:00
parent 1e9fe662cd
commit 9c2c536ced
4 changed files with 28 additions and 3 deletions

View File

@ -2909,7 +2909,7 @@ sub get_params() {
if ( /^(.*?)=(.*)$/ ) {
$params{$1} = $2 unless $1 eq '_';
} else {
assert(0);
warning_message "Unrecognized output from 'env' ($_) ignored";
}
}
}

View File

@ -1,3 +1,7 @@
Changes in Shorewall 4.4.15.1
1) Change assertion into a warning in getparams.
Changes in Shorewall 4.4.15
1) Add macros from Tuomo Soini.

View File

@ -1 +1,10 @@
There are no known problems in Shorewall 4.4.15
1) On systems running Upstart, shorewall-init cannot reliably secure
the firewall before interfaces are brought up.
2) If the output of 'env' contains a multi-line value, then
compilation failed with an Internal Error.
Workaround: In /etc/shorewall/params, reset any exported variables
that have a multi-line value.
Will be fixed in 4.4.15.1 or 4.4.16, whichever is released first.

View File

@ -1,5 +1,5 @@
----------------------------------------------------------------------------
S H O R E W A L L 4 . 4 . 1 5
S H O R E W A L L 4 . 4 . 1 5 . 1
----------------------------------------------------------------------------
I. PROBLEMS CORRECTED IN THIS RELEASE
@ -13,6 +13,18 @@ VI. PROBLEMS CORRECTED AND NEW FEATURES IN PRIOR RELEASES
I. P R O B L E M S C O R R E C T E D I N T H I S R E L E A S E
----------------------------------------------------------------------------
4.4.15.1
1) If the output of 'env' contained a multi-line value, then
compilation failed with an Internal Error. The code has been
changed so that the compiler now emits a warning and continues:
WARNING: Unrecognized output from 'env' (...) ignored
where ... is the output.
4.4.15
1) Previously, if
a) syn flood protection was enabled in a policy that