From a2f32f25c52a5c215c24007b85f973a52a00b352 Mon Sep 17 00:00:00 2001
From: Tom Eastep <teastep@shorewall.net>
Date: Sat, 9 Jun 2012 06:20:40 -0700
Subject: [PATCH] Add some comments.

Signed-off-by: Tom Eastep <teastep@shorewall.net>
---
 Shorewall/Perl/Shorewall/Misc.pm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/Shorewall/Perl/Shorewall/Misc.pm b/Shorewall/Perl/Shorewall/Misc.pm
index db8ca8f98..e7ce16be5 100644
--- a/Shorewall/Perl/Shorewall/Misc.pm
+++ b/Shorewall/Perl/Shorewall/Misc.pm
@@ -1836,6 +1836,7 @@ sub generate_matrix() {
     progress_message  '  Handling complex zones...';
     #
     # Special processing for configurations with more than 2 off-firewall zones or with other special considerations like IPSEC.
+    # Don't be tempted to move this logic into the zone loop below -- it won't work.
     #
     for my $zone ( @zones ) {
 	my $zoneref = find_zone( $zone );
@@ -1974,8 +1975,8 @@ sub generate_matrix() {
 	    # Now add an unconditional jump to the last unique policy-only chain determined above, if any
 	    #
 	    add_ijump $frwd_ref , g => $last_chain if $frwd_ref && $last_chain;
-	}
-    }
+	} # Forwarding required
+    } # Source Zone Loop
 
     progress_message '  Finishing matrix...';