diff --git a/Shorewall2/firewall b/Shorewall2/firewall index 1dd5ff214..667236589 100755 --- a/Shorewall2/firewall +++ b/Shorewall2/firewall @@ -3803,26 +3803,25 @@ add_a_rule() case "$logtarget" in ACCEPT|DROP|REJECT|CONTINUE) - [ "$logtarget" = REJECT -a -n "$servport" ] && \ - fatal_error "Server port may not be specified in a REJECT rule; rule: \"$rule\"" if [ -z "$proto" -a -z "$cli" -a -z "$serv" -a -z "$servport" -a -z "$userspec" ] ; then error_message "Warning -- Rule \"$rule\" is a POLICY" error_message " -- and should be moved to the policy file" fi ;; REDIRECT) - [ -n "$serv" ] && startup_error "REDIRECT rules cannot"\ - " specify a server IP; rule: \"$rule\"" + [ -n "$serv" ] && \ + fatal_error "REDIRECT rules cannot specify a server IP; rule: \"$rule\"" servport=${servport:=$port} natrule=Yes ;; DNAT) - [ -n "$serv" ] || fatal_error "DNAT rules require a" \ - " server address; rule: \"$rule\"" + [ -n "$serv" ] || \ + fatal_error "DNAT rules require a server address; rule: \"$rule\"" natrule=Yes ;; LOG) - [ -z "$loglevel" ] && fatal_error "LOG requires log level" + [ -z "$loglevel" ] && \ + fatal_error "LOG requires log level" ;; esac