Fix bogus code in process_tc_rule()

git-svn-id: https://shorewall.svn.sourceforge.net/svnroot/shorewall/trunk@1411 fbd18981-670d-0410-9b5c-8dc0c1a9a2bb
This commit is contained in:
teastep 2004-06-28 17:35:03 +00:00
parent 2305f44a76
commit d1fc2daf9d
3 changed files with 8 additions and 5 deletions

View File

@ -34,3 +34,5 @@ Changes since 2.0.2
comments in the rules file WRT "all" in SOURCE or DEST. comments in the rules file WRT "all" in SOURCE or DEST.
16) Pass INVALID icmp packets through the blacklisting chains. 16) Pass INVALID icmp packets through the blacklisting chains.
17) Fix bogus code in process_tc_rule()

View File

@ -2052,11 +2052,7 @@ process_tc_rule()
esac esac
fi fi
if [ "x$dest" != "x-" ]; then [ "x$dest" = "x-" ] || r="${r}-d $dest "
verify_interface $dest || fatal_error "Unknown interface $dest in rule \"$rule\""
r="${r}$(match_dest_dev $dest) "
fi
[ "$proto" = "all" ] || r="${r}-p $proto " [ "$proto" = "all" ] || r="${r}-p $proto "
[ "x$port" = "x-" ] || r="${r}--dport $port " [ "x$port" = "x-" ] || r="${r}--dport $port "
[ "x$sport" = "x-" ] || r="${r}--sport $sport " [ "x$sport" = "x-" ] || r="${r}--sport $sport "

View File

@ -44,6 +44,11 @@ Problems Corrected since 2.0.2
not possible to blacklist hosts that are mounting certain types of not possible to blacklist hosts that are mounting certain types of
ICMP-based DOS attacks. ICMP-based DOS attacks.
Problems corrected since 2.0.3:
1) Non-empty entries in the /etc/shorewall/tcrules DEST column
generated an error message and Shorewall failed to start.
----------------------------------------------------------------------- -----------------------------------------------------------------------
Issues when migrating from Shorewall 2.0.2 to Shorewall 2.0.3: Issues when migrating from Shorewall 2.0.2 to Shorewall 2.0.3: