From ddb925c133f273d02ece32bfb2c1ddcc4cc64ac5 Mon Sep 17 00:00:00 2001
From: teastep <teastep@fbd18981-670d-0410-9b5c-8dc0c1a9a2bb>
Date: Mon, 22 Sep 2003 21:44:22 +0000
Subject: [PATCH] Reword error message

git-svn-id: https://shorewall.svn.sourceforge.net/svnroot/shorewall/trunk@745 fbd18981-670d-0410-9b5c-8dc0c1a9a2bb
---
 Shorewall/changelog.txt | 2 +-
 Shorewall/firewall      | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/Shorewall/changelog.txt b/Shorewall/changelog.txt
index 8b0138301..fdb1e74fb 100755
--- a/Shorewall/changelog.txt
+++ b/Shorewall/changelog.txt
@@ -82,4 +82,4 @@ Changes since 1.4.6
 
 36) Extend USER SET column in /etc/shorewall/rules to allow user:group.
 
-
+37) Reword error message to avoid the word 'illegal'.
diff --git a/Shorewall/firewall b/Shorewall/firewall
index 8a23bc968..653b8d1fe 100755
--- a/Shorewall/firewall
+++ b/Shorewall/firewall
@@ -2569,15 +2569,15 @@ process_rule() # $1 = target
     logtarget="$target"
     dnat_only=
 
-    [ "x$userset" = x- ] && userset=
-
     # Tranform the rule:
     #
+    # - parse the user set specification
     # - set 'target' to the filter table target.
     # - make $FW the destination for REDIRECT
     # - remove '-' suffix from logtargets while setting 'dnat_only'
     # - clear 'address' if it has been set to '-'
 
+    [ "x$userset" = x- ]   && userset=
     [ "x$address" = "x-" ] && address=
 
     if [ -n "$userset" ]; then
@@ -4074,7 +4074,7 @@ add_common_rules() {
 		logdrop|DROP|RETURN)
 		    ;;
 		*)
-		    fatal_error "Illegal target ($target) for $subnet"
+		    fatal_error "Invalid target ($target) for $subnet"
 		    ;;
 	    esac