From e027f5078f55acb630c6c88b13e466d06c5dd69b Mon Sep 17 00:00:00 2001 From: Tom Eastep Date: Mon, 12 Jun 2017 07:44:34 -0700 Subject: [PATCH] Correct a runtime error with NFQUEUE. Signed-off-by: Tom Eastep --- Shorewall/Perl/Shorewall/Rules.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Shorewall/Perl/Shorewall/Rules.pm b/Shorewall/Perl/Shorewall/Rules.pm index ee86dc078..629687b7b 100644 --- a/Shorewall/Perl/Shorewall/Rules.pm +++ b/Shorewall/Perl/Shorewall/Rules.pm @@ -617,7 +617,7 @@ sub handle_nfqueue( $$ ) { fatal_error "Invalid NFQUEUE queue number ($queue1)" unless defined( $queuenum1) && $queuenum1 >= 0 && $queuenum1 <= 65535; if ( supplied $queue2 ) { - $fanout = ' --queue-cpu-fanout' if $queue2 =~ s/c$//; + $fanout = $queue2 =~ s/c$// ? ' --queue-cpu-fanout' : ''; $queuenum2 = numeric_value( $queue2 ); fatal_error "Invalid NFQUEUE queue number ($queue2)" unless defined( $queuenum2) && $queuenum2 >= 0 && $queuenum2 <= 65535 && $queuenum1 < $queuenum2;