From f229aaf5dc71c41c842dc86aa683dbe55e1378c7 Mon Sep 17 00:00:00 2001
From: teastep <teastep@fbd18981-670d-0410-9b5c-8dc0c1a9a2bb>
Date: Thu, 7 Feb 2008 20:47:14 +0000
Subject: [PATCH] Trivial optimization

git-svn-id: https://shorewall.svn.sourceforge.net/svnroot/shorewall/trunk@8164 fbd18981-670d-0410-9b5c-8dc0c1a9a2bb
---
 Shorewall-perl/Shorewall/Rules.pm | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/Shorewall-perl/Shorewall/Rules.pm b/Shorewall-perl/Shorewall/Rules.pm
index 91a3bf6b4..9d0ef42c4 100644
--- a/Shorewall-perl/Shorewall/Rules.pm
+++ b/Shorewall-perl/Shorewall/Rules.pm
@@ -1509,11 +1509,12 @@ sub generate_matrix() {
     my @interfaces = ( all_interfaces );
     my $preroutingref = ensure_chain 'nat', 'dnat';
     my $fw = firewall_zone;
+    my @zones = non_firewall_zones;
 
     #
     # Set up forwarding chain for each zone
     #
-    for my $zone ( non_firewall_zones ) {
+    for my $zone ( @zones ) {
 	my $frwd_ref   = new_standard_chain zone_forward_chain( $zone );
 	my $zoneref    = find_zone( $zone );
 	my $exclusions = $zoneref->{exclusions};
@@ -1571,7 +1572,7 @@ sub generate_matrix() {
     #
     # Main source-zone matrix-generation loop
     #
-    for my $zone ( non_firewall_zones ) {
+    for my $zone ( @zones ) {
 	my $zoneref          = find_zone( $zone );
 	my $source_hosts_ref = $zoneref->{hosts};
 	my $chain1           = rules_target firewall_zone , $zone;
@@ -1734,7 +1735,7 @@ sub generate_matrix() {
 	    my @temp_zones;
 
 	  ZONE1:
-	    for my $zone1 ( non_firewall_zones )  {
+	    for my $zone1 ( @zones )  {
 		my $zone1ref = find_zone( $zone1 );
 		my $policy = $filter_table->{"${zone}2${zone1}"}->{policy};
 
@@ -1775,7 +1776,7 @@ sub generate_matrix() {
 		$last_chain = '';
 	    }
 	} else {
-	    @dest_zones =  non_firewall_zones ;
+	    @dest_zones =  @zones ;
 	}
 	#
 	# Here it is -- THE BIG UGLY!!!!!!!!!!!!