From ab3582987b363e30b13e9627b901fb2320f8ace4 Mon Sep 17 00:00:00 2001 From: Gerome Matilla Date: Sat, 13 Jun 2020 06:41:43 +0800 Subject: [PATCH] README --- README.md | 5 ++++- js/weather-settings.js | 4 ++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 172ea51..86a5a23 100644 --- a/README.md +++ b/README.md @@ -126,10 +126,13 @@ Setting up your OpenWeatherMap credential is a breeze. **Note:** -+ If you're using firefox and you're planning to use the `geolocation`, make sure to set the value of `geo.provider.network.url` to `https://location.services.mozilla.com/v1/geolocate?key=test` in `about:config`. **Google changed its policies, so now it requires a valid API key when accessing their geolocation service. This tells us that you need a valid API key in place of** `%GOOGLE_LOCATION_SERVICE_API_KEY%`. - [Citation](https://stackoverflow.com/questions/61032115/unknown-error-acquiring-position-geolocationpositionerror-code-2-firefox-linux). ++ If you're using firefox and you're planning to use the `geolocation`, make sure to set the value of `geo.provider.network.url` to `https://location.services.mozilla.com/v1/geolocate?key=test` in `about:config`. *Google changed its policies, so now it requires a valid API key when accessing their geolocation service. This tells us that you need a valid API key in place of* `%GOOGLE_LOCATION_SERVICE_API_KEY%`. [Citation](https://stackoverflow.com/questions/61032115/unknown-error-acquiring-position-geolocationpositionerror-code-2-firefox-linux). + ++ If you're on mobile, make sure to enable your GPS and allow the location permission if you want to use `geolocation`. + If you just set the startpage locally, the location permission will always pop-up even if you already accept/denied it. It's better to run it on a web server. + #### Changing the default search engine Google is the default search engine of the search bar, if you want to change it to DuckDuckGo or something: diff --git a/js/weather-settings.js b/js/weather-settings.js index 818eff6..4c83059 100644 --- a/js/weather-settings.js +++ b/js/weather-settings.js @@ -101,8 +101,8 @@ class WeatherSettings { // You denied the permission request _deniedGeolocation = () => { - alert(`You denied the request to access your location. As a consequence for your action, ` + - `you need to allow it on your browser's settings if you want to use the geolocation functionality. You can just use the City Mode, though.`); + alert(`Location access denied! If you're on mobile, make sure to`+ + ` enable your GPS and allow the location permission on your browser's settings.`) }