From 91632eb6eaa637c7748d22263ffa98f1548402c3 Mon Sep 17 00:00:00 2001 From: Georgi Gerganov Date: Tue, 18 Oct 2022 00:45:08 +0300 Subject: [PATCH] Revert GELU change Seems it does not work on x86 for some reason --- ggml.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/ggml.c b/ggml.c index 7f11c96..4beccab 100644 --- a/ggml.c +++ b/ggml.c @@ -723,21 +723,21 @@ inline static void ggml_vec_gelu_f16(const int n, ggml_fp16_t * y, const ggml_fp } } -inline static void ggml_vec_gelu_f32(const int n, float * y, const float * x) { - uint16_t t; - for (int i = 0; i < n; ++i) { - ggml_fp16_t fp16 = ggml_fp32_to_fp16(x[i]); - memcpy(&t, &fp16, sizeof(uint16_t)); - y[i] = table_gelu_f16[t]; - } -} - //inline static void ggml_vec_gelu_f32(const int n, float * y, const float * x) { +// uint16_t t; // for (int i = 0; i < n; ++i) { -// y[i] = ggml_gelu_f32(x[i]); +// ggml_fp16_t fp16 = ggml_fp32_to_fp16(x[i]); +// memcpy(&t, &fp16, sizeof(uint16_t)); +// y[i] = table_gelu_f16[t]; // } //} +inline static void ggml_vec_gelu_f32(const int n, float * y, const float * x) { + for (int i = 0; i < n; ++i) { + y[i] = ggml_gelu_f32(x[i]); + } +} + inline static void ggml_vec_sum_f32 (const int n, float * s, const float * x) { ggml_float sum = 0.0; for (int i = 0; i < n; ++i) sum += x[i]; *s += sum; } inline static void ggml_vec_norm_inv_f32(const int n, float * s, const float * x) { ggml_vec_norm_f32(n, s, x); *s = 1./(*s); }