Commit Graph

588 Commits

Author SHA1 Message Date
102257cb32 Fix typo for ZenkakuHankaku key 2021-03-29 12:50:16 +03:00
77509c1e56 Use toggle keysym for Eisu key
This matches how the key behaves on a Linux system.
2021-03-29 12:50:12 +03:00
9e0a5d26af Update keycode mappings to latest version
This update fixes Korean layouts.
2021-03-29 12:48:56 +03:00
c6c2661121 Add workaround for Firefox PNG rounding bug 2021-03-29 12:48:06 +03:00
8b8201fd73 Remove Firefox Alt workaround
The bug got fixed way back in Firefox 63, and it is also misbehaving
with modern Firefox as they no longer consider AltGr an Alt-key.
2021-03-29 12:48:02 +03:00
33a113a475 Handle empty rects in RAW decoder as well
It was overlooked in the previous commit because we couldn't feed
empty data messages through the test framework.
2021-03-29 12:47:49 +03:00
6d1cebc24a Ignore recording variables in our linter 2021-03-29 12:47:43 +03:00
fcd7836a83 Approximate comparison of JPEG result
The browsers have various rounding errors so we need to compare the
output data only approximately and not exactly.
2021-03-29 12:47:38 +03:00
073737c8ac Handle empty rects from the server
These are very pointless for the server to send, but not a violation of
the protocol so we need to be able to handle them. We've seen this
happen in real world scenarios a few times.
2021-03-29 12:47:30 +03:00
16c72ba0a7 Fix call to _recvMessage()
Missed to rename this one in commit ea858bfa275d85541ac26d035967959714e8e255
2021-03-29 12:45:49 +03:00
d3c9ff8b12 Fix names of recording variables
The name of these variables must match how they were set when the
recording was created.

Reverts part of 95632e413d75030c49577c0e5cf1003208a5ba09
2021-03-29 12:45:41 +03:00
4bc4c1d7f6 noVNC 1.2.0 2021-03-29 12:45:36 +03:00
d8ba9a61e2 Update generated JS files for translations 2021-03-29 12:45:31 +03:00
0e2a25476f Update Swedish translation 2021-03-29 12:45:28 +03:00
b3b4acaaa3 noVNC 1.2.0 beta 2021-03-29 12:45:08 +03:00
201f2517f7 Remove note about clipboard ISO 8859-1 restriction
We now support full Unicode, provided the server also supports the
proper extension.
2021-03-29 12:44:59 +03:00
f51167a2ce Update translation template file 2021-03-29 12:44:54 +03:00
87b3a630cf Remove redundant VERSION file
We want to avoid having this in multiple places.
2021-03-29 12:44:42 +03:00
7412dde8ee Handle quick Cursor detach after mouse up
This timer might fire after the Cursor object has detached from a DOM
element, causing crashes. This will likely not happen in real scenarios,
but the tests are quick enough to trigger this.
2021-03-29 12:44:25 +03:00
3ef6e1333b Remove default Karma options
No need to mention things where we already use the default value.
2021-03-29 12:43:59 +03:00
b84220f319 Add lint rule for function declaration indentation 2021-03-29 12:41:44 +03:00
42d437ad25 Start fake test clock at real clock time
Some code relies on the clock having a somewhat sane value, so let's not
start at 0.
2021-03-29 12:41:15 +03:00
d5b84d9185 Avoid fractional pixel sizes from Display 2021-03-29 12:41:06 +03:00
6db1c2bf0d Avoid printing the Websock buffer in tests
It takes forever and just messes up the output.
2021-03-29 12:40:09 +03:00
ae1bc396bf Standardise on a single blit function
Keep everything simpler by always blitting in the same pixel format.
It's up to the decoders to convert if they need to.
2021-03-29 12:39:31 +03:00
c7a7ce70be Fix bad BasicCompression check in Tight decoder 2021-03-29 12:37:29 +03:00
55178c76b8 Test correct handling of alpha
The forth byte of a pixel is undefined in most encodings, so make sure
the decoders don't leak that through as an alpha channel.
2021-03-29 12:36:47 +03:00
5752bf8ab7 Add tests for the Tight decoders 2021-03-29 12:36:42 +03:00
6fd1035fb1 Split decoder tests to separate files 2021-03-29 12:36:35 +03:00
212e0f1a10 Move tile handling to Hextile decoder
It is only used there so no need for it to be in the general
Display class.
2021-03-29 12:36:23 +03:00
69b945fc87 Standardize on camelCase in Display 2021-03-29 12:35:23 +03:00
b837bd6f59 Add camelCase rule to eslint 2021-03-29 12:34:42 +03:00
670eefbc97 Standardize on camelCase in Base64 2021-03-29 12:34:31 +03:00
b2d8db3f7b Standardize on camelCase in Decoders 2021-03-29 12:34:29 +03:00
a3e2b1e46e Standardize on camelCase in Logging 2021-03-29 12:34:25 +03:00
472ede66ea Standardize on camelCase in Websock 2021-03-29 12:34:23 +03:00
da228af778 Standardize on camelCase in tests 2021-03-29 12:34:13 +03:00
59f5648592 Remove unused properties and variables
The code that used these were removed in the following commits:

* 9ff86fb718477515ede2d6457f06643935d76bcd (RFB._mouse_arr)
* bb6965f2e60c2301dd638383bdc792d1f10af942 (old_requestAnimationFrame)
* 490d471c53b1791398d6c30f0efce54925939f33 (Display._c_forceCanvas)
2021-03-29 12:27:54 +03:00
19c473f792 Properly limit mouse moves to once every 17 ms
Previous attempt in c958269 had a number of issues, this is a full
rewrite, complete with improved unit tests.

Fixes github issue #1402
2021-03-29 12:26:12 +03:00
8a8fa1d906 Stop send mouse clicks while dragging in view only 2021-03-29 12:23:20 +03:00
5a81223d96 Standardize on camelCase for functions in RFB 2021-03-29 12:23:12 +03:00
eff38d47f9 Standardize on camelCase for variables in RFB 2021-03-29 12:21:50 +03:00
1de3769fd3 Remove unused mouse_arr variable 2021-03-29 12:16:38 +03:00
749ddce5b9 Add unit tests for mouse move limit 2021-03-29 12:16:01 +03:00
d420aa6413 Shorten rows to max 80 chars in mouse.js 2021-03-29 12:15:56 +03:00
93e42772bc Fix wording in comment 2021-03-29 12:15:49 +03:00
9098478faf Limit mouse move events to one every 17 ms 2021-03-29 12:15:39 +03:00
4710ec1822 Fix indentation for focus check 2021-03-29 12:15:34 +03:00
02b9b268ff Don't fade the control bar if it has focus
Fixes github issue #1369
2021-03-29 12:15:29 +03:00
a015e33111 Hide the clipboard when not connected
Fixes github issue #1367.
2021-03-29 12:15:25 +03:00