extern/atuin
1
0
Fork 0
mirror of https://github.com/atuinsh/atuin.git synced 2025-01-01 03:51:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix(ui): don't preserve for empty space (#1712)

Browse Source 
For the following situation:

$ atuin search -i --inline-height 15
 [     HOST     ] query
  > 1m    19d ago item 1
  1 0s    1mo ago item 2
  2 0s    1mo ago item 3
  3 0s    1mo ago item 4
  4 0s    1mo ago item 5
  5 0s    1mo ago item 6

 Atuin v17.2.1 [...]

Scrolling item 6 results:

 [     HOST     ] query
    0s    1mo ago item 3
    0s    1mo ago item 4
    0s    1mo ago item 5
  > 0s    1mo ago item 6

 Atuin v17.2.1 [...]

With this patch it becomes:

 [     HOST     ] query
    1m    19d ago item 1
    0s    1mo ago item 2
    0s    1mo ago item 3
    0s    1mo ago item 4
    0s    1mo ago item 5
  > 0s    1mo ago item 6

 Atuin v17.2.1 [...]
This commit is contained in:
依云 2024-02-14 02:33:23 +08:00 committed by GitHub
parent 87e19df9c5
commit 1a432b61ee
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
atuin/src/command/client/search/history_list.rs
View File

@ -109,7 +109,7 @@ impl<'a> HistoryList<'a> {
fn get_items_bounds(&self, selected: usize, offset: usize, height: usize) -> (usize, usize) { fn get_items_bounds(&self, selected: usize, offset: usize, height: usize) -> (usize, usize) {
let offset = offset.min(self.history.len().saturating_sub(1)); let offset = offset.min(self.history.len().saturating_sub(1));
let max_scroll_space = height.min(10); let max_scroll_space = height.min(10).min(self.history.len() - selected);
if offset + height < selected + max_scroll_space { if offset + height < selected + max_scroll_space {
let end = selected + max_scroll_space; let end = selected + max_scroll_space;
(end - height, end) (end - height, end)