extern/atuin
1
0
Fork 0
mirror of https://github.com/atuinsh/atuin.git synced 2024-12-26 00:50:22 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix(tui): dedupe was removing history (#1610)

Browse Source 
Related: https://forum.atuin.sh/t/search-ignoring-commands/74/5?u=ellie

When a user ran a duplicated command, but in another session, it was
removed by filters. This is because the subquery that was once used did
not have the same filters applied as the main query.

Instead of messing with subqueries, `group by` instead. This aligns with
the search() function
This commit is contained in:
Ellie Huxtable 2024-01-22 17:06:34 +00:00 committed by GitHub
parent 600ebc33ab
commit 6af6c9066b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
atuin-client/src/database.rs
View File

@ -306,10 +306,7 @@ impl Database for Sqlite {
} }
if unique { if unique {
query.and_where_eq( query.group_by("command").having("max(timestamp)");
"timestamp",
"(select max(timestamp) from history where h.command = history.command)",
);
} }
if let Some(max) = max { if let Some(max) = max {