This patch fixes several problems of the settings menu related to
display on mobile devices or small(ish) windows:
- The `isMobileLandscape` is now calculated correctly. Previously, this
was set to `true` if a device was in portrait mode.
- Showing the button to collapse the settings menu and making the menu
collapsible now use the same mechanism. Previously, it could happen
that the menu was opened and not fixed, but no button to close it
again was shown.
- The icons fore opening and closing the settings menu are now both
arrows, indicating that their functionality is reversed.
- The button to open the menu now always has the string “Settings”,
instead of using the name of the current page. The current page hader
is listed below that anyway and this is the action component to open
the settings menu after all.
This fixes#1334
This patch fixes some accessibility problems on the main settings page.
Most notably, it makes sure that the different options have labels which
are picked up by screen readers.
As a more generic addition, this also makes sure that the dropdown
component will always have a proper label constructed, explaining what
the dropdown is for and what its current value is.
This patch makes sure that the option in the user settings are
accessible via keyboard navigation and that the labels, if users use a
screen reader, actually make sense.
This patch introduces new strings which need to be translated. Although
I did already provide a German translation.
This patch should fix most of the problems for users trying to access
the user settings via screen reader. It makes sure user interface
elements can be reached via keyboard and provides proper labels, roles
and values so you not only can interact with elements but also know what
you are actually changing.
While not focused on other views, this should also already fix a number
of accessibility issues with other settings pages.
This patch fixes the keyboard navigation in the library selection of the
main app bar. Without this patch, no options are selectable via keyboard
and selecting an option and hitting return has no effect.
This patch highlights items in the app bar if a user uses the keyboard
to navigate in audiobookshelf. This ensures that users actually know
which item they have selected.
This also modifies the text for the library selector, so that users
which are using a screen reader understand that it is a selector for
libraries and not only a button related to the current library.
This patch adds the missing alt attribute to the image linking the home
page of audiobookshelf. This allows screen readers to explain to users
where this link leads to.
Assigning something to `process.env.profile`, Node stringifies the value. This
means that assigning `undefined` to an environment variable in Node will result
in it holding the string `undefined`.
This means, for example, that `module.exports.FFPROBE_PATH || 'ffprobe'` in
`server/libs/nodeFfprobe/index.js` will actually result in the string
`undefined`.
This patch fixes several such assignments in the `index.js`, potentially
causing problems in the development mode.
