extern/django-helpdesk
1
0
Fork 1
mirror of https://github.com/django-helpdesk/django-helpdesk.git synced 2024-12-04 14:03:51 +01:00
Code Issues Packages Projects Releases Wiki Activity

Enable attachments by default

Browse Source 
In order to not break existing django-helpdesk installations
upon upgrade.
This commit is contained in:
Georg Lehner 2024-06-07 17:58:41 +02:00
parent d3553d9335
commit a2f944b475
2 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
docs/settings.rst
View File

@ -62,11 +62,11 @@ Settings related to attachments:
attachments which are then attached to the ticket. Also enables the
``HELPDESK_ALWAYS_SAVE_INCOMING_EMAIL_MESSAGE`` setting.
**Caution**: Until version 1.2.0 attachments were enabled by
default. Since uploaded files by default are published without access
control this can lead to unintended exposure of sensitive
data. The default is now to disable attachments by default. Only
enable attachments if you have secured access to them.
**Caution**: Set this to False, unless you have secured access to
the uploaded files. Otherwise anyone on the Internet will be able
to download your ticket attachments.
Attachments are enabled by default for backwards compatibility.
- **HELPDESK_VALID_EXTENSIONS** Valid extensions for file types that can be attached to tickets. Note: This used to be called **VALID_EXTENSIONS** which is now deprecated.

6
helpdesk/settings.py
View File

@ -57,9 +57,13 @@ HELPDESK_STAFF_VIEW_PROTECTOR = getattr(settings,
lambda _: None)
# Enable ticket and Email attachments
#
# Caution! Set this to False, unless you have secured access to
# the uploaded files. Otherwise anyone on the Internet will be
# able to download your ticket attachments.
HELPDESK_ENABLE_ATTACHMENTS = getattr(settings,
'HELPDESK_ENABLE_ATTACHMENTS',
False)
True)
# Enable the Dependencies field on ticket view
HELPDESK_ENABLE_DEPENDENCIES_ON_TICKET = getattr(settings,