lethanhphuc
04483bdac3
Add att.full_clean() before saving
...
Fix issue https://github.com/django-helpdesk/django-helpdesk/issues/983
Also, fix bug stored XSS disclosure: https://huntr.dev/bounties/4d7a5fdd-b2de-467a-ade0-3f2fb386638e/
2021-11-18 10:42:02 +07:00
Arkadiy Korotaev
c90811418a
chore(pep8): Fix bad imports, unused variables, pep8 warnings and some possible bugs
2021-03-05 09:37:21 +01:00
bbe
5fce1964de
Add email template "merged" thanks to a migration and add merged_to field into the safe ticket context.
2020-10-30 19:56:38 +01:00
alligatorbait
628b734451
bug fix ak.baseurl set before ak initialized
2020-10-14 16:46:41 -06:00
Garret Wassermann
2f788f2597
Merge 0.2.22 bugfix release updates, update copyright year in license, specify python 3.6 or above in setup
2020-07-30 04:46:15 -04:00
Garret Wassermann
2a3fc0894d
Rename and document the maximum email attachment size setting, to address #846
2020-07-30 02:54:03 -04:00
Leonid
6ae7b60ef4
fix error format time_spent
2019-12-25 11:21:47 +03:00
Igor Mikeshin
407c00addd
Fix ticket search, when there are multiple custom fields
2019-11-22 15:14:56 +08:00
Timothy Hobbs
4ca6adbe39
Move query helper functions out of lib to special query file
2019-10-11 16:31:52 +02:00
Timothy Hobbs
0691bbabcd
Refactor and fix datatables code to use cache safely
2019-10-11 15:50:35 +02:00
Timothy Hobbs
03d1c66dd6
Refactor ticket list code
2019-10-11 13:10:35 +02:00
Garret Wassermann
7f27eb9428
Merge 0.2.17 release into develop
2019-08-27 21:53:25 -04:00
Will Stott
45854e44a7
Search custom field values.
2019-07-31 14:04:31 +01:00
Jachym Cepicky
37c6905d46
cleaning time_spent formating
2019-07-06 22:36:58 +02:00
Jachym Cepicky
9127275557
adding support for images as knowledgebase attachment
2019-03-09 18:14:11 +01:00
Garret Wassermann
e1f9fc03ce
PEP-8 fixes for lib.py
2019-01-02 20:08:55 -05:00
Garret Wassermann
6cfc1ca75c
Fix API changes to python-akismet, #687
2019-01-02 19:17:19 -05:00
Garret Wassermann
760c9d64dd
Remove bundled akismet in favor of pypi package dependency, for #687
2019-01-01 19:55:08 -05:00
Garret Wassermann
5f0d22a692
Merge brunotikami/master for user and email threading, for #385 and #375
2018-12-28 10:53:28 -05:00
Garret Wassermann
ce51036c6c
PEP-8 fixes for lib.py
2018-12-21 19:24:33 -05:00
Garret Wassermann
ea8c75b884
Fix saving and loading custom queries, update for Py3/Django2.x
2018-12-21 19:14:54 -05:00
Timothy Hobbs
6c37d73d4e
DRY out email sending code and normalize behavior
...
This refactor removes duplicated logic for deciding whom the messages get sent to.
It also normalizes behavior ensuring that all CCed addresses are sent to in all cases that CCed individuals should be notified.
2018-11-01 14:56:17 +01:00
Garret Wassermann
2b11a0e11a
PEP8 formatting fixes
2018-10-15 13:56:54 -04:00
Dilip Dwarak
fc028334d9
Added optional serverside processing on datatables that lists all tickets - True by default
2018-10-14 20:23:28 -04:00
Garret Wassermann
c70cf04e4d
Fix codestyle errors, use currying instead of lambdas for determing user access
2018-07-19 00:06:57 -04:00
Garret Wassermann
142c291afb
Merge 0.2.4 bugfixes
2017-12-18 00:45:36 -05:00
Garret Wassermann
230b9d7ed0
Fix broken try-except statement in lib, for #577
2017-12-15 20:35:41 -05:00
Garret Wassermann
92b43ef495
Merge master 0.2.3 bugfixes into develop
2017-12-09 23:02:12 -05:00
Garret Wassermann
bc0125421b
Fix PEP8 errors detected by new pycodestyle script
2017-12-06 02:06:07 -05:00
Garret Wassermann
6e2a16e5a6
Fixing unit tests for python3 for custom staff filters
2017-10-30 05:07:44 -04:00
Garret Wassermann
3a1bd76e75
Merge custom staff filter, PR #239
2017-10-30 03:17:40 -04:00
Will Stott
b99b55e426
Miscellaneous debug log additions.
2017-09-06 16:22:06 +01:00
Garret Wassermann
40ab600ad6
Merged in better handling of attachments, for #468
2017-08-30 15:18:22 -04:00
Garret Wassermann
04a3c3ff5a
Update decodestring to decodebytes for Py3 since string name was deprecated in py3.1
2017-08-30 10:48:16 -04:00
msaelices
f931dd4dba
Fix AttributeError while staff user does a mass update in some tickets using the Close (Send E-mail) action.
2017-08-21 01:26:45 +02:00
Garret Wassermann
f6c323c9ab
Fix binary attachments to outgoing email, and handle case when it is plain text, to address #502
2017-07-17 05:04:25 -04:00
User
787c3aa4f5
make old subject_part pretty
2017-01-09 00:30:36 +01:00
User
b7baf2bf56
fix for error:BadHeaderError: Header values can't contain newlines when running get_email. caused by subject_part being repeated, but second time doesnt strip newlines
2017-01-08 18:52:24 +01:00
Pawel M
8f751691a4
whitespace removed
2016-12-16 10:38:15 +01:00
Pawel M
97b3444a92
if files condition restored
2016-12-16 10:36:00 +01:00
Pawel M
fc0ae58420
lib as reduxionist + read binary mode
2016-12-16 10:30:50 +01:00
Pawel M
df7920cd2e
missing imports added
2016-12-14 00:04:38 +01:00
Pawel M
3a372fbcb4
White space removed
2016-12-13 23:40:36 +01:00
Pawel M
9939f62ebd
Attachement should be readed in binary mode ... and attached as payload (regarding docs)
2016-12-13 23:28:16 +01:00
Pawel M
e7c4131ed7
Attachement should be readed in binary mode ... and attached as payload (regarding docs)
2016-12-13 22:43:14 +01:00
Jonathan Barratt
8dbd54ac16
stop corrupting binary attachments when delivering them by email
...
We accomplish this by attching files to out-bound mail diffrently
depending on the versino of Python in effect. In Py2 we can read
the files ourseles and the standard library will still
be able to use the text we pass as if it were bytes. Under Py3,
however, email.message will complain if it doesn't get to decode
the bytes itself, so instead of attaching the contents directly
we just pass the path to the file as a string instead. Unfortunately,
Django 1.8 does not work with this Python 3 approach, due to its
not yet having reverted to the newly improved standard library's
mail-message implementation, and thus requiring us to know more
about the character-encoding/mimetype of the attachment than I've
been able to gather cleanly by this point.
2016-12-13 19:41:13 +07:00
Jonathan Barratt
5acd891c68
refactor all handling of attached files
...
Extract attachment processing from forms, views.staff, and management.command.get_email modules, and consolidate it into a unified lib module function.
Also refactor the affected components, most notably lib.send_templated_email, to make it easier (IMO) to reason about changes to them.
Add unit tests for attachments with UTF-8 filenames, and functional tests for submission of same, as well as ASCII versions, through the public ticket-form.
Remove unused Attachment method "get_upload_to".
2016-12-08 19:47:20 +07:00
Jonathan Barratt
7738bba2ab
remove special-case imports for legacy versions
...
standardise use, or avoidance, of timezone, template from_string, and Context
2016-11-21 10:16:03 +07:00
Alex Barcelo
30e3aa55aa
almost auto-fix on misc files
2016-10-23 22:09:17 +02:00
Alex Barcelo
24d88be8d9
Initial general clean-up of stuff
2016-10-21 17:14:12 +02:00
