Commit Graph

1527 Commits

Author SHA1 Message Date
Ralf Becker
08200bd99c loading ADOdb through composer 2019-02-23 13:10:18 +01:00
nathangray
78028dfbda Api - Set default charset for mail to utf-8, overriding Horde's us-ascii 2019-02-22 10:42:38 -07:00
Alexandros Sigalas
1920814067 Added _folder parameter to getTnefAttachments function 2019-02-22 09:00:07 +01:00
Ralf Becker
6ae2bd4009 * Mail: meeting-request was not shown inside multipart/related 2019-02-21 20:11:21 +01:00
Ralf Becker
5b5525b38f * CardDAV/Addressbook: fix accounts not synced for preference account-selection "groupmembers" 2019-02-21 19:03:32 +01:00
Ralf Becker
8670036af6 * CalDAV: work around Lighning not having synced event before accepting 2019-02-21 17:00:00 +01:00
Ralf Becker
9ff814f5b4 Revert "simpler way to un-reference the rows and some docu why we have to"
This reverts commit f89f08a8ed.
2019-02-20 14:58:04 +01:00
Ralf Becker
f89f08a8ed simpler way to un-reference the rows and some docu why we have to 2019-02-20 14:50:57 +01:00
nathangray
eea03aa47c * Api - Fix redirect loop and use deep copy to keep initial nextmatch rows 2019-02-19 16:41:58 -07:00
Ralf Becker
1d8f2a606b integrate custom-field search in token processing
to allow to use something like: "<regluar-match-token> +<custom-field-match-token>" to return correct entries matching both
also no longer search private custom-fields not accessible by current user (gives a slower query, if private cfs exist)
2019-02-19 16:21:02 +01:00
Ralf Becker
5086e6cca3 * All apps: improved speed when searching with (many) custom-fields 2019-02-18 19:23:13 +01:00
Hadi Nategh
781700ea6d Better approach to query existing contacts 2019-02-18 14:04:53 +01:00
Hadi Nategh
3a51767b67 Try to narrow down search criteria to only email and email_home columns 2019-02-18 12:23:30 +01:00
nathangray
81ddb509a0 Etemplate - Fix initial nextmatch rows not sent to client 2019-02-15 11:53:21 -07:00
Hadi Nategh
39f937fb05 Fix letter avatar for multibyte characters 2019-02-15 17:43:34 +01:00
nathangray
fd8f69db80 Api - Fix leftover $$ when merging empty contact customfields 2019-02-14 09:32:03 -07:00
nathangray
d805e9f467 Stop using deprecated each(), using foreach(), key() or current() instead 2019-02-12 14:13:45 -07:00
Hadi Nategh
a5c1e24a78 Revert commit 34a50af358 2019-02-12 16:10:31 +01:00
Hadi Nategh
34a50af358 Fix broken mail inline links where links contains another url inside their urls. 2019-02-12 15:00:27 +01:00
nathangray
ec04121692 Fix addressbook HTML customfields were stripped of their tags when merging 2019-02-07 10:02:08 -07:00
Hadi Nategh
2405d8f2d3 * Mail: fix not working sending and receiving smime signed messages where certificates have more than 1 domain registered (subjectAltName) 2019-02-06 13:49:11 +01:00
nathangray
a2189e732e Remove unneeded variable 2019-02-04 15:51:14 -07:00
Hadi Nategh
a059628f58 * Mail: take user's cutomfields type of email into account when searching for contacts in Compose -> TO field. 2019-02-01 11:13:43 +01:00
nathangray
3dd671ad8d Changes to support accessing Samba shares with Collabora 2019-01-31 14:42:37 -07:00
Ralf Becker
75b21741b9 * LDAP/AD/UCS: fixed sending mails to groups used as distribution lists 2019-01-30 17:59:52 +01:00
Ralf Becker
685fc58564 allow to get account_id from email for LDAP backend 2019-01-30 17:28:42 +01:00
Hadi Nategh
b3f2d7b102 Revert part of commit 05ce70f1a8 because it breaks codes where result of search function expecting to be an array instead of Db2DataIterator (eg. timesheet) 2019-01-28 12:35:41 +01:00
Ralf Becker
fdfcc15c6b do NOT try to read empty contact_id
it wont find anything anyway, but gives an exception under AD, because of wrong formated GUID
2019-01-28 10:14:55 +01:00
Hadi Nategh
c5c09c4f9f Deprecate CKEDITOR and remove it from source 2019-01-25 12:41:13 +01:00
Ralf Becker
1ed0fd898f fix error: Call to undefined method calendar_ical::get_table_definitions() 2019-01-24 09:10:06 +01:00
nathangray
05ce70f1a8 Fix missing types in admin queue and history 2019-01-23 10:41:52 -07:00
nathangray
65cae1bf8d Api - Fix infinite loop in link if app2 param is not string or array of arrays 2019-01-22 11:49:45 -07:00
nathangray
4008f82be3 Mail - display multiple From addresses 2019-01-22 10:48:39 -07:00
Ralf Becker
508f3f81e2 fix SQL error when ordering by custom-field
as $order_by parameter can contain more then just order by columns, 
eg. group by clause
2019-01-22 17:14:40 +01:00
Hadi Nategh
b2c109ed37 Fix typo 2019-01-22 12:59:15 +01:00
nathangray
91fffd045e * Api - Fix linking into new entries fails with SQL error 2019-01-21 11:22:21 -07:00
Hadi Nategh
32dc0decf5 * Mail: add default value settings for S/MIME passphrase expiration in site configurations 2019-01-18 16:19:08 +01:00
Ralf Becker
668ba6f632 PostgreSQL needs more casts / abstraction to fix SQL error
contact_id/account_id are int, but cal_user_id is varchar
2019-01-18 10:48:36 +01:00
Hadi Nategh
941beda159 Fix cache control not being set for lavatar 2019-01-17 15:56:21 +01:00
Ralf Becker
da4929546a * Addressbook/PostgreSQL: fix SQL error when last/next date column is enabled 2019-01-16 19:46:02 +01:00
Ralf Becker
4b73aee7c8 * All apps: fix linking of filemanager files to entries, if there is no file yet 2019-01-16 18:41:58 +01:00
Hadi Nategh
a9dc895ca6 Set header content type for avatar 2019-01-16 16:48:05 +01:00
Hadi Nategh
8b661df737 Remember recently used folders in vfs select 2019-01-14 17:43:43 +01:00
Ralf Becker
bad2c9e571 fix SQL error for MariaDB 10.3 on inserting 4-byte utf-8 chars
enabling the replacement now uncoditional for MySQL/MariaDB
2019-01-14 12:08:34 +01:00
Ralf Becker
2ace2ff4ed fix PHP Fatal in non EPL: Class 'EGroupware\Api\Api\Framework' not found 2019-01-11 20:56:02 +01:00
nathangray
f8c742cdbb * Preferences - Add 'Firstname Lastname (Primary Group)' and 'Lastname, Firstname (Primary Group)' as account display options 2019-01-09 10:41:36 -07:00
Ralf Becker
bd2dcc293d * Filemanager: treat GoodSync _gsdata_ directory as hidden / not shown by default 2019-01-09 17:55:06 +01:00
Ralf Becker
54bd5eac99 * show maintenance release as version-number everywhere 2019-01-09 10:39:02 +01:00
Ralf Becker
92c22ff529 fix PHP Warning: Use of undefined constant REQUEST_URI 2019-01-08 09:51:43 +01:00
Ralf Becker
26313db8f7 fix not working mail-integration because of "extra logging" tried to convert imap object to a string 2019-01-07 18:49:22 +01:00
Ralf Becker
86ec8ee17d fix TypeError: Argument 6 passed to Nextmatch::call_get_rows() must be an instance of Etemplate\Widget or null
fix calendar edit gives an error when using [Save] button in list-view
2019-01-07 18:13:08 +01:00
Hadi Nategh
4d8a55fb17 Handle VFS full path when generating VFS select contents 2019-01-07 15:05:56 +01:00
nathangray
d21e848883 Turn on some extra info to help figure out cause of 'Illegal offset type' warning 2019-01-04 10:49:55 -07:00
nathangray
089baa12a9 Avoid warning if no external domain preference set 2019-01-04 10:38:09 -07:00
Ralf Becker
fb801dafe3 quiten permanen error_log 2018-12-25 09:32:03 +01:00
nathangray
41b95af046 Commit session right after we get rows from app 2018-12-20 10:03:12 -07:00
Hadi Nategh
490d79f774 Do not touch email addresses when creating a plaintext message 2018-12-20 16:57:46 +01:00
nicorac
a33665e373 Removed source file with clashing filename and a typo in contained class name 2018-12-20 10:00:03 +01:00
Nathan Gray
d40a282f0d
Merge pull request #47 from neomorina/patch-5
Update Taglist.php
2018-12-19 10:04:40 -07:00
nathangray
19ead4c1cc Fix some more PHP 7.2 warnings
Remove some calls to deprecated each()
2018-12-18 09:49:29 -07:00
Hadi Nategh
376be571ba Fix php warning when there's no s/mime recipientsCerts 2018-12-18 14:27:25 +01:00
nathangray
6a6ef64793 Addressbook - add additional config option to only show Last/Next date for contacts 2018-12-17 10:04:20 -07:00
Ralf Becker
339819f406 fixing sometimes too small files caused by last chunk being bigger then other chunks 2018-12-14 16:21:12 +01:00
Ralf Becker
fc2cd455ca setting a bigger chunkSize for resumable to improve upload speed (has to be 2^N!) 2018-12-14 15:16:15 +01:00
Hadi Nategh
e52f3493f1 Prevent select widget from loading when running setup-cli. Fixes travis failure. 2018-12-14 11:15:28 +01:00
Hadi Nategh
40fe3c0ce2 Try fixing loading order by explicitly select widget to load first 2018-12-14 10:43:59 +01:00
Hadi Nategh
213c8343ab Revert commit f8134a3416 2018-12-14 10:00:45 +01:00
nathangray
f8134a3416 Does this make you happy, Travis? 2018-12-13 16:04:18 -07:00
Ralf Becker
35cbfeec09 fix bundles for TinyMCE and added on for messenger 2018-12-12 17:01:49 +01:00
Ralf Becker
b34fc0cfc2 fix not allways working transliteration of utf-8 to ascii
- using now mb_convert_encoding($str, 'html-entities', 'utf-8') if available
- remove all non-ascii as a precausing after all conversions attempts
2018-12-11 17:44:33 +01:00
Hadi Nategh
d2b3effba2 W.I.P. of modern theme with SVG icons enabled 2018-12-11 16:48:15 +01:00
Ralf Becker
01bd78e34a fix PHP 7.3 Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2" 2018-12-11 12:45:50 +01:00
nathangray
68a316fb3f Fix PHP 7.2 warning "PHP Warning: Invalid argument supplied for foreach()" 2018-12-10 09:32:42 -07:00
Ralf Becker
7b69f8cfa5 * Api/Filemanager/WebDAV: fix SQL error if login error or WebDAV path contains non-ascii chars
in that case we transliterate these to ascii for storage in egw_access_log table, which only allows ascii chars
2018-12-10 16:47:16 +01:00
Hadi Nategh
b24d9f9cde Fix missing space and extra spaces in calendar's birthday tooltip 2018-12-10 14:20:35 +01:00
Ralf Becker
a361d05767 making translations a bit more resilient for wrong charset 2018-12-10 10:59:43 +01:00
Ralf Becker
bb2557491d * Api: truncate varchar for all DB types now, as MariaDB 10.3 also errors on to big content 2018-12-09 13:54:35 +01:00
nathangray
4bf653515a Fix PHP 7.2 warning "PHP Warning: Invalid argument supplied for foreach()" 2018-12-06 14:54:57 -07:00
Ralf Becker
b3079c3df6 to long http header cause Nginx to reject the response with 502
upstream sent too big header while reading response header from upstream
2018-12-06 10:56:22 +01:00
Hadi Nategh
0efbbfb75f Fix smime messages stop activesync 2018-12-04 19:16:25 +01:00
nathangray
de58e561a9 API - Make send() extending signature compatible parent 2018-12-03 15:31:12 -07:00
Ralf Becker
e805a02ef3 fix not working sharing if primary DB node has failed 2018-12-03 18:29:05 +01:00
nathangray
314fe706f5 If a single attachment fails, continue with the others instead of failing altogether 2018-12-03 10:19:38 -07:00
nathangray
211a8e5251 Fix PHP 7.2 deprecated each() 2018-11-29 11:00:54 -07:00
nathangray
85a3b3e027 Fix some PHP 7.2 warnings "PHP Warning: count() Parameter must be an array or object ..." 2018-11-29 10:13:49 -07:00
nathangray
ee5d7461fa Handle changes to query that were not there when sent 2018-11-28 14:57:08 -07:00
nathangray
4a8b94bed8 Fix some PHP 7.2 warnings "PHP Warning: Use of undefined constant ..." 2018-11-28 11:11:45 -07:00
nathangray
4b989d016c Log useful error message if select or radio custom field has no values 2018-11-28 11:06:17 -07:00
Hadi Nategh
fd36f854a3 W.I.P. of disableIfNoEPL attribute:
- Implement the same attribute for sidebox menu
- Fix if hideOnDisabled is enabled it will ignore the disableIfNoEPL and it will not show the menu at all
- Adopt addressbook Mail VCard menu
2018-11-27 15:22:50 +01:00
Hadi Nategh
f3ebfacc57 Introduce new action attribute to disable EPL actions via action system 2018-11-27 11:50:23 +01:00
Hadi Nategh
377766293f Fix mail with forwarded attachment may not be shown if there's no name assigned 2018-11-26 17:06:19 +01:00
Ralf Becker
ff7c7326f5 need to use "c" for partial updates, as "r+" requires the file to exits 2018-11-24 08:07:09 +08:00
Ralf Becker
0326f67f90 WIP getting PUT with range-requests working for chunked uploades
eg. for RAI client
With this commit it should work for regular / non-versioned files
2018-11-22 18:50:59 +08:00
Ralf Becker
dd8e9c6269 use full url-encoding for all clients as required by most clients and RFC 2018-11-22 18:15:43 +08:00
Ralf Becker
630c340ce8 * WebDAV: fix encoding for Cyberduck or Mountain Duck clients 2018-11-22 18:15:43 +08:00
Ralf Becker
0ea9d513e5 fix PHP 7.2 Warning count(): Parameter must be an array or an object that implements Countable 2018-11-20 08:09:13 +08:00
nathangray
38939f1f38 Improvements for entry widget for robustness, includes automatic server side tests. 2018-11-15 11:15:35 -07:00
Hadi Nategh
5745919c5a Fix broken tutorial onclick handler 2018-11-14 09:57:40 +01:00
nathangray
5ca429b972 ID reset has to go after parent call, or things break 2018-11-13 15:06:46 -07:00
nathangray
2bf7e14477 Etemplate - add custom field sub-fields for app-entry widgets
- add regex & regex_replace attributes to change value around
2018-11-13 14:11:26 -07:00
Ralf Becker
2f1333a116 return and show in browser JSON parsing errors maybe caused by network problems
server sends HTTP status "400 Bad Request" with JSON payload with "error" and "errno" attributes.
error is json_last_error_msg() prefixed with "JSON ".
Not yet implemented is resending the request (max. twice) for JSON parsing errors to try to work around network problems
2018-11-01 12:00:08 +01:00
Hadi Nategh
2690ec5053 Introduces avatar.php and replaces all addressbook.photo urls accordingly 2018-10-31 13:49:51 +01:00
Ralf Becker
6b633b2c50 fix added extra line in front of content 2018-10-30 15:38:31 +01:00
Ralf Becker
0f80e158ff also set Error/Errno, if database is readonly 2018-10-28 09:29:25 +01:00
Hadi Nategh
9b993e5484 Revert unintentional commit 2018-10-25 18:23:36 +02:00
Hadi Nategh
16fe435de4 W.I.P. implementing TinyMCE editor and deprecating CKEditor:
- Fix language setting
- Update TinyMCE
2018-10-25 18:18:47 +02:00
Hadi Nategh
e60d061183 W.I.P. implementing TinyMCE editor and deprecating CKEditor:
- Fix selector fails when textarea id includes some specific chars
- Fix width and height
2018-10-25 16:16:39 +02:00
Hadi Nategh
b00b37efa8 W.I.P. implementing TinyMCE editor and deprecating CKEditor:
- Fix image upload via old file_selector for etemplate apps
2018-10-25 15:31:41 +02:00
Hadi Nategh
39944322b5 W.I.P. implementing TinyMCE editor and deprecating CKEditor:
- Replace fckEditor with tinymce for old etemplate apps
2018-10-25 12:32:18 +02:00
nathangray
2fc4caec71 * Infolog - Exclude current entry from parent select/search results to avoid loop 2018-10-24 11:11:25 -06:00
Hadi Nategh
7e25284816 W.I.P. implementing TinyMCE editor and deprecating CKEditor:
- Add configurable toolbar as preference
- Do not load CkEditor until it's used
2018-10-24 14:48:19 +02:00
Hadi Nategh
44ef6a0a30 W.I.P. implementing TinyMCE editor and deprecating CKEditor:
- Fix CKEditor widget
- Fix editor doesn't work if no imageUpload is set
2018-10-23 17:10:33 +02:00
Hadi Nategh
345c3c2611 W.I.P. implementing TinyMCE editor and deprecating CKEditor:
- Add d-n-d image upload
2018-10-23 15:50:55 +02:00
Hadi Nategh
f62c5d8ea5 W.I.P. implementing TinyMCE editor and deprecating CKEditor:
- Implement vfs file selector
- Add/remove more actions from toolbar
2018-10-23 13:04:20 +02:00
Hadi Nategh
1cbd0aa2a3 W.I.P. implementing TinyMCE editor and deprecating CKEditor 2018-10-19 16:35:18 +02:00
Ralf Becker
8ae20c34b9 fix PHP Warning: array_shift() expects parameter 1 to be array, null given 2018-10-19 13:55:23 +02:00
Ralf Becker
1d826e798a fix SQLSTATE[42000]: Syntax error or access violation in filemanager
caused by not correctly quoted empty string instead of id in extended ACL
2018-10-19 13:46:06 +02:00
Ralf Becker
180c07e23c fix PHP Warning: A non-numeric value encountered 2018-10-19 09:46:30 +02:00
Ralf Becker
adee0b4c52 fix warning about unknown option 'ro' by filesystem streamwrapper
it is handled by vfs, so ignoring it here
2018-10-18 11:13:04 +02:00
nathangray
9be59b55bf - Accept an extra array from ajax_create
- Filter extra array by db columns
2018-10-15 14:57:24 -06:00
nathangray
289e6079f7 Last / Next date
- Fix list title back to just date
- Link leads to actual recurrence for recurring events
2018-10-12 10:51:46 -06:00
Hadi Nategh
97eb04e75c Fix broken inline images because of wrong url 2018-10-12 16:58:38 +02:00
nathangray
747e0ecda1 - Last / next event date for accounts too
- Fix bug showing deleted events
- Fix bug showing wrong next date if recurring
2018-10-11 17:09:12 -06:00
nathangray
117b559a5e Entry share changes
- Writable share is now a checkbox
- Add Sharing -> Merge entry into email template, share gets selected options
- Add {{share}} placeholder which creates (by default) read only share
2018-10-11 12:54:17 -06:00
nathangray
233832b889 Remove unused title, use Api\DateTime for time conversion 2018-10-10 10:28:28 -06:00
nathangray
16ddefcecf Use custom query for last/next event instead of search 2018-10-09 15:05:35 -06:00
Ralf Becker
9f6a7e3187 fixing no grant required for inviting contacts 2018-10-09 18:59:56 +02:00
nathangray
cb902a3219 Fix complex name finding to handle select options with label & value set, not just simple key => values 2018-10-09 10:20:51 -06:00
Ralf Becker
d8e6c3b919 fix storing and retrieval of urls containing % or %25
- PUT with url containing an encoded % (%25) was stored as is, due to minimal encoding in HTTP_WebDAV_Server class, now this is changed back to store just %
- PROPFIND/REPORT was urldecoding the caldav_name/path, so % as well as %25 were reported as %25
- multiget REPORT was not finding a caldav_name containing %25 reported in PROPFIND as %2525
--> all above is working now and caldav_name with %25 or %2525 can not read via multiget
2018-10-09 18:04:34 +02:00
Ralf Becker
109117316c fix PHP Fatal error: Declaration of EGroupware\Api\CalDAV\Principals::delete(&$options, $id) must be compatible with EGroupware\Api\CalDAV\Handler::delete(&$options, $id, $user) 2018-10-09 13:43:25 +02:00
Ralf Becker
cc22e89242 * CalDAV: CalDAVSynchronizer: only allow owner/organizer to update or delete an event (not users with edit/delete rights) 2018-10-09 13:15:11 +02:00
Ralf Becker
985879b56c remove long decrecated use of <app>/inc/(functions|header).inc.php, giving a PHP Warning because of undefined EGW_APP_INC constant 2018-10-08 12:50:34 +02:00
Ralf Becker
d152738321 fix PHP Warning: Invalid argument supplied for foreach() 2018-10-08 12:48:46 +02:00
nathangray
13598f5342 Prefer most specific select options, if available 2018-10-02 14:19:12 -06:00
Ralf Becker
c950d7b0c1 check if we have a valid template and/or theme on 17.1 update 2018-10-02 12:43:29 +02:00
nathangray
f2cfd94391 Add a keep emails flag (default true), set to false to skip saving merged emails to sent folder 2018-10-01 11:16:17 -06:00
nathangray
20629e2a16 Mail merge - Accept false as folder to skip saving to mail folder 2018-10-01 11:15:31 -06:00
nathangray
dd8fc59d6a * Addressbook - fix birthday cache was not cleared when birthday edited 2018-09-26 11:27:50 -06:00
Hadi Nategh
b7c359a6f1 * Mail: implement new preference to configure mail identity label shown as mail folder header 2018-09-25 15:00:01 +02:00
Hadi Nategh
5615fbf15e Fix commit 4bd103fd7d 2018-09-24 15:00:17 +02:00
Hadi Nategh
475a25b66c Add list of states for more countries 2018-09-24 14:23:58 +02:00
nathangray
4a819f70d4 Move grant cache to class level to ease testing 2018-09-20 11:05:17 -06:00
Ralf Becker
f7d09e9ec0 * CalDAV: work around problems with Outlook CalDAV Synchroniser (https://caldavsynchronizer.org/)
- sends a DELETE to reject a meeting request --> deletes event for all participants, if user has delete rights on the calendar
- always sends all participants back with status NEEDS-ACTION --> resets status of all participant, if user has edit rights
--> remove all add, edit, delete rights from other users
2018-09-20 15:58:00 +02:00
Hadi Nategh
9e1d9e143e * Mail: fix deleting mails from draft folder does not respect "move to trash" in delete message preference 2018-09-20 15:25:11 +02:00
Hadi Nategh
4bd103fd7d Make sure whitespaces are removed from certkey before doing comparison 2018-09-20 14:14:05 +02:00
Hadi Nategh
6c4cc97a5f Implement new taglist widget to represent list of regions of a selected country 2018-09-19 16:43:19 +02:00
nathangray
e805551575 Keep image tags when merging into HTML templates 2018-09-18 10:21:36 -06:00
Hadi Nategh
1c9836f95e Add more regions into country class 2018-09-18 17:04:37 +02:00
Ralf Becker
1eb64136ce fix not working login with permanent redirect to login page: session could not be verified 2018-09-17 15:03:19 +02:00
Ralf Becker
5ceabc8e96 fix parsing of boolean attributes:
- no defaults for disabled/readonly as it defaults depend on readonlys[__ALL__] is set or not
- only cast value to boolean, if it does not contain a variable eg. "!@no_something"
2018-09-17 11:16:38 +02:00
Ralf Becker
e483ec4957 automatic cast and defaults for boolean attributes
Not all attributes are implemented, as many dont play any role on server-side.
Fixes taglist-account multiple="false" returns array(<selected id>)
2018-09-13 14:57:50 +02:00
nathangray
822b967fe3 Better handling of HTML tables when merging.
Fixes table within table broke format parsing.
2018-09-12 16:46:36 -06:00
Ralf Becker
9f3f3e501d fix PHP Warning: Use of undefined constant OPENLDAP_LDAPSERVER 2018-09-12 17:06:31 +02:00
Ralf Becker
a646bc6a61 disabling permanent error_log in favor of $debug attribute 2018-09-12 14:52:34 +02:00
nathangray
9368992032 Fix namespace 2018-09-10 15:26:53 -06:00
Ralf Becker
58703cbaba * Filemanager/SMB: fix directory creation failed on Samba (smbclient PHP extension)
smbclient treats every non-zero value of $options parameter as recursive, not just &1 and we have by default &8 = STREAM_REPORT_ERRORS set.
2018-09-06 12:04:18 +02:00
nathangray
7efefc6e63 Strip UTF-8 BOM from ical file 2018-09-05 13:29:03 -06:00
Hadi Nategh
9b742430c5 Allow single or double quoting as valid personal part of email rfc822 2018-09-04 13:51:10 +02:00
Hadi Nategh
d50f444965 Try to stripe extra quoting from personal part of email address 2018-09-03 16:21:32 +02:00
Hadi Nategh
2f8ba269e3 Revert previous commit, since horde smime verification itself takes care of it with extracting email out of cert 2018-08-30 14:19:00 +02:00
Hadi Nategh
e5bd217a77 * Mail: take certificate SAN email into account when verifying SMIME signed message 2018-08-30 14:06:26 +02:00
nathangray
2cf4904e1e Don't use a static reference to egw->db, it breaks tests 2018-08-29 10:04:25 -06:00
Hadi Nategh
b4b2b9d5d2 Implement an admin-config setting to be able to disable PGP encryption feature 2018-08-23 16:58:14 +02:00
Hadi Nategh
08b9138ae6 Fix tutorials json feed and PGP Installation tutorial video 2018-08-23 14:54:37 +02:00
Neo Morina
8093e6a549
Update Taglist.php
For showing better results.
2018-08-23 11:39:09 +02:00
Ralf Becker
cf10e4af69 make sure Api\Config::read(_repository) always returns an array
even if not configuration is saved yet
2018-08-22 11:24:05 +02:00
Hadi Nategh
698e77e0cb Implement reset user preferences for admin toolbar actions 2018-08-21 17:22:58 +02:00
Ralf Becker
60e953292a adding sel_options to etemplate2_before_exec hook (for policy) 2018-08-17 14:39:28 +02:00
Hadi Nategh
d7c462149a W.I.P. of toolbar admin default prefs:
- Set default preference by admin
- Consider default preference for the first time login users
2018-08-16 16:52:20 +02:00
Hadi Nategh
bf151cff7b W.I.P. of toolbar admin default prefs:
- Add admin settings button
- Add dialog
2018-08-16 12:29:35 +02:00
Hadi Nategh
ccda87b157 W.I.P. of toolbar admin default prefs 2018-08-15 16:50:46 +02:00
Hadi Nategh
c69532e7f0 Another attempt to invalidate zero with space (\u200B) char in the beginning an email address 2018-08-15 11:36:37 +02:00
Hadi Nategh
e433c708df Fix taglist fails to invalidate email address which starts with none visible unicode char 2018-08-14 17:15:35 +02:00
Hadi Nategh
d35a337590 Make an incase sensitive comparison between smime cert email and from email 2018-08-14 16:09:12 +02:00
Ralf Becker
584613f0bf fix somehow created async-job with a next time before the keep time
eg. not updated alarm trigger time in the past
2018-08-13 15:40:53 +02:00
Hadi Nategh
e1ee71873a Implements lavatar and replace default photo avatar with generated lavatar 2018-08-13 11:56:05 +02:00
Hadi Nategh
29337d79d1 Show lavatar text in caps 2018-08-13 11:53:57 +02:00
nathangray
da45cf2776 Avoid warning if filter is null 2018-08-08 09:27:38 -06:00
nathangray
3c5b7c8ba5 * Addressbook - Allow multiselection for customfield added to link title 2018-08-08 09:18:55 -06:00
Ralf Becker
af6c2a0f25 * CalDAV/Calendar: fix not working snozzing of alarms in Thunderbird
Caused by triggered alarms were - so far - immediatly deleted, now we keep them around for an other day, so TB get them in the update iCal after PUTing its X-MOZ-SNOOZE-TIME-<timestampt>
2018-08-07 15:03:59 +02:00
Hadi Nategh
dae7c85b42 Warn user on login page if using browser is IE 11 or below. 2018-08-07 13:40:46 +02:00
Ralf Becker
c579347ad1 allow to identify real changes 2018-08-03 11:56:34 +02:00
Hadi Nategh
024c8ce7fb * Framework: fix broken favicon 2018-08-02 09:52:31 +02:00
Hadi Nategh
7e126290f7 Some more basename replacing with Vfs::basename to avoid setlocale issue. 2018-08-01 11:11:16 +02:00
Hadi Nategh
17cfcf1168 Replace basename with Vfs::basename to avoid setlocale issue. 2018-08-01 10:02:16 +02:00
Hadi Nategh
d89247fdf3 Strip RFC822 email to avoid search contacts other than email itself. Fix issue sometimes add as new contact not showing up because it takes it as existing contact. 2018-07-31 11:06:38 +02:00
nathangray
17ba77d369 Make sure we get correct path when sharing from a share 2018-07-30 12:55:23 -06:00
Ralf Becker
634efff9c4 fix SQL error or information leakage on no longer available custom fields 2018-07-30 15:28:12 +02:00
Ralf Becker
f4081c1443 Revert "* Api - Avoid SQL errors caused by removed custom fields still in favorites"
This reverts commit a03931493f.
2018-07-30 15:28:12 +02:00
nathangray
0098f41a12 Fix missing collabora app 2018-07-26 15:08:32 -06:00
Hadi Nategh
7413b60ecf Do not add edit setting action when we are in sharing view 2018-07-26 14:10:53 +02:00
nathangray
a03931493f * Api - Avoid SQL errors caused by removed custom fields still in favorites 2018-07-25 10:16:46 -06:00
Hadi Nategh
c5e902926b Fix notifications with same id but no links are not getting grouped together 2018-07-23 16:25:07 +02:00
nathangray
82ea4fe2de * Addressbook - add filtering by distribution list for organisations 2018-07-19 14:54:05 -06:00
nathangray
de15acc03d Add div to list of tags that avoid HTML encoding on replacements
Fixes HTML tracker description from external source showing HTML in notifications
2018-07-19 12:50:22 -06:00
nathangray
8092e1fb86 Set current app to filemanager so js loads correctly 2018-07-18 12:27:27 -06:00
Ralf Becker
e6dab124ee * Univention: fix not working password change (setting Kerberos credentials) 2018-07-13 09:58:38 +02:00
Hadi Nategh
677a4a03fb * Tracker: fix issue text part of some html tickets mail notifications contain html parts 2018-07-12 17:47:19 +02:00
Hadi Nategh
dd03c7fe16 * Mail: fix some smime signed messages get recognized wrongly as encrypted 2018-07-04 15:41:43 +02:00
Ralf Becker
18a048e5c8 finish migration AD to new UCS domain via EGroupware 2018-07-03 22:25:08 +02:00
Hadi Nategh
eb5652dc20 * Api: get avatar showing up for taglist accounts and calendar owner 2018-06-29 10:12:59 +02:00
Ralf Becker
a11b9a266b * Addressbook: fix SMime/PGP public key import not containing a newline after the key 2018-06-25 14:23:19 +02:00
Ralf Becker
b29f89cf16 migrate AD accounts incl. mail-attributes to SQL 2018-06-20 15:25:44 +02:00
nathangray
b049a68cb9 Api - Better way to clear recipients between merges that doesn't loose the placeholder 2018-06-18 10:26:49 -06:00
Hadi Nategh
5f3b59fe3d Remove meta tag by HtmLawed 2018-06-18 11:08:46 +02:00
Ralf Becker
7ba77356d5 new "session_created" hook 2018-06-18 09:07:14 +02:00
Hadi Nategh
8f53e3d9f1 * Mail: warn user when there's no space left for storing sieve rules because of sieve_maxscriptsize limit 2018-06-15 15:49:34 +02:00
nathangray
aea2b4d216 * Api - Clear recipients between merges to avoid sending subsequent merges to previous contacts 2018-06-14 11:09:56 -06:00
nathangray
c3b642a39a Allow apps to implement their own Sharing 2018-06-13 14:45:43 -06:00
Ralf Becker
baa2807606 some hooks needed for new policy app 2018-06-12 19:04:02 +02:00
nathangray
d201dc9fd9 Seperate birthday cache by language 2018-06-11 11:26:08 -06:00
nathangray
67d8166b27 Better way to handle an app having more than one etemplate2_before_exec hook - fixes collabora stopped working 2018-06-08 10:26:48 -06:00
nathangray
6708ccb043 Record share emails in history log & display them instead of user when set 2018-06-06 15:51:46 -06:00
nathangray
0582f2347f Fix a few issues from Scrutinizer
- Remove debug code
- Remove some unused variables
- Add get_ui() to base class that gives error message (should always be a subclass)
2018-06-06 09:54:49 -06:00
nathangray
cc21c823dd Handle an app having more than one etemplate2_before_exec hook 2018-06-05 15:34:54 -06:00
nathangray
847d1c6812 Fix some namespace errors 2018-06-05 15:01:09 -06:00
nathangray
ca32d0bc50 Remove unreachable code 2018-06-05 14:59:05 -06:00
nathangray
71ee883210 Entry sharing - handle files checkbox 2018-06-05 14:31:04 -06:00
nathangray
1bd5927869 Pass action back to popup so it knows what to do 2018-06-05 14:31:04 -06:00
nathangray
a1a7570c86 Add method to get sharing context menu actions 2018-06-05 14:31:04 -06:00
nathangray
4a9df7ef33 Got link creation via context menu working 2018-06-05 14:31:04 -06:00
nathangray
a5f5930064 Check record-level permissions 2018-06-05 14:31:04 -06:00
nathangray
d0a50d8d45 Changes needed to just get the screenshots, much more work needed for proper functionallity since I faked the permissions 2018-06-05 14:31:04 -06:00
Ralf Becker
430368eab9 new JSON response method "message" to call egw.message eg. in a popup, by using the context from the egw.json call 2018-06-05 12:29:51 +02:00
nathangray
5d65420a03 Limit subjects for filenames to 200 characters to avoid failures 2018-06-04 10:24:15 -06:00
Ralf Becker
84b715c5af * Admin: allow to show last login, IP and password change in list 2018-06-01 14:46:52 +02:00
Hadi Nategh
f479314e06 Allow apps to load JavaScript or CSS files, knowing we're loading the framework or not 2018-06-01 10:37:38 +02:00
Hadi Nategh
71ae7876d6 Fix namespace issue when calling function 2018-05-29 11:13:12 +02:00
Hadi Nategh
e9f1e8bcad Implement taglist-thumbnail for rest of upload image fields in admin site configuration 2018-05-29 11:05:08 +02:00
Hadi Nategh
6aeb7a5c1e * Admin: Implement new feature to upload multiple images for login background image in site-configuration and show them randomly. 2018-05-28 15:31:32 +02:00
Hadi Nategh
ecb8f84afa Add complementary option for app-select widget in order to be able to exclude specific apps from the list 2018-05-22 14:39:15 +02:00
Ralf Becker
54ee23e731 use error-image from api not old phpgwapi 2018-05-20 13:22:46 +02:00
Hadi Nategh
41a983e317 Make a bigger header size assumption (32k) in order to cover importing mails with big headers 2018-05-14 14:54:44 +02:00
nathangray
5ceea5b93e Slightly more robust checking for "blank" HTML area in case CKEditor adds some styles 2018-05-11 15:00:12 -06:00
nathangray
8030c477c9 Avoid warning about scheme already registered 2018-05-11 11:25:02 -06:00
nathangray
668a4fede8 Api - Turn on merge for presentations, text templates, spreadsheet templates and presentation templates 2018-05-07 13:34:35 -06:00
nathangray
0dea93ac15 Api - Editing files in shared directories & sharing editable links 2018-05-07 10:40:12 -06:00
Ralf Becker
ba366467b0 * Admin/Mail: fix saving mail-accounts for multiple accounts 2018-05-04 15:07:06 +02:00
nathangray
0d52cc293b Throw an exception (that phpunit can catch) rather than exiting on failure so all tests can get 2018-05-03 10:59:22 -06:00
Ralf Becker
b8e230190f * Mail: fixed equal signs (=) are not displayed in subject
Not sure why, but equal sign was removed unconditional together with other non-printable chars.
Equal sign is now removed from that preg and code is cleaned up to have a single preg removing unprintable chars independet on the function used to decode the header.
2018-05-03 11:01:08 +02:00
nathangray
cf4752e8dd Change account filtering to give accounts when asked even if accounts are hidden in preferences 2018-04-26 14:34:09 -06:00
nathangray
6c4ea8cb38 Api - Stop adding calcext:value-type attributes when merging to spreadsheets, they're no longer used and can cause a warning with recent templates 2018-04-23 09:24:49 -06:00
nathangray
48239f3506 Fix mail merge into mail template excluded BCC 2018-04-20 12:00:50 -06:00
Ralf Becker
fa2403f905 * EMail: fix searching in email gives an error
reverting commit 5bd63482ea as the implemented __isset and ArrayAccess interface hide the one implemented by parent Horde_Imap_Client
2018-04-20 10:39:23 +02:00
nathangray
235746e4d6 * Addressbook - Add preference to turn off user groups as distribution lists 2018-04-17 09:35:08 -06:00
Ralf Becker
5bd63482ea implement __isset and ArrayAccess for Imap, to allow eg. to use empty($imap->attribute) 2018-04-17 10:28:37 +02:00
Ralf Becker
753beb06ac fix PHP 7.2 Warning: The each() function is deprecated 2018-04-13 16:08:37 +02:00
Ralf Becker
77b79f24b7 * Setup: updates from old versions (eg. 1.4 or 1.8) no longer require to update to 14.x and 16.1 first 2018-04-13 13:46:49 +02:00
Ralf Becker
f1437d4ccb fixing a couple more PHP Warning count(): Parameter must be an array or an object that implements Countable 2018-04-13 09:12:26 +02:00
Ralf Becker
63d89a3ba0 * Setup/Restore: restore from a other charsets then utf-8 failed 2018-04-12 18:00:27 +02:00
Ralf Becker
81143a0624 * All apps: fixed moving attachments to new entries (without attachments) lost moved file 2018-04-12 15:10:05 +02:00
Ralf Becker
d70304e391 * CalDAV/resources: fix wrong ACL/rights send to clients (PHP warning in log) 2018-04-12 13:03:13 +02:00
Ralf Becker
235821b04a run fastcgi_finish_request also for non-compat install 2018-04-11 15:05:53 +02:00
Ralf Becker
7c1a481d97 fix shutdown functions did not have $GLOBALS[egw] set, caused by session created by MServer 2018-04-11 15:04:48 +02:00
Ralf Becker
ad95a01cec fixing function and test 2018-04-11 14:05:49 +02:00
Ralf Becker
047e68ecd4 limit filesystem depth for managed attachments to gard against infinit recursion 2018-04-11 11:25:53 +02:00
Ralf Becker
bded1bf17e remove 4-byte unicode when cleaning subjects 2018-04-11 11:22:11 +02:00
Ralf Becker
104cae6081 fix smime key got immediatly deleted again 2018-04-10 14:52:14 +02:00
Ralf Becker
5b93dd160c fixing not working links stream-wrapper 2018-04-10 08:54:32 +02:00
nathangray
f26b271067 Exclude symlinks from Vfs 2018-04-09 14:02:24 -06:00
nathangray
abc1ccc8f1 Trying to share a symlink actually uses the link target instead 2018-04-09 14:02:24 -06:00
Ralf Becker
98c7a7af64 fix Scrutinizer issue (seems to be some left over old code) 2018-04-09 16:32:00 +02:00
Ralf Becker
98376b5908 * PHP 7.2: fix several PHP Fatal errors and warnings stalling installation and usage 2018-04-09 16:02:00 +02:00
Hadi Nategh
d9d051a97e Fix move/copy actions in link_to widget vfsSelect try to create not unwanted new symlink 2018-04-04 17:54:30 +02:00
nathangray
1cb13a1f13 * Api - Fix references to sub-fields of custom field entries only merged for the first entry of each type 2018-04-03 15:27:09 -06:00
Hadi Nategh
980b4e1ab2 Make sure mail_bo object is there before using it, fixes error "can not call undefined function reopen()" 2018-04-03 10:33:40 +02:00
nathangray
0a7f81a2e2 Api - Sharing from filesystem:// mounts - with tests even 2018-03-23 13:01:43 -06:00
Hadi Nategh
2943b678bd Fix merge replace placeholders causes huge performance issue. Additionally, fixes the extra $ sign shown up in replaced placeholders. 2018-03-23 16:46:51 +01:00
Ralf Becker
74746a14ef * Sharing/Collabora: fix not working cleanup of temp. files and shares
- 14.x installs had the job created with old class-name egw_sharing
- Wopi shares where never cleaned up, they are now after 3 month
2018-03-22 13:09:59 +01:00
Ralf Becker
1d835928d2 new method Api\Framework::getUrl() to get a full / externally usable Url 2018-03-21 12:51:52 +01:00
Ralf Becker
21e123ef84 do NOT use hostname configured in setup, if it is the default localhost
stick with HTTP Host header in that case
2018-03-21 12:49:31 +01:00
Hadi Nategh
045436609d Get Sharing + Collabora into latest 17.1 version 2018-03-21 12:43:25 +01:00
Hadi Nategh
be4dbc37ae * Fix opening collabora fails from a shared directory:
-we need to have collabora app to avoid CSP error since redirect share-link in collabora should get frame-src. e.g:(Collabora/Src/Ui.php:redirect(Sharing::share2link))
2018-03-16 13:15:45 +01:00
Hadi Nategh
e9b80ecee5 Remove not used csp method 2018-03-16 13:14:16 +01:00
nathangray
3185acb7b1 Add merge into the list to get /apps working again 2018-03-15 16:55:43 -06:00
nathangray
6be5b8f678 Fix editing a file through gave not found error if the symlink was in a versioned directory 2018-03-15 16:55:43 -06:00
Hadi Nategh
65b2588d65 Add missing negation from commit 600872a4bf 2018-03-15 12:24:19 +01:00
Hadi Nategh
600872a4bf An attempt to fix broken collabora sharing which originally got broken by commit f166fbdd46 in order to get mounted template sharing fixed. 2018-03-14 18:58:30 +01:00
Ralf Becker
dcb78d9776 remove due to own table in 17.1 no longer needed migration of (private) custome-fields 2018-03-14 14:50:46 +01:00
Hadi Nategh
eb1eed5b8d Implement new feature for vfs-select widget to accept extra buttons action. Additionally, add extra "copy" and "move" actions to link-to vfs dialog. 2018-03-13 17:43:21 +01:00
Ralf Becker
ddd4127ee7 * AD/LDAP migration: change favorites and index states too 2018-03-12 21:22:12 +01:00
nathangray
357e5a3326 Re-init static streamwrapper, as some of them look at permissions or preferences 2018-03-12 13:51:04 -06:00
Ralf Becker
c2c1bdb6ad * EMail/Tracker/InfoLog: fix error converting mails by replacing 4-byte utf8 chars
MySQL and MariaDB before 10.1 need 4-byte utf8 chars replaced with our default utf8 charset
(MariaDB 10.1 does the replacement automatic, 10.0 cuts everything off behind and MySQL gives an error)
Changing charset to utf8mb4 requires schema update, shortening of some indexes and probably have negative impact on performace!
		if (substr($this->Type, 0, 5) == 'mysql' && $this->ServerInfo['version'] < 10.1)
		{
			$value = preg_replace('/[\x{10000}-\x{10FFFF}]/u', "\xEF\xBF\xBD", $value);
		}
2018-03-12 14:02:13 +01:00
Ralf Becker
163c87db82 * Api: use proxy configuration when downloading available tutorial videos 2018-03-12 11:16:57 +01:00
Hadi Nategh
fbf63bf65c Fix tutorials.json url to use https 2018-03-12 11:08:09 +01:00
Ralf Becker
32d10dd243 Fix not working textbox validators containing backslashes
PHP xml parser reads backslashes literal from attributes, 
while JavaScript ones need them escaped (eg. like PHP strings)
-> replace \\ with \ to get following XML working: validator="/^\\d+$"
2018-03-10 17:55:12 +01:00
Ralf Becker
e578e64926 ActiveDirectory: additional allow accountExpires=0 for never expires
(beside attribute is not set or has value 9223372036854775807)
2018-03-09 19:51:49 +01:00
nathangray
223b55d631 Api - Allow sharing to use Collabora to open files instead of downloading 2018-03-07 11:29:00 -07:00
Hadi Nategh
d2859d5cee * Mail: Fix "tel:" href links wrongly get denied by mail compose 2018-03-05 18:16:12 +01:00
Hadi Nategh
53b97078ad Fix mail with a bold digits gets removed from text part 2018-03-05 17:31:47 +01:00
Hadi Nategh
dca72ebd9c Fix broken sharing caused by commit 89a8e6f448 2018-03-05 11:13:54 +01:00
nathangray
9a51ad9211 API - Avoid issue with incompatable types by forcing to array, even if no account found 2018-03-02 10:21:43 -07:00
Hadi Nategh
63dd5ce96b Make sure replace only and only VT char (Vertical Tab) 2018-03-02 12:13:13 +01:00
Ralf Becker
205cf9c588 replace non-utf8 chars in content send to browser with utf8 replacement char
before we were removing the whole string
2018-03-01 17:38:45 +01:00
Ralf Becker
f800ab008b if we can not store failed login attempts in database, store it in cache 2018-02-28 18:01:32 +01:00
Ralf Becker
a799abb0a0 * All apps: multiselect custom-field switches to single select after submit 2018-02-28 13:41:13 +01:00
Ralf Becker
c1e8ac6324 Switching consistent hashing (Libketama) off by default
as for just 2 Memcached servers it creates an extrem unbalanced 
distribution favoring the 2. server and has no benefits,
as requests to the failed node can only go to the other one anyway.
2018-02-28 10:45:48 +01:00
Ralf Becker
8b88e748f7 * Admin: new config to generate no or lowercase email addresses for new users 2018-02-20 09:15:42 +01:00
nathangray
816db05496 Use abstraction to determine mime type, see 9a398594ac 2018-02-15 10:16:04 -07:00
nathangray
89a8e6f448 Place check on session first to avoid errors if it's missing 2018-02-15 09:19:26 -07:00
Ralf Becker
e3c67a1c63 fix PHP Warning if keys contain a backslash as in namespaced classes 2018-02-15 09:52:24 +01:00
nathangray
9c29079ddf Silence warning about time in array format by passing it to constructor 2018-02-14 08:38:48 -07:00
Ralf Becker
f4927d7e0b * Filemanager/Sharing: fix PHP 7.1 error causing auth request to popup
Session only stores app-names and $GLOBALS[egw_info][user][apps] gets restored from $GLOBALS[egw_info][apps] for the allowed app-names. Check if we need to restore from installed apps array was using is_array($GLOBALS[egw_info][user][apps][api]) instead or isset($GLOBALS[egw_info][user][apps][0]), as check if it is a real, non associative array
2018-02-14 09:03:14 +01:00
nathangray
f166fbdd46 * Api - Fix sharing from mounted shares failed with 404 2018-02-13 15:10:34 -07:00
nathangray
c67560049c * Api - Check if email address is known before offering 'Add as contact' button 2018-02-08 13:19:26 -07:00
Hadi Nategh
4e0be8a887 Allow custom theme for mobile template 2018-02-08 10:10:15 +01:00
nathangray
a8ffe5ab05 * Api - Fix some spelling errors, reported by Stefan Unverricht 2018-02-07 13:30:55 -07:00
Hadi Nategh
034b17a49a Implement new user preference in order to be able to select a handler for opening a merge print document 2018-02-07 13:15:29 +01:00
Ralf Becker
d934f33ea6 also fixing preg for email with optional domain part 2018-02-05 19:13:01 +01:00
Ralf Becker
75a39143f8 fixing the fix, now "email.@domain.com" is invalied, but "x@domain.com" is valid 2018-02-05 16:06:46 +01:00
Ralf Becker
6efe719ea1 one letter name-part in email address failed validation, eg. "x@egroupware.org" 2018-02-05 15:32:00 +01:00
nathangray
f07dbf7439 Attempt to prefer user's date format when parsing date from a string.
Should fix merging into spreadsheet problems with certain date formats (dd/mm/yyyy)
2018-02-02 11:37:30 -07:00
Hadi Nategh
1494d1a6e9 * Addressbook: Fix avatar photo gets removed when adding category to contact via contextmenu 2018-01-31 16:10:48 +01:00
nathangray
cf2b759054 * Admin - fix group list filter & sort
- Remove created & modified columns since they're not stored for groups
- Fix email sort
- Fix search returned all results
2018-01-30 11:28:27 -07:00
nathangray
9a398594ac * Etemplate - Don't trust browsers mime if we don't have to - fixes incorrect mime types and Resources rejecting pictures 2018-01-30 09:14:52 -07:00
Ralf Becker
20cde78af3 allow user & password again as in http://user:pass@example.com/ to fix tests 2018-01-30 16:54:43 +01:00
Ralf Becker
a9ee58cfad allow private IP addresses (starting with 10.|169.254.|192.168.) too 2018-01-30 16:19:35 +01:00
Ralf Becker
bff3b0215e * LDAP/ActiveDirectory: fix sorting accounts by anything other then account-name fails 2018-01-29 12:47:57 +01:00
Ralf Becker
37957a49f4 update/add support options in setup and about EGroupware page 2018-01-29 10:20:18 +01:00
nathangray
be93c24def Make sure popup notifications are fully in recipient's language
"Message from" and "Linked entries" were in sender's language
2018-01-25 15:40:25 -07:00
nathangray
670b74cf23 Fix wiki links did not load properly after login if your session was expired 2018-01-24 10:28:34 -07:00
Ralf Becker
034eddb37e * Mail: fix invalid domain name in headers stall whole mailbox
Horde_Idna::decode() and Horde_Mime_Headers::toArray() throws Horde_Idna_Exception for invalid domain names in email addresses like "test@-domain.com", which stall display of whole folder
2018-01-23 12:58:35 +01:00
Ralf Becker
3dadd5b14b fix call to protected method EGroupware\Api\Mail::clean_subject_for_filename() from context mail_integration 2018-01-23 09:31:54 +01:00
nathangray
e13bd2ed63 Mail - Reorganize and use same cleaning function when saving mail as infolog as for saving to VFS 2018-01-22 09:13:19 -07:00
Ralf Becker
79ee97a22c allow to sepecify last security release for multiple major versions 2018-01-21 10:27:40 +01:00
Hadi Nategh
5e94600677 *Mail: Fix sharing of attached files as download links in compose dialog exposes all folders as readonly shares 2018-01-17 16:32:21 +01:00
nathangray
f402561d7d Better tests for Customfields, fix a couple of permission bugs revealed
Found a problems when requesting 'all' custom fields, it would still use current user permissions
2018-01-12 10:03:34 -07:00
nathangray
3709d773d9 * Allow private custom fields in notifications, with filtering according to set permissions. Private custom fields are removed from notifications to non-users. 2018-01-10 10:43:43 -07:00
Ralf Becker
57b92c29de
Merge pull request #32 from stefanwerfling/patch-1
Update autoload.php
2017-12-23 12:27:53 +07:00
nathangray
a9b616fa20 * API - Make sure private custom fields are not accidentally included in notification due to being cached 2017-12-21 11:26:51 -07:00
stefanwerfling
bfabaa52eb
Update autoload.php
- add interface exist check for interface loading by vendor classes
2017-12-21 19:19:03 +01:00
Hadi Nategh
a3b903b75c * Mail: Fix empty trash/empty junk actions causes error in some mail servers, e.g. Cyrus. 2017-12-15 13:33:04 +01:00
Hadi Nategh
9b639b1fe0 Fix collabora can not open vfs symlinks from apps 2017-12-13 10:10:04 +01:00
Hadi Nategh
d52ede97c5 * Mail: fix vacation notice still sending out notification mail even if the original mail is a spam. 2017-12-08 13:54:11 +01:00
Ralf Becker
2cec97a6c5 replace from PostgreSQL not understood && with standard AND 2017-12-07 17:28:00 +08:00
Ralf Becker
4a13fb4c21 * All apps/PostgreSQL: fix SQL error when deleting an entry without attachments 2017-12-07 17:16:46 +08:00
Ralf Becker
93353a55c0 * Filemanager/PostgreSQL: cant open file in Collabora because of SQL error
Syntax error: 7 ERROR: syntax error at or near "=“, PostgreSQL needs true/false not 1/0
2017-12-07 16:45:01 +08:00
Hadi Nategh
594bd63181 * Mail/Admin: Fix upload picture into mail signature from editor image browser does not work. 2017-12-06 16:25:43 +01:00
nathangray
ced6c63ddd Fix historylog pagination, found by Filippos Karailanidis 2017-12-05 15:13:30 -07:00
Nathan Gray
fade7185ae
Merge pull request #31 from filkaris/history_rows
Historylog widget: Ability to set nextmatch num_rows
2017-12-05 08:40:30 -07:00
nathangray
6506418e61 * Api - Fix nested custom field merging 2017-12-01 11:58:44 -07:00
nathangray
2df24a3aaf Add flag for select all to collabora action 2017-12-01 10:36:58 -07:00
Hadi Nategh
90a5e91fc7 * Addressbook: fix bug setting Hide User Account in preferences into Show all accounts breaks show accounts 2017-12-01 14:58:44 +01:00
A Sigalas
e9de76af7a Set option for num_rows 2017-12-01 11:04:31 +00:00
Hadi Nategh
a93722959b Use filemanager_select for old etemplate apps 2017-12-01 11:05:32 +01:00
nathangray
e88afc07d0 * Addressbook - fix SQL error with accounts hidden + Organisation by location / department
- Fix accounts missing if no preference for hide accounts set
2017-11-29 09:12:05 -07:00
Ralf Becker
dd4ae60fa2 fix avatar/files update issues 2017-11-29 09:58:36 +08:00
Hadi Nategh
95d1911528 Fix error Call to a member function setDate() on boolean 2017-11-27 18:05:47 +01:00
nathangray
b04eb80b39 Addressbook - fix show/hide account preference bugs
- account filter was missing for show active
- preference changed to match current value
2017-11-21 11:07:50 -07:00
Hadi Nategh
1ecfab062a Fix list of favorites in VfsSelect contains previous selected contents as well 2017-11-20 17:49:46 +01:00
Hadi Nategh
7e6bcc035f Make favorites available as an individual button in VfsSelect dialog 2017-11-20 17:01:50 +01:00
nathangray
b47777422b Make prefix argument optional 2017-11-16 09:56:20 -07:00
Hadi Nategh
1f998f1612 Fix attempting to open a document link in infolog pops collabora link even the user has no permission to the collabora app 2017-11-16 16:31:22 +01:00
nathangray
867c661796 Fix missing fields in merge if info_contact is not a addressbook entry 2017-11-15 15:41:12 -07:00
nathangray
c8369f9b39 Addressbook - fix hide accounts preference did not work for duplicate & organisation views
- Added a new preference option to hide only deactivated accounts
2017-11-15 11:29:10 -07:00
nathangray
ddd45ccc2e Mail - stop additional mail in sent folder when merging multiple contacts into email 2017-11-14 17:00:17 -07:00
Ralf Becker
b408c8b464 allow to specify a date-format in custom-fields using eg. format=Ymd, as it was possible in 11.1 in len field 2017-11-10 17:31:05 +01:00
Nathan Gray
43927f0bd5
Merge pull request #29 from neomorina/patch-2
Made some changes at egw_actions
2017-11-10 08:56:55 -07:00
Nathan Gray
a4608d64d7
Merge pull request #28 from neomorina/patch-1
Add MIME Type "text/csv" when "pagerepeat" found
2017-11-10 08:50:47 -07:00
Ralf Becker
3055190ea7 * CalDAV/CardDAV: fix encoding of control chars stalling iOS sync
eg. \xb is not allowed in XML and caused iOS sync to stall, as it's XML parser fails
use htmlspecialchars option ENT_XML1|ENT_DISALLOWED (PHP 5.4+) to ensure proper XML encoding
2017-11-10 15:49:30 +01:00
Ralf Becker
e5ddf8d6b6 allow to migrate accounts from ADS to SQL 2017-11-09 15:27:50 +01:00
Neo Morina
85866c6ef6
Made some changes at egw_actions
This is a usefull for opening "second level results" as a popup.
"Second level results" couldn't get opened as a popup at Project Manager app when i try to add a new Project as Template at the selected Project.
2017-11-09 14:43:49 +01:00
Neo Morina
653a0d50c7
Added MIME Type "text/csv" when "pagerepeat" found
This gives the possibility to use "pagerepeat" in CSV files.
2017-11-09 13:16:06 +01:00
Hadi Nategh
861d714724 Fix vfsSelect does not show any content for the first load 2017-11-09 10:25:35 +01:00
nathangray
7c65127e64 Mail - Also include HTML version of email in integration data (for apps that can handle it) 2017-11-08 13:11:46 -07:00
Ralf Becker
ff3ae9815d never invalidate session in sharing, as we cant regenerate it (and we dont need to) 2017-11-07 13:02:39 +01:00
Ralf Becker
719b2ff834 also log if _check_script_tag was able to disarm XSS automatic 2017-11-07 12:23:11 +01:00
Ralf Becker
cfe9204f77 allow sql fragments in Api\Storage\Base::delete as in other places 2017-11-06 16:43:23 +01:00
Ralf Becker
790fa8c71d allow sql fragments in Api\Storage\Base::delete as in other places 2017-11-06 16:24:30 +01:00
Ralf Becker
0d99d129dc deny sharing owner rights (chmod, chgrp, set eACL) and disable eACL tab 2017-11-06 14:52:12 +01:00
nathangray
dda47ca863 Disable extended ACL for readonly shares 2017-11-03 10:28:27 -06:00
Ralf Becker
4ebf79d0e1 * Sharing/Collabora: allow to use Collabora on writable shares (EPL only) 2017-11-03 12:43:09 +01:00
nathangray
ef7956f34b Make sure lang gets passed on to registration 2017-11-02 11:13:29 -06:00
nathangray
069d49afba Disable copy / paste for readonly shares 2017-11-02 09:43:08 -06:00
Ralf Becker
3689b3d645 * Filemanager/Sharing: deny rename, move, mkdir and rmdir on readonly share 2017-11-02 13:34:10 +01:00
Hadi Nategh
3465c40b50 Remove unsafe-eval CSP for CKEditor 2017-11-02 11:02:16 +01:00
Ralf Becker
0813403b5b * All apps: get sharing working with files attached to application entries 2017-10-31 10:51:59 +01:00
Ralf Becker
b9594ea357 fix typo 2017-10-31 10:49:12 +01:00
Ralf Becker
b5574da397 remove system call used for PHP < 5.3.1 2017-10-31 09:55:23 +01:00
Ralf Becker
a4526c98cb store CalDAV/CardDAV log in user spezific log directories 2017-10-30 15:00:42 +01:00
nathangray
616c11c1fb Fix wrong table name 2017-10-27 17:48:42 +02:00
nathangray
0d14155472 Fix minimum fs_id was not returning proper value 2017-10-27 17:43:40 +02:00
nathangray
90ce0cc7b6 Add a function to get the lowest fs_id for a path 2017-10-27 17:43:40 +02:00
Ralf Becker
12dbfca137 check cookies for XSS attempts 2017-10-27 16:52:34 +02:00
nathangray
5750904809 Fix setlocale to be able to find locales on Ubuntu 2017-10-27 10:54:39 +02:00
Ralf Becker
5b573abef7 do not allow path traversal and htmlencode displayed path 2017-10-26 13:16:52 +02:00
nathangray
fdb47ab168 Merge calendar events into user account if there is one over user contact 2017-10-26 09:16:02 +02:00
Ralf Becker
77b42dd9a4 always send X-Content-Type-Options: nosniff
It does not harm and stops unpredictable results from browsers changing our content-types
(FF 50+ now also supports nosniff)
2017-10-25 17:35:30 +02:00
Hadi Nategh
fdb3202b6b Add new config to the admin site configuration in order to be able to upload a custom header logo 2017-10-23 13:23:52 +02:00
nathangray
b8f8a014fa Move all tests under api/src into api/tests 2017-10-23 10:14:14 +02:00
nathangray
24de1dff3b Move PHPUnit tests from test to tests subdirectory 2017-10-23 09:51:28 +02:00
Ralf Becker
c88e6e0237 disabling E_DEPRECATED, as contrib apps wont work under PHP 7.1 with having eg. contructors with same name as the class 2017-10-21 12:03:10 +02:00
nathangray
d3c596a443 - Add a parameter to pass in the class of the notification to use so we can pass in a test one
- Explicitly tell notification what type of message (plain or html) we're giving it
2017-10-21 11:29:05 +02:00
Hadi Nategh
ff4396030a Fix CKEditor Browse Server button to open vfsSelect 2017-10-20 18:55:22 +02:00
nathangray
accd6187e2 Get date widget duration test working again 2017-10-20 09:56:47 +02:00
nathangray
9e6ecce1d0 Move tests into app/tests subdirectory (not app/inc/test or app/test) 2017-10-18 18:30:54 +02:00
nathangray
237d81ce36 Move tests into app/tests subdirectory (not app/inc/test or app/test) 2017-10-18 15:43:35 +02:00
nathangray
865fd6405d Move sanity check to a pre-condition check 2017-10-18 11:47:28 +02:00
Ralf Becker
1d7fb9fe90 improve check $GLOBALS[egw] is correctly initilized 2017-10-18 09:10:39 +02:00
nathangray
cd49f6568d Replace the lost boolean cast 2017-10-17 16:48:35 +02:00
nathangray
88a3f3b1d4 Run test in UTC, so dates match our expectations 2017-10-17 15:40:05 +02:00
nathangray
6fad74c710 Fix test had no assertions 2017-10-17 13:29:17 +02:00
nathangray
8b1a8d38f5 Revert db10b21fa7 2017-10-17 12:48:46 +02:00
nathangray
db10b21fa7 Fix child actions under 'More...' did not inherit the inheritable attributes 2017-10-13 11:13:17 -06:00
nathangray
63a3940d68 Addressbook - adjust calendar event participants to match when merging contacts 2017-10-13 09:35:36 -06:00
Hadi Nategh
052bef84ce W.I.P vfsSelect Widget:
- Fix upload feature not working
2017-10-13 13:22:45 +02:00
Hadi Nategh
5b76210218 W.I.P vfsSelect Widget:
- Fix mime types not being shown
- Fix name being displayed encoded in save2vfs mail
2017-10-12 17:45:46 +02:00
Hadi Nategh
2c721c95b2 W.I.P. VFS Select Widget:
- Add name and dialog_title as new attributes
- Fix SaveToVfs, SaveAttachmentToVfs, SaveAllToVfs in mail
- Fix button tile
2017-10-12 13:19:42 +02:00
Hadi Nategh
448cc8975f W.I.P of VFS Select widget restructure 2017-10-11 18:27:42 +02:00
Hadi Nategh
de65d91dc7 Rmove fields for none private cutomfields when name refers to a single custom field 2017-10-06 16:27:37 +02:00
nathangray
0183635c02 Add permission check for collabora before setting actions to open in editor 2017-10-05 09:55:06 -06:00
Ralf Becker
6a3a944828 fix uncaught exception if Collabora is not configured or reachable 2017-10-05 11:00:38 +02:00
nathangray
1868b40359 Set up merge to open editable documents if collabora is there 2017-10-04 14:15:47 -06:00
nathangray
285eb8494b Addressbook - Merging contacts now keeps all distribution lists, and it works now 2017-09-27 09:00:46 -06:00
Ralf Becker
1ae0f29f01 return "400 Bad Request" if propfind contains invalid elements or more then one 2017-09-26 19:13:05 +02:00
nathangray
2d57801c6a * Addressbook - Merging contacts now keeps all distribution lists 2017-09-26 11:05:34 -06:00
Hadi Nategh
a4fdc052ab Filemanager "New" actions:
- Add "New" actions into nm header as drop down list
- Re-arrange actions in contextmenu
- Let Etemplate modifies sel_options if extra changes are available
2017-09-26 18:43:18 +02:00
Hadi Nategh
6407379388 Accept localhost as a valid url 2017-09-26 11:37:37 +02:00
Ralf Becker
a6ec69169d document and enhance function signaure for server-side callback of file and vfs-upload widget
also make it usable for vfs-upload widget with it's id containing entry's id
2017-09-21 11:33:40 +02:00
nathangray
2876a2838c Adjust 'Group' account search keyword so even if someone searches for 'Group', we still respect the 'type' parameter and only return user accounts if that was what was requested. 2017-09-20 09:27:39 -06:00
Ralf Becker
48554590f4 * Addressbook: store S/Mime & PGP pubkey and photo (SQL backend only) in filesystem 2017-09-19 11:38:48 +02:00
Ralf Becker
23e654ab89 fix IDE warnings 2017-09-19 11:38:48 +02:00
nathangray
5b4fd418bf Etemplate - change select multiple validation to also consider rows > 1 to enable multiple 2017-09-14 09:19:26 -06:00
nathangray
e0eb181373 Test for overriding Horde's translations with our own 2017-09-13 17:10:48 -06:00
nathangray
27fab7c259 Etemplate - keep child after instanciating 2017-09-08 12:43:28 -06:00
nathangray
1b36ecb962 Etemplate - fix a testing bug giving false positives 2017-09-08 11:49:28 -06:00
nathangray
f9e09953d1 Etemplate - clear other set limits to avoid conflicts with other tests 2017-09-08 11:42:22 -06:00
nathangray
43f6acdf72 Etemplate - enhance email regex to avoid trailing dots in address, comment out some other checks we might not care about 2017-09-08 11:39:33 -06:00
nathangray
cc1fff6c17 Etemplate - add a URL regex to catch some invalids that were making it through 2017-09-08 11:10:57 -06:00
nathangray
12ae214b76 Etemplate - fix bug where min / max could not be 0 2017-09-08 10:30:19 -06:00
nathangray
4d68048929 Etemplate - fix causing false negatives in textbox regex text 2017-09-08 09:51:55 -06:00
nathangray
2006b1f372 Etemplate - fix some bugs in min/max validation 2017-09-08 09:51:06 -06:00
nathangray
0b3cbdeae5 Etemplate - some basic selectbox tests 2017-09-08 09:00:37 -06:00
nathangray
0ead3713e2 Etemplate url widget tests 2017-09-08 09:00:37 -06:00
nathangray
c656d13a4c Silence log of validation errors 2017-09-08 09:00:37 -06:00
nathangray
d75372368a Etemplate url-email widget tests 2017-09-08 09:00:37 -06:00
Hadi Nategh
36991cb80b S/MIME:
- Encode saved mail into sent folder with ENCODE_7bit to avoid any changes.
- Fix signed mails in sent folder not being correctly verified after.
2017-09-04 12:39:58 +02:00
Hadi Nategh
4d8efd0c4a S/MIME:
- Add public key of sender into recipient keys while encrypting a message.
This make encrypted mails in sent folder readable by sender as well.
2017-09-04 11:43:33 +02:00
Hadi Nategh
ee092b0d5a S/MIME:
- Rephrase warning message for reading encrypted mails with no relevant 
pubkey and privkey
- If no mimeType provided set it to default type from mime object
2017-09-04 10:20:04 +02:00
Hadi Nategh
f4dd4bbf96 S/MIME:
- Reveal more info about signer and certificate
2017-09-01 11:38:39 +02:00
Hadi Nategh
1a8e584e0c S/MIME:
- Fix PGP signed messages get shown as red
- Fix attachments area always gets displayed
2017-08-31 17:33:33 +02:00
Hadi Nategh
914d6b2a52 S/MIME:
- Make sure content of p12 file contained \0 chars at the end stored in credentials will not get trimmed.
2017-08-31 11:40:02 +02:00
Ralf Becker
c886d567f9 share token could still contain "+", which Vfs::encodePathComponent was not encoding
fixes some files not opening in Collabora
2017-08-30 18:16:15 +02:00
Hadi Nategh
3f06a89db5 S/MIME:
- Store full binary (pkcs12) certificate into credentials
- Extract cacert from pkcs12 and feed it into signing process
- Implement p12 export
2017-08-30 17:00:28 +02:00
Ralf Becker
b785766331 * LDAP/Mail: fix new accounts did not automatic enable mail account
Thanks to Lagrange, Joseph Fernando for the fix.
2017-08-29 20:08:43 +02:00
Hadi Nategh
f788f001d0 Fix broken mail compose 2017-08-29 11:38:08 +02:00
nathangray
495d67d5d0 Testing max & min on date widget 2017-08-28 11:44:30 -06:00
Hadi Nategh
8fd6325c3d S/MIME:
- Override send function in mailer object to be able to use additional options of part->send
- Fix Signed html message gets not working
2017-08-28 19:24:51 +02:00
Hadi Nategh
74bfeade9e S/MIME:
- Fix waring about openssl CA's bundle path
2017-08-28 16:24:56 +02:00
Hadi Nategh
4b9b5aa7e4 S/MIME:
- Add password remember option for smime_passphrase dialog in compose
2017-08-28 16:14:56 +02:00