Commit Graph

1375 Commits

Author SHA1 Message Date
Ralf Becker
c9cc1f2e63 fix PHP Warning if keys contain a backslash as in namespaced classes 2018-02-15 09:56:39 +01:00
nathangray
a1a43afe53 * Api - Fix sharing from mounted shares failed with 404 2018-02-14 10:30:23 -07:00
Ralf Becker
cf722f6d01 * Filemanager/Sharing: fix PHP 7.1 error causing auth request to popup
Session only stores app-names and $GLOBALS[egw_info][user][apps] gets restored from $GLOBALS[egw_info][apps] for the allowed app-names. Check if we need to restore from installed apps array was using is_array($GLOBALS[egw_info][user][apps][api]) instead or isset($GLOBALS[egw_info][user][apps][0]), as check if it is a real, non associative array
2018-02-14 09:47:32 +01:00
Ralf Becker
d2479a71f8 Changelog for 17.1.20180209 2018-02-09 11:12:29 +00:00
Ralf Becker
fc42b3474d pending DE and SK translation from Stefan Unvericht 2018-02-09 12:06:22 +01:00
Hadi Nategh
1570633761 Add some translations and adopt link list widget to take editor opener handler preference into account 2018-02-08 14:25:58 +01:00
Hadi Nategh
9d5ddc84e2 * Filemanager: Add an user preference for being able to chose whether opening a merge print document should download it or open it with collabora editor 2018-02-08 14:24:05 +01:00
Hadi Nategh
06ef14c78e * Filemanager: Add new user preference in order to be able to exclude specific file extensions from being opened by document editor (eg. Collabora) 2018-02-08 14:15:51 +01:00
Hadi Nategh
0bbbad3a8c Allow custom theme for mobile template 2018-02-08 10:31:23 +01:00
nathangray
e9d29852ad * Api - Fix some spelling errors, reported by Stefan Unverricht 2018-02-07 13:31:50 -07:00
Ralf Becker
56f9c9478d also fixing preg for email with optional domain part 2018-02-05 19:13:49 +01:00
nathangray
8231f44ce2 Attempt to prefer user's date format when parsing date from a string.
Should fix merging into spreadsheet problems with certain date formats (dd/mm/yyyy)
2018-02-05 10:11:59 -07:00
Ralf Becker
f2c4ccd1b0 fixing the fix again: removing check from client side
We can not use "(?<![.\s])", used to check that name-part does not end in
a dot or white-space. The expression is valid in recent Chrome, but fails
eg. in Safari 11.0 or node.js 4.8.3 and therefore grunt uglify!
Server-side will fail in that case because it uses the full regexp.
2018-02-05 17:02:14 +01:00
Ralf Becker
f203fa3eb2 fixing the fix, now "email.@domain.com" is invalied, but "x@domain.com" is valid 2018-02-05 16:07:46 +01:00
Ralf Becker
5668f9b04a one letter name-part in email address failed validation, eg. "x@egroupware.org" 2018-02-05 15:35:41 +01:00
Hadi Nategh
189de3ddda * Addressbook: Fix avatar photo gets removed when adding category to contact via contextmenu 2018-01-31 18:25:40 +01:00
Ralf Becker
886655597c Changelog for 17.1.20180130 2018-01-30 16:34:48 +00:00
Ralf Becker
a23be28d97 allow user & password again as in http://user:pass@example.com/ to fix tests 2018-01-30 17:03:38 +01:00
Ralf Becker
4d35e42eeb allow private IP addresses (starting with 10.|169.254.|192.168.) too 2018-01-30 16:20:43 +01:00
nathangray
c1e03779ff Switch phrase to one already translated, make confirmation dialog a little wider 2018-01-29 16:32:41 -07:00
nathangray
782deb84f1 Fix wiki links did not load properly after login if your session was expired 2018-01-29 08:43:39 -07:00
Ralf Becker
a17f2fc0b7 update/add support options in setup and about EGroupware page 2018-01-29 12:50:58 +01:00
Ralf Becker
30645713c6 * LDAP/ActiveDirectory: fix sorting accounts by anything other then account-name fails 2018-01-29 12:49:33 +01:00
Ralf Becker
ee68f41be2 using PHP_BINARY constant instead of - sometimes not set - $_SERVER['_'] 2018-01-26 14:17:07 +01:00
Ralf Becker
f28fbb06fa make NM lettersearch lettes translatable via phrase "ABCDEFGHIJKLMNOPQRSTUVWXYZ" 2018-01-24 10:11:55 +01:00
Ralf Becker
297ff61523 * Mail: fix invalid domain name in headers stall whole mailbox
Horde_Idna::decode() and Horde_Mime_Headers::toArray() throws Horde_Idna_Exception for invalid domain names in email addresses like "test@-domain.com", which stall display of whole folder
2018-01-23 13:01:52 +01:00
Ralf Becker
a291fbeac6 fix call to protected method EGroupware\Api\Mail::clean_subject_for_filename() from context mail_integration 2018-01-23 09:29:25 +01:00
nathangray
e3ad2ebdf0 Mail - Reorganize and use same cleaning function when saving mail as infolog as for saving to VFS 2018-01-22 09:18:16 -07:00
Ralf Becker
b26c82bae6 allow to sepecify last security release for multiple major versions 2018-01-21 10:29:03 +01:00
Ralf Becker
178b476aad Changelog for 17.1.20180118 2018-01-18 09:06:55 +00:00
Hadi Nategh
7e1b5602f1 * Mail: Fix a security issue when sharing of attached files as download links in compose dialog exposes all folders as readonly shares 2018-01-17 17:56:09 +01:00
nathangray
aae5094797 * Allow private custom fields in notifications, with filtering according to set permissions. Private custom fields are removed from notifications to non-users. 2018-01-15 12:52:33 -07:00
nathangray
001821175b * API - Make sure private custom fields are not accidentally included in notification due to being cached 2018-01-15 12:52:15 -07:00
nathangray
80b00ee78c Update resumable file library, fix bug breaking drag & drop from filesystem in Firefox 2018-01-15 08:48:13 -07:00
Hadi Nategh
929676793c Fix a bug notifications sidebar in client-side not being translated 2018-01-12 16:32:20 +01:00
Neo Morina
e47ecfbe82 Made some changes at egw_actions
This is a usefull for opening "second level results" as a popup.
"Second level results" couldn't get opened as a popup at Project Manager app when i try to add a new Project as Template at the selected Project.
2018-01-11 10:27:28 -07:00
Hadi Nategh
757c58acc9 Add proper icon for vfsSelect submit button 2018-01-04 12:03:11 +01:00
Ralf Becker
f296889dda Changelog for 17.1.20171218 2017-12-20 06:11:08 +00:00
nathangray
335b3d2f9e Etemplate - make sure nextmatch action popups get properly closed 2017-12-18 14:52:06 -07:00
Ralf Becker
be8b18cf90 allow to specify a date-format in custom-fields using eg. format=Ymd, as it was possible in 11.1 in len field 2017-12-18 14:42:22 +01:00
nathangray
d055f04f96 Etemplate - add 'format' option to timestamper to specify the time format 2017-12-18 14:37:04 +01:00
Hadi Nategh
92ea34ea5b Merge pull request #26 from filkaris/link-type
Add hook option in case user wants link to display another link
2017-12-18 12:31:24 +01:00
Hadi Nategh
ba07b10032 Revert "Make selectbox tags&search available for nextmatch header filter"
This reverts commit 28f4155360.
2017-12-18 12:30:15 +01:00
Hadi Nategh
28f4155360 Make selectbox tags&search available for nextmatch header filter 2017-12-18 12:15:36 +01:00
Hadi Nategh
b8c27d3370 Make sure the appname is from the current window 2017-12-18 12:13:36 +01:00
Hadi Nategh
6c6518b445 * Mail/Admin: Fix upload picture into mail signature from editor image browser does not work. 2017-12-18 12:07:49 +01:00
Hadi Nategh
e6c50537f9 Add more translations, thanks to Stefan Unverricht 2017-12-18 10:43:16 +01:00
Hadi Nategh
9fdd6d6d5a Fix vfsSelect dialog does not preserve the name field on reload 2017-12-18 09:59:59 +01:00
nathangray
32296f45fa Fix typo breaking the setting of autocomplete params 2017-12-15 10:31:21 -07:00
Hadi Nategh
d5ac9b90a8 * Mail: Fix empty trash/empty junk actions causes error in some mail servers, e.g. Cyrus. 2017-12-15 15:25:16 +01:00
Hadi Nategh
aeec7a869f Fix collabora can not open vfs symlinks from apps 2017-12-13 10:17:45 +01:00
nathangray
08f0073361 Add flag for select all to collabora action 2017-12-11 11:22:32 -07:00
Hadi Nategh
80576f7956 * Mail: fix vacation notice still sending out notification mail even if the original mail is a spam. 2017-12-08 13:54:54 +01:00
Ralf Becker
db6e6b376f replace from PostgreSQL not understood && with standard AND 2017-12-07 17:28:54 +08:00
Ralf Becker
42ea57c124 * All apps/PostgreSQL: fix SQL error when deleting an entry without attachments 2017-12-07 17:21:26 +08:00
Ralf Becker
c3c385e1f4 * Filemanager/PostgreSQL: cant open file in Collabora because of SQL error
Syntax error: 7 ERROR: syntax error at or near "=“, PostgreSQL needs true/false not 1/0
2017-12-07 16:47:42 +08:00
Hadi Nategh
18b21c0aef Fixes for broken select-account:
- Fix select account dialog Ok button not working
- Fix selecting a searched account in dialog not working
- Fix broken search dialog
2017-12-06 14:23:48 +01:00
nathangray
c1faf8329d Fix historylog pagination, found by Filippos Karailanidis 2017-12-05 15:21:06 -07:00
Hadi Nategh
a1b8198d42 * Tracker: Fix broken tracker queue selectbox filter 2017-12-05 12:18:03 +01:00
Hadi Nategh
77d27f6d72 Make sure the options are typeof array or object 2017-12-04 18:49:31 +01:00
nathangray
e2a6052058 * Api - Fix nested custom field merging 2017-12-01 11:59:28 -07:00
Hadi Nategh
2b72f759ff * Addressbook: fix bug setting Hide User Account in preferences into Show all accounts breaks show accounts 2017-12-01 17:07:42 +01:00
Hadi Nategh
1effbd6b7f Use filemanager_select for old etemplate apps 2017-12-01 11:07:35 +01:00
nathangray
0650989615 * Etemplate - fix bug preventing Shift + Select until you refresh the app 2017-11-30 10:22:06 -07:00
Ralf Becker
386b71fd63 Changelog for 17.1.20171130 2017-11-30 09:21:56 +00:00
nathangray
442db88174 Fix various missing translations, found by Stefan Unverricht 2017-11-30 10:12:55 +01:00
nathangray
5455b97664 * Addressbook - fix SQL error with accounts hidden + Organisation by location / department
- Fix accounts missing if no preference for hide accounts set
2017-11-30 10:10:34 +01:00
Ralf Becker
b55f6f0900 Changelog for 17.1.20171129 2017-11-29 11:08:10 +00:00
nathangray
e8758c9cd6 Some style fixes:
- Missing icons in several dialogs
- Change nextmatch dialog action to use et2_dialog
2017-11-29 11:27:57 +01:00
Ralf Becker
13d28a3da4 * Addressbook: fix lost picture in upload 2017-11-29 10:12:48 +01:00
Ralf Becker
a049b86324 fix avatar/files update issues 2017-11-29 10:12:32 +01:00
nathangray
e6931f76ee Translate months too 2017-11-28 09:12:01 -07:00
nathangray
94512e47ed Translate days of the week 2017-11-28 09:11:53 -07:00
nathangray
4a85f3c338 Fix missing fields in merge if info_contact is not a addressbook entry 2017-11-28 09:09:39 -07:00
nathangray
e5851f9249 Fix select all disables multi-entry actions 2017-11-28 09:08:31 -07:00
Hadi Nategh
a7fcb77d1b Fix error Call to a member function setDate() on boolean 2017-11-27 18:06:27 +01:00
Ralf Becker
cc894bdcc2 fix stalled update if jpegphoto is empty string (and not null) 2017-11-23 21:56:01 +08:00
nathangray
039de1e355 Better handling of target to support custom fields, now switches to the target tab 2017-11-22 10:18:26 -07:00
nathangray
257edc3aa7 Addressbook - fix show/hide account preference bugs
- account filter was missing for show active
- preference changed to match current value
2017-11-22 08:42:37 -07:00
nathangray
cfb34b05bf Addressbook - fix hide accounts preference did not work for duplicate & organisation views
- Added a new preference option to hide only deactivated accounts
2017-11-22 08:42:28 -07:00
nathangray
f43ddba7bc Avoid error if this.input is not yet set 2017-11-22 10:40:15 +01:00
nathangray
6d300827a9 - Fix typo
- Fix value not re-set after changing select options if value was ''
2017-11-21 08:44:21 -07:00
nathangray
cd661ed3ba Mail - stop additional mail in sent folder when merging multiple contacts into email 2017-11-21 08:43:40 -07:00
Hadi Nategh
8bf0763c1f Fix list of favorites in VfsSelect contains previous selected contents as well 2017-11-20 17:50:21 +01:00
Hadi Nategh
6d51130cc6 Make favorites available as an individual button in VfsSelect dialog 2017-11-20 17:02:31 +01:00
Hadi Nategh
6d378b8e73 Fix attempting to open a document link in infolog pops collabora link even the user has no permission to the collabora app 2017-11-20 10:18:12 +01:00
nathangray
ad617c0b8f Etemplate - implement DetachedDOM interface on read-only checkbox, fixes set for every row bug in nextmatch 2017-11-16 11:15:36 -07:00
nathangray
357f6ae65f Mail - Also include HTML version of email in integration data (for apps that can handle it) 2017-11-15 08:50:33 -07:00
Ralf Becker
595e767f20 Changelog for 17.1.20171115 2017-11-14 16:08:48 +00:00
nathangray
1237dbf2a8 Fix nextmatch returned null for getDOMNode() if no sender provided
This caused it to appear hidden to etemplate print()
2017-11-14 08:48:17 -07:00
Hadi Nategh
6261d55e38 * Addressbook: Fix avatar icon is doubled if contact has no avatar set 2017-11-13 12:18:04 +01:00
Ralf Becker
0e40bd7cb5 * CalDAV/CardDAV: fix encoding of control chars stalling iOS sync
eg. \xb is not allowed in XML and caused iOS sync to stall, as it's XML parser fails
use htmlspecialchars option ENT_XML1|ENT_DISALLOWED (PHP 5.4+) to ensure proper XML encoding
2017-11-10 15:50:28 +01:00
Ralf Becker
628e7596d3 allow to migrate accounts from ADS to SQL 2017-11-09 15:28:37 +01:00
Hadi Nategh
a4ebc6e814 Remove special file drop handling on CKEditor for IE, it's no longer necessary. Fix issue of drop none image file on compose HTML area uploads the file twice. 2017-11-09 15:02:37 +01:00
Hadi Nategh
6b0a8a1b5d Fix vfsSelect does not show any content for the first load 2017-11-09 10:26:49 +01:00
Ralf Becker
1b5e992f43 allow sql fragments in Api\Storage\Base::delete as in other places 2017-11-08 11:45:40 +01:00
Ralf Becker
8fdffab564 allow sql fragments in Api\Storage\Base::delete as in other places 2017-11-08 11:45:24 +01:00
Ralf Becker
464f1b3894 never invalidate session in sharing, as we cant regenerate it (and we dont need to) 2017-11-07 13:03:30 +01:00
Ralf Becker
1222ef1813 also log if _check_script_tag was able to disarm XSS automatic 2017-11-07 12:24:15 +01:00
Hadi Nategh
0ec79af82f Fix mime handler for sharing 2017-11-07 10:51:40 +01:00
Ralf Becker
5d1217b89b deny sharing owner rights (chmod, chgrp, set eACL) and disable eACL tab 2017-11-06 15:19:19 +01:00
Ralf Becker
3b2375e34f Changelog for 17.1.20171106 2017-11-05 09:16:19 +00:00
Ralf Becker
f21b13090f pending translations from our translation server 2017-11-04 09:36:02 +01:00
nathangray
df4f4deb1f Etemplate - Make sure to not return an empty string, it will fail when queried 2017-11-03 14:37:46 -06:00
nathangray
06e41356bd Better handling for thumbnail tooltip if not in nextmatch row 2017-11-03 13:07:02 -06:00
nathangray
dda47ca863 Disable extended ACL for readonly shares 2017-11-03 10:28:27 -06:00
Hadi Nategh
873a2a93d8 Allow multiple mime types 2017-11-03 15:05:35 +01:00
Ralf Becker
4ebf79d0e1 * Sharing/Collabora: allow to use Collabora on writable shares (EPL only) 2017-11-03 12:43:09 +01:00
nathangray
ef7956f34b Make sure lang gets passed on to registration 2017-11-02 11:13:29 -06:00
nathangray
069d49afba Disable copy / paste for readonly shares 2017-11-02 09:43:08 -06:00
Ralf Becker
3689b3d645 * Filemanager/Sharing: deny rename, move, mkdir and rmdir on readonly share 2017-11-02 13:34:10 +01:00
Ralf Becker
3a24416eb9 suppress notice screwing up thumbmails, if notices are on 2017-11-02 13:23:36 +01:00
Hadi Nategh
3465c40b50 Remove unsafe-eval CSP for CKEditor 2017-11-02 11:02:16 +01:00
A Sigalas
df6898a11c Add discard image to buttons 2017-11-01 11:59:11 +00:00
Ralf Becker
0813403b5b * All apps: get sharing working with files attached to application entries 2017-10-31 10:51:59 +01:00
Ralf Becker
b9594ea357 fix typo 2017-10-31 10:49:12 +01:00
Ralf Becker
b5574da397 remove system call used for PHP < 5.3.1 2017-10-31 09:55:23 +01:00
Ralf Becker
a4526c98cb store CalDAV/CardDAV log in user spezific log directories 2017-10-30 15:00:42 +01:00
nathangray
616c11c1fb Fix wrong table name 2017-10-27 17:48:42 +02:00
nathangray
0d14155472 Fix minimum fs_id was not returning proper value 2017-10-27 17:43:40 +02:00
nathangray
90ce0cc7b6 Add a function to get the lowest fs_id for a path 2017-10-27 17:43:40 +02:00
Hadi Nategh
f42801236a Override the globalEval to mitigate potential execution of script tag 2017-10-27 17:42:44 +02:00
Ralf Becker
12dbfca137 check cookies for XSS attempts 2017-10-27 16:52:34 +02:00
nathangray
5750904809 Fix setlocale to be able to find locales on Ubuntu 2017-10-27 10:54:39 +02:00
Ralf Becker
92584a61ad * Update: fix not finishing update for more then 100 photos in addressbook
caused by contact_jpegphoto was not set to NULL, as column no longer exists in tables_current
2017-10-26 21:27:16 +02:00
Ralf Becker
5b573abef7 do not allow path traversal and htmlencode displayed path 2017-10-26 13:16:52 +02:00
nathangray
fdb47ab168 Merge calendar events into user account if there is one over user contact 2017-10-26 09:16:02 +02:00
Ralf Becker
77b42dd9a4 always send X-Content-Type-Options: nosniff
It does not harm and stops unpredictable results from browsers changing our content-types
(FF 50+ now also supports nosniff)
2017-10-25 17:35:30 +02:00
Ralf Becker
d11fe532d8 Changelog for 17.1.20171023 2017-10-23 17:27:18 +00:00
Hadi Nategh
fdb3202b6b Add new config to the admin site configuration in order to be able to upload a custom header logo 2017-10-23 13:23:52 +02:00
nathangray
b381a9aa0c Timestamp widget fixes:
- Remove new line before timestamp
- Fix focus not going to where it should
2017-10-23 12:10:45 +02:00
Hadi Nategh
c88e3b8a69 Disable new button and new action in filemanager when there's no writable right 2017-10-23 12:08:33 +02:00
nathangray
b8f8a014fa Move all tests under api/src into api/tests 2017-10-23 10:14:14 +02:00
nathangray
24de1dff3b Move PHPUnit tests from test to tests subdirectory 2017-10-23 09:51:28 +02:00
Ralf Becker
65b02c0246 bump verison to 17.1 2017-10-22 12:56:58 +02:00
Ralf Becker
c88e6e0237 disabling E_DEPRECATED, as contrib apps wont work under PHP 7.1 with having eg. contructors with same name as the class 2017-10-21 12:03:10 +02:00
nathangray
d3c596a443 - Add a parameter to pass in the class of the notification to use so we can pass in a test one
- Explicitly tell notification what type of message (plain or html) we're giving it
2017-10-21 11:29:05 +02:00
nathangray
b8f4af5602 Documentation update from the move of tests into app/tests subdirectory (not app/inc/test or app/test) 2017-10-21 11:29:05 +02:00
Hadi Nategh
ff4396030a Fix CKEditor Browse Server button to open vfsSelect 2017-10-20 18:55:22 +02:00
nathangray
31c007bac7 Give a better message if the test table is missing (Check test app not installed) 2017-10-20 10:20:49 +02:00
nathangray
accd6187e2 Get date widget duration test working again 2017-10-20 09:56:47 +02:00
nathangray
9e6ecce1d0 Move tests into app/tests subdirectory (not app/inc/test or app/test) 2017-10-18 18:30:54 +02:00
nathangray
237d81ce36 Move tests into app/tests subdirectory (not app/inc/test or app/test) 2017-10-18 15:43:35 +02:00
nathangray
865fd6405d Move sanity check to a pre-condition check 2017-10-18 11:47:28 +02:00
Ralf Becker
3ae16b20e6 added test app in fixtures 2017-10-18 11:42:03 +02:00
Ralf Becker
1d7fb9fe90 improve check $GLOBALS[egw] is correctly initilized 2017-10-18 09:10:39 +02:00
nathangray
cd49f6568d Replace the lost boolean cast 2017-10-17 16:48:35 +02:00
nathangray
88a3f3b1d4 Run test in UTC, so dates match our expectations 2017-10-17 15:40:05 +02:00
nathangray
6fad74c710 Fix test had no assertions 2017-10-17 13:29:17 +02:00
nathangray
8b1a8d38f5 Revert db10b21fa7 2017-10-17 12:48:46 +02:00