Commit Graph

1318 Commits

Author SHA1 Message Date
nathangray
c1faf8329d Fix historylog pagination, found by Filippos Karailanidis 2017-12-05 15:21:06 -07:00
Hadi Nategh
a1b8198d42 * Tracker: Fix broken tracker queue selectbox filter 2017-12-05 12:18:03 +01:00
Hadi Nategh
77d27f6d72 Make sure the options are typeof array or object 2017-12-04 18:49:31 +01:00
nathangray
e2a6052058 * Api - Fix nested custom field merging 2017-12-01 11:59:28 -07:00
Hadi Nategh
2b72f759ff * Addressbook: fix bug setting Hide User Account in preferences into Show all accounts breaks show accounts 2017-12-01 17:07:42 +01:00
Hadi Nategh
1effbd6b7f Use filemanager_select for old etemplate apps 2017-12-01 11:07:35 +01:00
nathangray
0650989615 * Etemplate - fix bug preventing Shift + Select until you refresh the app 2017-11-30 10:22:06 -07:00
Ralf Becker
386b71fd63 Changelog for 17.1.20171130 2017-11-30 09:21:56 +00:00
nathangray
442db88174 Fix various missing translations, found by Stefan Unverricht 2017-11-30 10:12:55 +01:00
nathangray
5455b97664 * Addressbook - fix SQL error with accounts hidden + Organisation by location / department
- Fix accounts missing if no preference for hide accounts set
2017-11-30 10:10:34 +01:00
Ralf Becker
b55f6f0900 Changelog for 17.1.20171129 2017-11-29 11:08:10 +00:00
nathangray
e8758c9cd6 Some style fixes:
- Missing icons in several dialogs
- Change nextmatch dialog action to use et2_dialog
2017-11-29 11:27:57 +01:00
Ralf Becker
13d28a3da4 * Addressbook: fix lost picture in upload 2017-11-29 10:12:48 +01:00
Ralf Becker
a049b86324 fix avatar/files update issues 2017-11-29 10:12:32 +01:00
nathangray
e6931f76ee Translate months too 2017-11-28 09:12:01 -07:00
nathangray
94512e47ed Translate days of the week 2017-11-28 09:11:53 -07:00
nathangray
4a85f3c338 Fix missing fields in merge if info_contact is not a addressbook entry 2017-11-28 09:09:39 -07:00
nathangray
e5851f9249 Fix select all disables multi-entry actions 2017-11-28 09:08:31 -07:00
Hadi Nategh
a7fcb77d1b Fix error Call to a member function setDate() on boolean 2017-11-27 18:06:27 +01:00
Ralf Becker
cc894bdcc2 fix stalled update if jpegphoto is empty string (and not null) 2017-11-23 21:56:01 +08:00
nathangray
039de1e355 Better handling of target to support custom fields, now switches to the target tab 2017-11-22 10:18:26 -07:00
nathangray
257edc3aa7 Addressbook - fix show/hide account preference bugs
- account filter was missing for show active
- preference changed to match current value
2017-11-22 08:42:37 -07:00
nathangray
cfb34b05bf Addressbook - fix hide accounts preference did not work for duplicate & organisation views
- Added a new preference option to hide only deactivated accounts
2017-11-22 08:42:28 -07:00
nathangray
f43ddba7bc Avoid error if this.input is not yet set 2017-11-22 10:40:15 +01:00
nathangray
6d300827a9 - Fix typo
- Fix value not re-set after changing select options if value was ''
2017-11-21 08:44:21 -07:00
nathangray
cd661ed3ba Mail - stop additional mail in sent folder when merging multiple contacts into email 2017-11-21 08:43:40 -07:00
Hadi Nategh
8bf0763c1f Fix list of favorites in VfsSelect contains previous selected contents as well 2017-11-20 17:50:21 +01:00
Hadi Nategh
6d51130cc6 Make favorites available as an individual button in VfsSelect dialog 2017-11-20 17:02:31 +01:00
Hadi Nategh
6d378b8e73 Fix attempting to open a document link in infolog pops collabora link even the user has no permission to the collabora app 2017-11-20 10:18:12 +01:00
nathangray
ad617c0b8f Etemplate - implement DetachedDOM interface on read-only checkbox, fixes set for every row bug in nextmatch 2017-11-16 11:15:36 -07:00
nathangray
357f6ae65f Mail - Also include HTML version of email in integration data (for apps that can handle it) 2017-11-15 08:50:33 -07:00
Ralf Becker
595e767f20 Changelog for 17.1.20171115 2017-11-14 16:08:48 +00:00
nathangray
1237dbf2a8 Fix nextmatch returned null for getDOMNode() if no sender provided
This caused it to appear hidden to etemplate print()
2017-11-14 08:48:17 -07:00
Hadi Nategh
6261d55e38 * Addressbook: Fix avatar icon is doubled if contact has no avatar set 2017-11-13 12:18:04 +01:00
Ralf Becker
0e40bd7cb5 * CalDAV/CardDAV: fix encoding of control chars stalling iOS sync
eg. \xb is not allowed in XML and caused iOS sync to stall, as it's XML parser fails
use htmlspecialchars option ENT_XML1|ENT_DISALLOWED (PHP 5.4+) to ensure proper XML encoding
2017-11-10 15:50:28 +01:00
Ralf Becker
628e7596d3 allow to migrate accounts from ADS to SQL 2017-11-09 15:28:37 +01:00
Hadi Nategh
a4ebc6e814 Remove special file drop handling on CKEditor for IE, it's no longer necessary. Fix issue of drop none image file on compose HTML area uploads the file twice. 2017-11-09 15:02:37 +01:00
Hadi Nategh
6b0a8a1b5d Fix vfsSelect does not show any content for the first load 2017-11-09 10:26:49 +01:00
Ralf Becker
1b5e992f43 allow sql fragments in Api\Storage\Base::delete as in other places 2017-11-08 11:45:40 +01:00
Ralf Becker
8fdffab564 allow sql fragments in Api\Storage\Base::delete as in other places 2017-11-08 11:45:24 +01:00
Ralf Becker
464f1b3894 never invalidate session in sharing, as we cant regenerate it (and we dont need to) 2017-11-07 13:03:30 +01:00
Ralf Becker
1222ef1813 also log if _check_script_tag was able to disarm XSS automatic 2017-11-07 12:24:15 +01:00
Hadi Nategh
0ec79af82f Fix mime handler for sharing 2017-11-07 10:51:40 +01:00
Ralf Becker
5d1217b89b deny sharing owner rights (chmod, chgrp, set eACL) and disable eACL tab 2017-11-06 15:19:19 +01:00
Ralf Becker
3b2375e34f Changelog for 17.1.20171106 2017-11-05 09:16:19 +00:00
Ralf Becker
f21b13090f pending translations from our translation server 2017-11-04 09:36:02 +01:00
nathangray
df4f4deb1f Etemplate - Make sure to not return an empty string, it will fail when queried 2017-11-03 14:37:46 -06:00
nathangray
06e41356bd Better handling for thumbnail tooltip if not in nextmatch row 2017-11-03 13:07:02 -06:00
nathangray
dda47ca863 Disable extended ACL for readonly shares 2017-11-03 10:28:27 -06:00
Hadi Nategh
873a2a93d8 Allow multiple mime types 2017-11-03 15:05:35 +01:00
Ralf Becker
4ebf79d0e1 * Sharing/Collabora: allow to use Collabora on writable shares (EPL only) 2017-11-03 12:43:09 +01:00
nathangray
ef7956f34b Make sure lang gets passed on to registration 2017-11-02 11:13:29 -06:00
nathangray
069d49afba Disable copy / paste for readonly shares 2017-11-02 09:43:08 -06:00
Ralf Becker
3689b3d645 * Filemanager/Sharing: deny rename, move, mkdir and rmdir on readonly share 2017-11-02 13:34:10 +01:00
Ralf Becker
3a24416eb9 suppress notice screwing up thumbmails, if notices are on 2017-11-02 13:23:36 +01:00
Hadi Nategh
3465c40b50 Remove unsafe-eval CSP for CKEditor 2017-11-02 11:02:16 +01:00
A Sigalas
df6898a11c Add discard image to buttons 2017-11-01 11:59:11 +00:00
Ralf Becker
0813403b5b * All apps: get sharing working with files attached to application entries 2017-10-31 10:51:59 +01:00
Ralf Becker
b9594ea357 fix typo 2017-10-31 10:49:12 +01:00
Ralf Becker
b5574da397 remove system call used for PHP < 5.3.1 2017-10-31 09:55:23 +01:00
Ralf Becker
a4526c98cb store CalDAV/CardDAV log in user spezific log directories 2017-10-30 15:00:42 +01:00
nathangray
616c11c1fb Fix wrong table name 2017-10-27 17:48:42 +02:00
nathangray
0d14155472 Fix minimum fs_id was not returning proper value 2017-10-27 17:43:40 +02:00
nathangray
90ce0cc7b6 Add a function to get the lowest fs_id for a path 2017-10-27 17:43:40 +02:00
Hadi Nategh
f42801236a Override the globalEval to mitigate potential execution of script tag 2017-10-27 17:42:44 +02:00
Ralf Becker
12dbfca137 check cookies for XSS attempts 2017-10-27 16:52:34 +02:00
nathangray
5750904809 Fix setlocale to be able to find locales on Ubuntu 2017-10-27 10:54:39 +02:00
Ralf Becker
92584a61ad * Update: fix not finishing update for more then 100 photos in addressbook
caused by contact_jpegphoto was not set to NULL, as column no longer exists in tables_current
2017-10-26 21:27:16 +02:00
Ralf Becker
5b573abef7 do not allow path traversal and htmlencode displayed path 2017-10-26 13:16:52 +02:00
nathangray
fdb47ab168 Merge calendar events into user account if there is one over user contact 2017-10-26 09:16:02 +02:00
Ralf Becker
77b42dd9a4 always send X-Content-Type-Options: nosniff
It does not harm and stops unpredictable results from browsers changing our content-types
(FF 50+ now also supports nosniff)
2017-10-25 17:35:30 +02:00
Ralf Becker
d11fe532d8 Changelog for 17.1.20171023 2017-10-23 17:27:18 +00:00
Hadi Nategh
fdb3202b6b Add new config to the admin site configuration in order to be able to upload a custom header logo 2017-10-23 13:23:52 +02:00
nathangray
b381a9aa0c Timestamp widget fixes:
- Remove new line before timestamp
- Fix focus not going to where it should
2017-10-23 12:10:45 +02:00
Hadi Nategh
c88e3b8a69 Disable new button and new action in filemanager when there's no writable right 2017-10-23 12:08:33 +02:00
nathangray
b8f8a014fa Move all tests under api/src into api/tests 2017-10-23 10:14:14 +02:00
nathangray
24de1dff3b Move PHPUnit tests from test to tests subdirectory 2017-10-23 09:51:28 +02:00
Ralf Becker
65b02c0246 bump verison to 17.1 2017-10-22 12:56:58 +02:00
Ralf Becker
c88e6e0237 disabling E_DEPRECATED, as contrib apps wont work under PHP 7.1 with having eg. contructors with same name as the class 2017-10-21 12:03:10 +02:00
nathangray
d3c596a443 - Add a parameter to pass in the class of the notification to use so we can pass in a test one
- Explicitly tell notification what type of message (plain or html) we're giving it
2017-10-21 11:29:05 +02:00
nathangray
b8f4af5602 Documentation update from the move of tests into app/tests subdirectory (not app/inc/test or app/test) 2017-10-21 11:29:05 +02:00
Hadi Nategh
ff4396030a Fix CKEditor Browse Server button to open vfsSelect 2017-10-20 18:55:22 +02:00
nathangray
31c007bac7 Give a better message if the test table is missing (Check test app not installed) 2017-10-20 10:20:49 +02:00
nathangray
accd6187e2 Get date widget duration test working again 2017-10-20 09:56:47 +02:00
nathangray
9e6ecce1d0 Move tests into app/tests subdirectory (not app/inc/test or app/test) 2017-10-18 18:30:54 +02:00
nathangray
237d81ce36 Move tests into app/tests subdirectory (not app/inc/test or app/test) 2017-10-18 15:43:35 +02:00
nathangray
865fd6405d Move sanity check to a pre-condition check 2017-10-18 11:47:28 +02:00
Ralf Becker
3ae16b20e6 added test app in fixtures 2017-10-18 11:42:03 +02:00
Ralf Becker
1d7fb9fe90 improve check $GLOBALS[egw] is correctly initilized 2017-10-18 09:10:39 +02:00
nathangray
cd49f6568d Replace the lost boolean cast 2017-10-17 16:48:35 +02:00
nathangray
88a3f3b1d4 Run test in UTC, so dates match our expectations 2017-10-17 15:40:05 +02:00
nathangray
6fad74c710 Fix test had no assertions 2017-10-17 13:29:17 +02:00
nathangray
8b1a8d38f5 Revert db10b21fa7 2017-10-17 12:48:46 +02:00
Hadi Nategh
9504bff8ee Fix wrong dialog title for link-to widget 2017-10-17 11:28:03 +02:00
Hadi Nategh
13635fb5b7 Restrict vfsSelectUI submit only to the field availability 2017-10-16 15:03:16 +02:00
Hadi Nategh
81edd22253 Get the right application base on current window context 2017-10-16 11:23:14 +02:00
Hadi Nategh
f779f5ac7f Make sure we get the etemplate_exec_id 2017-10-16 09:34:38 +02:00
nathangray
db10b21fa7 Fix child actions under 'More...' did not inherit the inheritable attributes 2017-10-13 11:13:17 -06:00
nathangray
63a3940d68 Addressbook - adjust calendar event participants to match when merging contacts 2017-10-13 09:35:36 -06:00
Hadi Nategh
1460945a03 Add status text for upload button in VfsSelect widget 2017-10-13 14:52:38 +02:00
Hadi Nategh
7922f41499 Fix file widget readonly is being set correctly 2017-10-13 14:51:45 +02:00
Hadi Nategh
052bef84ce W.I.P vfsSelect Widget:
- Fix upload feature not working
2017-10-13 13:22:45 +02:00
Hadi Nategh
08032dd776 W.I.P vfsSelect Widget:
- Make the dialog bigger
2017-10-12 18:27:27 +02:00
Hadi Nategh
5b76210218 W.I.P vfsSelect Widget:
- Fix mime types not being shown
- Fix name being displayed encoded in save2vfs mail
2017-10-12 17:45:46 +02:00
Hadi Nategh
9154392163 Find the right image 2017-10-12 17:06:17 +02:00
Hadi Nategh
2c721c95b2 W.I.P. VFS Select Widget:
- Add name and dialog_title as new attributes
- Fix SaveToVfs, SaveAttachmentToVfs, SaveAllToVfs in mail
- Fix button tile
2017-10-12 13:19:42 +02:00
Ralf Becker
4e9ad744cc move use strict out of global scope so it does not affect minifying / concatination 2017-10-12 11:32:18 +02:00
Hadi Nategh
88e5524b79 W.I.P. VFS Select Widget:
- Remove extra label of File Name
- Fix tooltip messages get overlaid by the dialog
2017-10-12 10:49:20 +02:00
Hadi Nategh
4b90a12551 W.I.P. VFS Select Widget: Fix upload button drops into second line 2017-10-12 10:22:17 +02:00
Hadi Nategh
b17a348c1f VfsSelect widget is not depending of filemanager anymore, show it always 2017-10-12 10:17:58 +02:00
Hadi Nategh
8b84f56421 Fix uglify js error, complaining about ES6 syntax 2017-10-12 10:05:26 +02:00
Hadi Nategh
448cc8975f W.I.P of VFS Select widget restructure 2017-10-11 18:27:42 +02:00
Hadi Nategh
f9aec1bf46 Take respective window object into account while building loading_prompt 2017-10-11 15:03:34 +02:00
nathangray
82dd2cbc11 Fix some bugs in printing:
- Framework was iterating over all app tabs, not just the current one
- Skip hidden etemplate widgets
2017-10-10 10:16:08 -06:00
Ralf Becker
d78d3834c0 tel: links use no URL encoding according to rfc3966 section-5.1.4 2017-10-09 10:54:32 +02:00
Hadi Nategh
de65d91dc7 Rmove fields for none private cutomfields when name refers to a single custom field 2017-10-06 16:27:37 +02:00
nathangray
a09ab65973 Fix bug preventing etemplates in iframes from being unloaded 2017-10-05 11:18:09 -06:00
nathangray
0183635c02 Add permission check for collabora before setting actions to open in editor 2017-10-05 09:55:06 -06:00
Hadi Nategh
53acbfe3ea Add some documentation 2017-10-05 17:48:43 +02:00
Nathan Gray
2659ab99ff Merge pull request #20 from filkaris/allow_single_deselect
Allow single deselect for listboxes
2017-10-05 09:28:06 -06:00
Hadi Nategh
eb14b81d51 Handle filemanager links 2017-10-05 17:07:59 +02:00
Hadi Nategh
0e06fe0d64 Implement editor link handler for registered filemanager editors 2017-10-05 15:20:45 +02:00
A Sigalas
58326d07f6 Allow single deselect for listboxes 2017-10-05 10:20:01 +00:00
Ralf Becker
6a3a944828 fix uncaught exception if Collabora is not configured or reachable 2017-10-05 11:00:38 +02:00
nathangray
1868b40359 Set up merge to open editable documents if collabora is there 2017-10-04 14:15:47 -06:00
Hadi Nategh
50697efe55 Check if the given options are type of array or object before proceeding of translation. Fix bug "cannot assign to read only property '0' of string" in tracker site configuration. 2017-10-02 16:15:29 +02:00
nathangray
9f4f62c7aa Fix timestamp button for CKEditor 2017-09-27 10:16:27 -06:00
nathangray
285eb8494b Addressbook - Merging contacts now keeps all distribution lists, and it works now 2017-09-27 09:00:46 -06:00
Ralf Becker
1ae0f29f01 return "400 Bad Request" if propfind contains invalid elements or more then one 2017-09-26 19:13:05 +02:00
nathangray
2d57801c6a * Addressbook - Merging contacts now keeps all distribution lists 2017-09-26 11:05:34 -06:00
Hadi Nategh
a4fdc052ab Filemanager "New" actions:
- Add "New" actions into nm header as drop down list
- Re-arrange actions in contextmenu
- Let Etemplate modifies sel_options if extra changes are available
2017-09-26 18:43:18 +02:00
Hadi Nategh
edf6e16996 * Addressbook: Add searching feature for distribution list filter 2017-09-26 16:57:45 +02:00
Hadi Nategh
772d6605a0 Avoid binding click handler multiple times 2017-09-26 15:27:01 +02:00
Hadi Nategh
4a69b8ddf4 Fix dropdown_button click handler gets called twice 2017-09-26 14:49:45 +02:00
Hadi Nategh
6407379388 Accept localhost as a valid url 2017-09-26 11:37:37 +02:00
nathangray
2078025eea Allow keyboard shortcuts for toolbar actions 2017-09-25 16:11:22 -06:00
nathangray
17debc8063 Add timestamp button widget, use it in infolog 2017-09-21 14:56:40 -06:00
Ralf Becker
a6ec69169d document and enhance function signaure for server-side callback of file and vfs-upload widget
also make it usable for vfs-upload widget with it's id containing entry's id
2017-09-21 11:33:40 +02:00
nathangray
2876a2838c Adjust 'Group' account search keyword so even if someone searches for 'Group', we still respect the 'type' parameter and only return user accounts if that was what was requested. 2017-09-20 09:27:39 -06:00
nathangray
1cddf83306 Etemplate - Ignore all hidden nodes when re-calculating size, fixes nm resizing issue with other hidden nodes after it 2017-09-19 11:07:08 -06:00
Hadi Nategh
6e91053f49 Fix smime key not being recognized by new get_key method 2017-09-19 12:52:43 +02:00
Ralf Becker
48554590f4 * Addressbook: store S/Mime & PGP pubkey and photo (SQL backend only) in filesystem 2017-09-19 11:38:48 +02:00
Ralf Becker
23e654ab89 fix IDE warnings 2017-09-19 11:38:48 +02:00
nathangray
6c7356c48e Etemplate - Link widget - Stop app selection from hiding when you try to click it, fix app selection that only selected addressbook. 2017-09-14 09:52:19 -06:00
nathangray
5b4fd418bf Etemplate - change select multiple validation to also consider rows > 1 to enable multiple 2017-09-14 09:19:26 -06:00
nathangray
e0eb181373 Test for overriding Horde's translations with our own 2017-09-13 17:10:48 -06:00
nathangray
95e66730c4 Etemplate - add 'app_icons' option for link-entry to show app selection as a list with icons 2017-09-13 10:22:07 -06:00
Hadi Nategh
3cdd77e687 Consider multiple rows ids when calculating row_ids, plus does comma separation
and URL encoding
2017-09-12 14:47:08 +02:00
Hadi Nategh
7c11d37480 Add row_id as an another nm_action url parameter 2017-09-11 19:10:47 +02:00
Hadi Nategh
35f2f3fcf1 Fix allowFreeEntry taglist does not get rendered after focus out from input field 2017-09-11 11:57:55 +02:00