extern/hishtory
1
0
Fork 0
mirror of https://github.com/ddworken/hishtory.git synced 2025-06-20 11:57:50 +02:00
Code Issues Packages Projects Releases Wiki Activity

Add sanity checking to ensure we don't ever have a bug that uses flags as secret keys

Browse Source
This commit is contained in:
David Dworken 2024-10-19 01:54:36 -07:00
parent da53939cf8
commit 06424dfca8
No known key found for this signature in database
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
client/cmd/install.go
View File

@ -42,7 +42,10 @@ var installCmd = &cobra.Command{
if len(args) > 0 { if len(args) > 0 {
secretKey = args[0] secretKey = args[0]
} }
lib.CheckFatalError(install(secretKey, *offlineInstall, *skipConfigModification)) if strings.HasPrefix(secretKey, "-") {
lib.CheckFatalError(fmt.Errorf("secret key %#v looks like a CLI flag, please use a secret key that does not start with a -", secretKey))
}
// TODO: Add a check to crash if secretKey looks like a flag lib.CheckFatalError(install(secretKey, *offlineInstall, *skipConfigModification))
if os.Getenv("HISHTORY_SKIP_INIT_IMPORT") == "" { if os.Getenv("HISHTORY_SKIP_INIT_IMPORT") == "" {
db, err := hctx.OpenLocalSqliteDb() db, err := hctx.OpenLocalSqliteDb()
lib.CheckFatalError(err) lib.CheckFatalError(err)